From 19d816c54ad24d93b2af6ba2f0406d6f8df0a3af Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Sun, 22 Jul 2018 16:59:38 +0200 Subject: [PATCH] input/wav: Fix potential buffer overflow (and compiler warning). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With gcc 8 this yielded: src/input/wav.c: In function ‘receive’: src/input/wav.c:345:51: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=] snprintf(channelname, sizeof(channelname), "CH%d", i + 1); ^~ src/input/wav.c:345:48: note: directive argument in the range [1, 2147483647] snprintf(channelname, sizeof(channelname), "CH%d", i + 1); ^~~~~~ src/input/wav.c:345:5: note: ‘snprintf’ output between 4 and 13 bytes into a destination of size 8 snprintf(channelname, sizeof(channelname), "CH%d", i + 1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- src/input/wav.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/input/wav.c b/src/input/wav.c index 66dfce98..b6d55888 100644 --- a/src/input/wav.c +++ b/src/input/wav.c @@ -320,7 +320,7 @@ static int receive(struct sr_input *in, GString *buf) { struct context *inc; int ret; - char channelname[8]; + char channelname[16]; g_string_append_len(in->buf, buf->str, buf->len);