From 640982114329b28aaca3390913037eddd8c6d550 Mon Sep 17 00:00:00 2001 From: Bert Vermeulen Date: Thu, 2 Oct 2014 13:51:19 +0200 Subject: [PATCH] input: Avoid NULL dereference. This cleans up a warning generated by clang's static analyzer. --- src/input/input.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/input/input.c b/src/input/input.c index 4b0804a5..3c7fd516 100644 --- a/src/input/input.c +++ b/src/input/input.c @@ -271,15 +271,17 @@ SR_API struct sr_input *sr_input_new(const struct sr_input_module *imod, if (in->module->init && in->module->init(in, new_opts) != SR_OK) { g_free(in); in = NULL; + } else { + in->buf = g_string_sized_new(128); } + if (new_opts) g_hash_table_destroy(new_opts); - in->buf = g_string_sized_new(128); return in; } -/* Returns TRUE is all required meta items are available. */ +/* Returns TRUE if all required meta items are available. */ static gboolean check_required_metadata(const uint8_t *metadata, uint8_t *avail) { int m, a;