From 70e28e780244427fc645427731ad1ea299228e51 Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs Date: Wed, 17 Aug 2016 01:16:40 +0200 Subject: [PATCH] fs9721: properly set encoding digits --- src/dmm/fs9721.c | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/dmm/fs9721.c b/src/dmm/fs9721.c index eaf5b477..d4a857d3 100644 --- a/src/dmm/fs9721.c +++ b/src/dmm/fs9721.c @@ -130,7 +130,7 @@ static gboolean flags_valid(const struct fs9721_info *info) return TRUE; } -static int parse_value(const uint8_t *buf, float *result) +static int parse_value(const uint8_t *buf, float *result, int *exponent) { int i, sign, intval = 0, digits[4]; uint8_t digit_bytes[4]; @@ -179,15 +179,16 @@ static int parse_value(const uint8_t *buf, float *result) /* Decimal point position. */ if ((buf[3] & (1 << 3)) != 0) { - floatval /= 1000; + *exponent = -3; sr_spew("Decimal point after first digit."); } else if ((buf[5] & (1 << 3)) != 0) { - floatval /= 100; + *exponent = -2; sr_spew("Decimal point after second digit."); } else if ((buf[7] & (1 << 3)) != 0) { - floatval /= 10; + *exponent = -1; sr_spew("Decimal point after third digit."); } else { + *exponent = 0; sr_spew("No decimal point in the number."); } @@ -244,19 +245,20 @@ static void parse_flags(const uint8_t *buf, struct fs9721_info *info) } static void handle_flags(struct sr_datafeed_analog *analog, float *floatval, - const struct fs9721_info *info) + int *exponent, const struct fs9721_info *info) { /* Factors */ if (info->is_nano) - *floatval /= 1000000000; + *exponent -= 9; if (info->is_micro) - *floatval /= 1000000; + *exponent -= 6; if (info->is_milli) - *floatval /= 1000; + *exponent -= 3; if (info->is_kilo) - *floatval *= 1000; + *exponent += 3; if (info->is_mega) - *floatval *= 1000000; + *exponent += 6; + *floatval *= powf(10, *exponent); /* Measurement modes */ if (info->is_volt) { @@ -349,18 +351,21 @@ SR_PRIV gboolean sr_fs9721_packet_valid(const uint8_t *buf) SR_PRIV int sr_fs9721_parse(const uint8_t *buf, float *floatval, struct sr_datafeed_analog *analog, void *info) { - int ret; + int ret, exponent = 0; struct fs9721_info *info_local; info_local = (struct fs9721_info *)info; - if ((ret = parse_value(buf, floatval)) != SR_OK) { + if ((ret = parse_value(buf, floatval, &exponent)) != SR_OK) { sr_dbg("Error parsing value: %d.", ret); return ret; } parse_flags(buf, info_local); - handle_flags(analog, floatval, info_local); + handle_flags(analog, floatval, &exponent, info_local); + + analog->encoding->digits = -exponent; + analog->spec->spec_digits = -exponent; return SR_OK; }