From a99ff45359a590739c8a66458511c64d00033a5d Mon Sep 17 00:00:00 2001 From: Florian Ragwitz Date: Sat, 28 Nov 2020 18:18:35 -0800 Subject: [PATCH] beaglelogic: Fix resource leak --- src/hardware/beaglelogic/beaglelogic_native.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/hardware/beaglelogic/beaglelogic_native.c b/src/hardware/beaglelogic/beaglelogic_native.c index 42d51edf..af5e650f 100644 --- a/src/hardware/beaglelogic/beaglelogic_native.c +++ b/src/hardware/beaglelogic/beaglelogic_native.c @@ -88,10 +88,12 @@ static int beaglelogic_get_lasterror(struct dev_context *devc) if ((fd = open(BEAGLELOGIC_SYSFS_ATTR(lasterror), O_RDONLY)) == -1) return SR_ERR; - if ((ret = read(fd, buf, 16)) < 0) + ret = read(fd, buf, 16); + close(fd); + + if (ret) return SR_ERR; - close(fd); devc->last_error = strtoul(buf, NULL, 10); return SR_OK;