diff --git a/include/libsigrok/proto.h b/include/libsigrok/proto.h index 069e7e84..c2a8173f 100644 --- a/include/libsigrok/proto.h +++ b/include/libsigrok/proto.h @@ -111,6 +111,8 @@ SR_API int sr_session_destroy(struct sr_session *session); SR_API int sr_session_dev_remove_all(struct sr_session *session); SR_API int sr_session_dev_add(struct sr_session *session, struct sr_dev_inst *sdi); +SR_API int sr_session_dev_remove(struct sr_session *session, + struct sr_dev_inst *sdi); SR_API int sr_session_dev_list(struct sr_session *session, GSList **devlist); SR_API int sr_session_trigger_set(struct sr_session *session, struct sr_trigger *trig); diff --git a/src/device.c b/src/device.c index 537c89ef..0eb86f4d 100644 --- a/src/device.c +++ b/src/device.c @@ -261,6 +261,9 @@ SR_PRIV void sr_dev_inst_free(struct sr_dev_inst *sdi) } g_slist_free(sdi->channel_groups); + if (sdi->session) + sr_session_dev_remove(sdi->session, sdi); + g_free(sdi->vendor); g_free(sdi->model); g_free(sdi->version); diff --git a/src/session.c b/src/session.c index f9df6e1f..6cf803dd 100644 --- a/src/session.c +++ b/src/session.c @@ -403,6 +403,45 @@ SR_API int sr_session_dev_list(struct sr_session *session, GSList **devlist) return SR_OK; } +/** + * Remove a device instance from a session. + * + * @param session The session to remove from. Must not be NULL. + * @param sdi The device instance to remove from a session. Must not + * be NULL. Also, sdi->driver and sdi->driver->dev_open must + * not be NULL. + * + * @retval SR_OK Success. + * @retval SR_ERR_ARG Invalid argument. + * + * @since 0.4.0 + */ +SR_API int sr_session_dev_remove(struct sr_session *session, + struct sr_dev_inst *sdi) +{ + if (!sdi) { + sr_err("%s: sdi was NULL", __func__); + return SR_ERR_ARG; + } + + if (!session) { + sr_err("%s: session was NULL", __func__); + return SR_ERR_ARG; + } + + /* If sdi->session is not session, the device is not in this + * session. */ + if (sdi->session != session) { + sr_err("%s: not assigned to this session", __func__); + return SR_ERR_ARG; + } + + session->devs = g_slist_remove(session->devs, sdi); + sdi->session = NULL; + + return SR_OK; +} + /** * Remove all datafeed callbacks in a session. *