From 169b6acd24d2a547fa87c087cac3808f00eb7fcc Mon Sep 17 00:00:00 2001 From: Aris Poloway Date: Sun, 8 Apr 2018 11:47:11 -0400 Subject: [PATCH] Clean up download dialog opening --- .../schabi/newpipe/fragments/detail/VideoDetailFragment.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java index 653ce2082..d5a830461 100644 --- a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java +++ b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java @@ -356,10 +356,9 @@ public class VideoDetailFragment } break; case R.id.detail_controls_download: - if (!PermissionHelper.checkStoragePermissions(activity, PermissionHelper.DOWNLOAD_DIALOG_REQUEST_CODE)) { - return; + if (PermissionHelper.checkStoragePermissions(activity, PermissionHelper.DOWNLOAD_DIALOG_REQUEST_CODE)) { + this.openDownloadDialog(); } - this.openDownloadDialog(); break; case R.id.detail_uploader_root_layout: if (TextUtils.isEmpty(currentInfo.getUploaderUrl())) {