Rename dummy_* and more to placeholder_*

This commit is contained in:
Stypox 2022-07-14 10:58:48 +02:00
parent 4d58026d06
commit 6ea85e6380
No known key found for this signature in database
GPG Key ID: 4BDF1B40A49FDD23
31 changed files with 39 additions and 38 deletions

View File

@ -1552,7 +1552,7 @@ public final class VideoDetailFragment
} }
final Drawable buddyDrawable final Drawable buddyDrawable
= AppCompatResources.getDrawable(activity, R.drawable.dummy_person); = AppCompatResources.getDrawable(activity, R.drawable.placeholder_person);
binding.detailSubChannelThumbnailView.setImageDrawable(buddyDrawable); binding.detailSubChannelThumbnailView.setImageDrawable(buddyDrawable);
binding.detailUploaderThumbnailView.setImageDrawable(buddyDrawable); binding.detailUploaderThumbnailView.setImageDrawable(buddyDrawable);

View File

@ -145,7 +145,8 @@ public final class PlaylistAppendDialog extends PlaylistDialog {
final Toast successToast = Toast.makeText(getContext(), final Toast successToast = Toast.makeText(getContext(),
R.string.playlist_add_stream_success, Toast.LENGTH_SHORT); R.string.playlist_add_stream_success, Toast.LENGTH_SHORT);
if (playlist.thumbnailUrl.equals("drawable://" + R.drawable.dummy_thumbnail_playlist)) { if (playlist.thumbnailUrl
.equals("drawable://" + R.drawable.placeholder_thumbnail_playlist)) {
playlistDisposables.add(manager playlistDisposables.add(manager
.changePlaylistThumbnail(playlist.uid, streams.get(0).getThumbnailUrl()) .changePlaylistThumbnail(playlist.uid, streams.get(0).getThumbnailUrl())
.observeOn(AndroidSchedulers.mainThread()) .observeOn(AndroidSchedulers.mainThread())

View File

@ -613,7 +613,7 @@ public class LocalPlaylistFragment extends BaseLocalListFragment<List<PlaylistSt
newThumbnailUrl = ((PlaylistStreamEntry) itemListAdapter.getItemsList().get(0)) newThumbnailUrl = ((PlaylistStreamEntry) itemListAdapter.getItemsList().get(0))
.getStreamEntity().getThumbnailUrl(); .getStreamEntity().getThumbnailUrl();
} else { } else {
newThumbnailUrl = "drawable://" + R.drawable.dummy_thumbnail_playlist; newThumbnailUrl = "drawable://" + R.drawable.placeholder_thumbnail_playlist;
} }
changeThumbnailUrl(newThumbnailUrl); changeThumbnailUrl(newThumbnailUrl);

View File

@ -3108,7 +3108,7 @@ public final class Player implements
public Bitmap getThumbnail() { public Bitmap getThumbnail() {
if (currentThumbnail == null) { if (currentThumbnail == null) {
currentThumbnail = BitmapFactory.decodeResource( currentThumbnail = BitmapFactory.decodeResource(
context.getResources(), R.drawable.dummy_thumbnail); context.getResources(), R.drawable.placeholder_thumbnail_video);
} }
return currentThumbnail; return currentThumbnail;
} }

View File

@ -97,23 +97,23 @@ public final class PicassoHelper {
public static RequestCreator loadAvatar(final String url) { public static RequestCreator loadAvatar(final String url) {
return loadImageDefault(url, R.drawable.dummy_person); return loadImageDefault(url, R.drawable.placeholder_person);
} }
public static RequestCreator loadThumbnail(final String url) { public static RequestCreator loadThumbnail(final String url) {
return loadImageDefault(url, R.drawable.dummy_thumbnail); return loadImageDefault(url, R.drawable.placeholder_thumbnail_video);
} }
public static RequestCreator loadDetailsThumbnail(final String url) { public static RequestCreator loadDetailsThumbnail(final String url) {
return loadImageDefault(url, R.drawable.dummy_thumbnail, false); return loadImageDefault(url, R.drawable.placeholder_thumbnail_video, false);
} }
public static RequestCreator loadBanner(final String url) { public static RequestCreator loadBanner(final String url) {
return loadImageDefault(url, R.drawable.channel_banner); return loadImageDefault(url, R.drawable.placeholder_channel_banner);
} }
public static RequestCreator loadPlaylistThumbnail(final String url) { public static RequestCreator loadPlaylistThumbnail(final String url) {
return loadImageDefault(url, R.drawable.dummy_thumbnail_playlist); return loadImageDefault(url, R.drawable.placeholder_thumbnail_playlist);
} }
public static RequestCreator loadSeekbarThumbnailPreview(final String url) { public static RequestCreator loadSeekbarThumbnailPreview(final String url) {

View File

Before

Width:  |  Height:  |  Size: 30 KiB

After

Width:  |  Height:  |  Size: 30 KiB

View File

@ -57,7 +57,7 @@
android:scaleType="fitCenter" android:scaleType="fitCenter"
tools:ignore="RtlHardcoded" tools:ignore="RtlHardcoded"
tools:layout_height="200dp" tools:layout_height="200dp"
tools:src="@drawable/dummy_thumbnail" /> tools:src="@drawable/placeholder_thumbnail_video" />
<ImageView <ImageView
android:id="@+id/detail_thumbnail_play_button" android:id="@+id/detail_thumbnail_play_button"
@ -271,7 +271,7 @@
android:layout_width="@dimen/video_item_detail_uploader_image_size" android:layout_width="@dimen/video_item_detail_uploader_image_size"
android:layout_height="@dimen/video_item_detail_uploader_image_size" android:layout_height="@dimen/video_item_detail_uploader_image_size"
android:contentDescription="@string/detail_uploader_thumbnail_view_description" android:contentDescription="@string/detail_uploader_thumbnail_view_description"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" /> app:shapeAppearance="@style/CircularImageView" />
<com.google.android.material.imageview.ShapeableImageView <com.google.android.material.imageview.ShapeableImageView
@ -280,7 +280,7 @@
android:layout_height="@dimen/video_item_detail_sub_channel_image_size" android:layout_height="@dimen/video_item_detail_sub_channel_image_size"
android:layout_gravity="bottom|right" android:layout_gravity="bottom|right"
android:contentDescription="@string/detail_sub_channel_thumbnail_view_description" android:contentDescription="@string/detail_sub_channel_thumbnail_view_description"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
android:visibility="gone" android:visibility="gone"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:visibility="visible" /> tools:visibility="visible" />
@ -645,7 +645,7 @@
android:paddingLeft="@dimen/video_item_search_padding" android:paddingLeft="@dimen/video_item_search_padding"
android:paddingRight="@dimen/video_item_search_padding" android:paddingRight="@dimen/video_item_search_padding"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" /> android:src="@drawable/placeholder_thumbnail_video" />
<LinearLayout <LinearLayout
android:id="@+id/overlay_metadata_layout" android:id="@+id/overlay_metadata_layout"

View File

@ -18,7 +18,7 @@
android:background="@android:color/black" android:background="@android:color/black"
android:fitsSystemWindows="true" android:fitsSystemWindows="true"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/channel_banner" android:src="@drawable/placeholder_channel_banner"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
<FrameLayout <FrameLayout
@ -33,7 +33,7 @@
android:layout_width="@dimen/channel_avatar_size" android:layout_width="@dimen/channel_avatar_size"
android:layout_height="@dimen/channel_avatar_size" android:layout_height="@dimen/channel_avatar_size"
android:padding="1dp" android:padding="1dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
app:strokeColor="#ffffff" app:strokeColor="#ffffff"
app:strokeWidth="2dp" /> app:strokeWidth="2dp" />
@ -44,7 +44,7 @@
android:layout_height="@dimen/sub_channel_avatar_size" android:layout_height="@dimen/sub_channel_avatar_size"
android:layout_gravity="bottom|right" android:layout_gravity="bottom|right"
android:padding="1dp" android:padding="1dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
android:visibility="gone" android:visibility="gone"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
app:strokeColor="#ffffff" app:strokeColor="#ffffff"

View File

@ -47,7 +47,7 @@
android:scaleType="fitCenter" android:scaleType="fitCenter"
tools:ignore="RtlHardcoded" tools:ignore="RtlHardcoded"
tools:layout_height="200dp" tools:layout_height="200dp"
tools:src="@drawable/dummy_thumbnail" /> tools:src="@drawable/placeholder_thumbnail_video" />
<ImageView <ImageView
android:id="@+id/detail_thumbnail_play_button" android:id="@+id/detail_thumbnail_play_button"
@ -258,7 +258,7 @@
android:layout_width="@dimen/video_item_detail_uploader_image_size" android:layout_width="@dimen/video_item_detail_uploader_image_size"
android:layout_height="@dimen/video_item_detail_uploader_image_size" android:layout_height="@dimen/video_item_detail_uploader_image_size"
android:contentDescription="@string/detail_uploader_thumbnail_view_description" android:contentDescription="@string/detail_uploader_thumbnail_view_description"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" /> app:shapeAppearance="@style/CircularImageView" />
<com.google.android.material.imageview.ShapeableImageView <com.google.android.material.imageview.ShapeableImageView
@ -267,7 +267,7 @@
android:layout_height="@dimen/video_item_detail_sub_channel_image_size" android:layout_height="@dimen/video_item_detail_sub_channel_image_size"
android:layout_gravity="bottom|right" android:layout_gravity="bottom|right"
android:contentDescription="@string/detail_sub_channel_thumbnail_view_description" android:contentDescription="@string/detail_sub_channel_thumbnail_view_description"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
android:visibility="gone" android:visibility="gone"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" tools:ignore="RtlHardcoded"

View File

@ -18,7 +18,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="@dimen/play_queue_thumbnail_width" android:layout_height="@dimen/play_queue_thumbnail_width"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
app:layout_constraintDimensionRatio="16:9" app:layout_constraintDimensionRatio="16:9"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"

View File

@ -18,7 +18,7 @@
android:layout_centerHorizontal="true" android:layout_centerHorizontal="true"
android:layout_margin="2dp" android:layout_margin="2dp"
android:contentDescription="@string/detail_uploader_thumbnail_view_description" android:contentDescription="@string/detail_uploader_thumbnail_view_description"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />

View File

@ -64,7 +64,7 @@
android:layout_height="@dimen/video_item_search_avatar_image_height" android:layout_height="@dimen/video_item_search_avatar_image_height"
android:layout_marginLeft="@dimen/video_item_search_avatar_left_margin" android:layout_marginLeft="@dimen/video_item_search_avatar_left_margin"
android:layout_marginRight="@dimen/video_item_search_avatar_right_margin" android:layout_marginRight="@dimen/video_item_search_avatar_right_margin"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/itemTitleView" app:layout_constraintEnd_toStartOf="@+id/itemTitleView"
app:layout_constraintHorizontal_bias="0.5" app:layout_constraintHorizontal_bias="0.5"

View File

@ -17,7 +17,7 @@
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginStart="3dp" android:layout_marginStart="3dp"
android:layout_marginRight="15dp" android:layout_marginRight="15dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />

View File

@ -20,7 +20,7 @@
android:layout_marginLeft="3dp" android:layout_marginLeft="3dp"
android:layout_marginRight="@dimen/comment_item_avatar_right_margin" android:layout_marginRight="@dimen/comment_item_avatar_right_margin"
android:focusable="false" android:focusable="false"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />

View File

@ -17,7 +17,7 @@
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginStart="3dp" android:layout_marginStart="3dp"
android:layout_marginRight="15dp" android:layout_marginRight="15dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />

View File

@ -17,7 +17,7 @@
android:layout_centerHorizontal="true" android:layout_centerHorizontal="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitStart" android:scaleType="fitStart"
android:src="@drawable/dummy_thumbnail_playlist" android:src="@drawable/placeholder_thumbnail_playlist"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -18,7 +18,7 @@
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitStart" android:scaleType="fitStart"
android:src="@drawable/dummy_thumbnail_playlist" android:src="@drawable/placeholder_thumbnail_playlist"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -18,7 +18,7 @@
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitStart" android:scaleType="fitStart"
android:src="@drawable/dummy_thumbnail_playlist" android:src="@drawable/placeholder_thumbnail_playlist"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -15,7 +15,7 @@
android:layout_width="@dimen/video_item_grid_thumbnail_image_width" android:layout_width="@dimen/video_item_grid_thumbnail_image_width"
android:layout_height="@dimen/video_item_grid_thumbnail_image_height" android:layout_height="@dimen/video_item_grid_thumbnail_image_height"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />

View File

@ -15,7 +15,7 @@
android:layout_width="@dimen/video_item_search_thumbnail_image_width" android:layout_width="@dimen/video_item_search_thumbnail_image_width"
android:layout_height="@dimen/video_item_search_thumbnail_image_height" android:layout_height="@dimen/video_item_search_thumbnail_image_height"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
app:layout_constraintBottom_toTopOf="@+id/itemProgressView" app:layout_constraintBottom_toTopOf="@+id/itemProgressView"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />

View File

@ -18,7 +18,7 @@
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -17,7 +17,7 @@
android:layout_centerHorizontal="true" android:layout_centerHorizontal="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -18,7 +18,7 @@
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_marginRight="@dimen/video_item_search_image_right_margin" android:layout_marginRight="@dimen/video_item_search_image_right_margin"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView

View File

@ -22,7 +22,7 @@
android:layout_width="48dp" android:layout_width="48dp"
android:layout_height="48dp" android:layout_height="48dp"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:src="@drawable/dummy_person" /> tools:src="@drawable/placeholder_person" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView
android:id="@+id/title_view" android:id="@+id/title_view"

View File

@ -18,7 +18,7 @@
android:layout_marginTop="@dimen/video_item_search_image_right_margin" android:layout_marginTop="@dimen/video_item_search_image_right_margin"
android:layout_marginBottom="@dimen/video_item_search_image_right_margin" android:layout_marginBottom="@dimen/video_item_search_image_right_margin"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />

View File

@ -397,7 +397,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingTop="2dp" android:paddingTop="2dp"
android:src="@drawable/dummy_thumbnail" android:src="@drawable/placeholder_thumbnail_video"
android:visibility="gone" android:visibility="gone"
tools:visibility="visible" /> tools:visibility="visible" />

View File

@ -45,7 +45,7 @@
android:layout_alignParentLeft="true" android:layout_alignParentLeft="true"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:padding="0.7dp" android:padding="0.7dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
app:strokeColor="#ffffff" app:strokeColor="#ffffff"
app:strokeWidth="1dp" /> app:strokeWidth="1dp" />

View File

@ -19,7 +19,7 @@
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_marginStart="3dp" android:layout_marginStart="3dp"
android:layout_marginRight="8dp" android:layout_marginRight="8dp"
android:src="@drawable/dummy_person" android:src="@drawable/placeholder_person"
app:shapeAppearance="@style/CircularImageView" app:shapeAppearance="@style/CircularImageView"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />