From cfdcb92fa32fec1f323831157027b6ee72ae4e07 Mon Sep 17 00:00:00 2001 From: Stypox Date: Mon, 30 Aug 2021 16:18:40 +0200 Subject: [PATCH] Always use our strings, not android ones --- .../fragments/detail/VideoDetailFragment.java | 2 +- .../subscription/dialog/FeedGroupDialog.kt | 24 +++++++------------ .../settings/ContentSettingsFragment.java | 4 ++-- 3 files changed, 12 insertions(+), 18 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java index 7ee70fcc4..0b3ddc3c3 100644 --- a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java +++ b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java @@ -2071,7 +2071,7 @@ public final class VideoDetailFragment new AlertDialog.Builder(activity) .setTitle(R.string.clear_queue_confirmation_description) .setNegativeButton(R.string.cancel, null) - .setPositiveButton(android.R.string.yes, (dialog, which) -> { + .setPositiveButton(R.string.ok, (dialog, which) -> { onAllow.run(); dialog.dismiss(); }).show(); diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt b/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt index cb0c5fe35..69d4c8819 100644 --- a/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt +++ b/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt @@ -143,21 +143,15 @@ class FeedGroupDialog : DialogFragment(), BackPressable { ).get(FeedGroupDialogViewModel::class.java) viewModel.groupLiveData.observe(viewLifecycleOwner, Observer(::handleGroup)) - viewModel.subscriptionsLiveData.observe( - viewLifecycleOwner, - Observer { - setupSubscriptionPicker(it.first, it.second) + viewModel.subscriptionsLiveData.observe(viewLifecycleOwner) { + setupSubscriptionPicker(it.first, it.second) + } + viewModel.dialogEventLiveData.observe(viewLifecycleOwner) { + when (it) { + ProcessingEvent -> disableInput() + SuccessEvent -> dismiss() } - ) - viewModel.dialogEventLiveData.observe( - viewLifecycleOwner, - Observer { - when (it) { - ProcessingEvent -> disableInput() - SuccessEvent -> dismiss() - } - } - ) + } subscriptionGroupAdapter = GroupAdapter().apply { add(subscriptionMainSection) @@ -437,7 +431,7 @@ class FeedGroupDialog : DialogFragment(), BackPressable { feedGroupCreateBinding.confirmButton.setText( when { currentScreen == InitialScreen && groupId == NO_GROUP_SELECTED -> R.string.create - else -> android.R.string.ok + else -> R.string.ok } ) diff --git a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java index 831f50dc7..6e7e75932 100644 --- a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java +++ b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java @@ -232,11 +232,11 @@ public class ContentSettingsFragment extends BasePreferenceFragment { final AlertDialog.Builder alert = new AlertDialog.Builder(requireContext()); alert.setTitle(R.string.import_settings); - alert.setNegativeButton(android.R.string.no, (dialog, which) -> { + alert.setNegativeButton(R.string.cancel, (dialog, which) -> { dialog.dismiss(); finishImport(importDataUri); }); - alert.setPositiveButton(getString(R.string.ok), (dialog, which) -> { + alert.setPositiveButton(R.string.ok, (dialog, which) -> { dialog.dismiss(); manager.loadSharedPreferences(PreferenceManager .getDefaultSharedPreferences(requireContext()));