From 16973126a0b2c68f5cfbfad2618f8248ff11e654 Mon Sep 17 00:00:00 2001
From: TobiGr <tobigr@users.noreply.github.com>
Date: Tue, 16 Feb 2021 20:25:48 +0100
Subject: [PATCH] Use Collections.emptyList() instead of Collections.EMPTY_LIST
 or new ArrayList()

---
 .../extractor/linkhandler/ListLinkHandlerFactory.java     | 3 ++-
 .../bandcamp/extractors/BandcampRadioStreamExtractor.java | 3 ++-
 .../bandcamp/extractors/BandcampStreamExtractor.java      | 8 ++++----
 .../bandcamp/extractors/BandcampSuggestionExtractor.java  | 3 ++-
 4 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java b/extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java
index 86991c4df..11b94c7a5 100644
--- a/extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java
+++ b/extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java
@@ -4,6 +4,7 @@ import org.schabi.newpipe.extractor.exceptions.ParsingException;
 import org.schabi.newpipe.extractor.utils.Utils;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
@@ -13,7 +14,7 @@ public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
     ///////////////////////////////////
 
     public List<String> getContentFilter(String url) throws ParsingException {
-        return new ArrayList<>(0);
+        return Collections.emptyList();
     }
 
     public String getSortFilter(String url) throws ParsingException {
diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioStreamExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioStreamExtractor.java
index a0c109810..01ed5ad5a 100644
--- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioStreamExtractor.java
+++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioStreamExtractor.java
@@ -20,6 +20,7 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 import static org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper.getImageUrl;
@@ -137,6 +138,6 @@ public class BandcampRadioStreamExtractor extends BandcampStreamExtractor {
     @Nonnull
     @Override
     public List<String> getTags() {
-        return new ArrayList<>();
+        return Collections.emptyList();
     }
 }
diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java
index 3409a4cd2..856ad54ba 100644
--- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java
+++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java
@@ -211,24 +211,24 @@ public class BandcampStreamExtractor extends StreamExtractor {
 
     @Override
     public List<VideoStream> getVideoStreams() {
-        return Collections.EMPTY_LIST;
+        return Collections.emptyList();
     }
 
     @Override
     public List<VideoStream> getVideoOnlyStreams() {
-        return Collections.EMPTY_LIST;
+        return Collections.emptyList();
     }
 
     @Nonnull
     @Override
     public List<SubtitlesStream> getSubtitlesDefault() {
-        return new ArrayList<>();
+        return Collections.emptyList();
     }
 
     @Nonnull
     @Override
     public List<SubtitlesStream> getSubtitles(MediaFormat format) {
-        return new ArrayList<>();
+        return Collections.emptyList();
     }
 
     @Override
diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java
index bb1ababb2..cc7d384f3 100644
--- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java
+++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java
@@ -15,6 +15,7 @@ import org.schabi.newpipe.extractor.suggestion.SuggestionExtractor;
 import java.io.IOException;
 import java.net.URLEncoder;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 public class BandcampSuggestionExtractor extends SuggestionExtractor {
@@ -48,7 +49,7 @@ public class BandcampSuggestionExtractor extends SuggestionExtractor {
         } catch (final JsonParserException e) {
             e.printStackTrace();
 
-            return new ArrayList<>();
+            return Collections.emptyList();
         }