From f92426560c8053351db5c0052c3c384c76bb0003 Mon Sep 17 00:00:00 2001 From: AudricV <74829229+AudricV@users.noreply.github.com> Date: Fri, 18 Nov 2022 21:47:42 +0100 Subject: [PATCH] Add descriptive audio properties Also improve AudioStream's audio language documentation --- .../newpipe/extractor/stream/AudioStream.java | 73 +++++++++++++++++-- 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java b/extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java index 3db70b599..9004e47b6 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java @@ -43,8 +43,12 @@ public final class AudioStream extends Stream { private String codec; // Fields about the audio track id/name - private String audioTrackId; - private String audioTrackName; + @Nullable + private final String audioTrackId; + @Nullable + private final String audioTrackName; + private final boolean isDescriptive; + @Nullable private ItagItem itagItem; @@ -66,6 +70,7 @@ public final class AudioStream extends Stream { private String audioTrackId; @Nullable private String audioTrackName; + private boolean isDescriptive; @Nullable private ItagItem itagItem; @@ -185,7 +190,11 @@ public final class AudioStream extends Stream { /** * Set the audio track id of the {@link AudioStream}. * - * @param audioTrackId the audio track id of the {@link AudioStream} + *
+ * The default value is {@code null}. + *
+ * + * @param audioTrackId the audio track id of the {@link AudioStream}, which can be null * @return this {@link Builder} instance */ public Builder setAudioTrackId(@Nullable final String audioTrackId) { @@ -196,7 +205,11 @@ public final class AudioStream extends Stream { /** * Set the audio track name of the {@link AudioStream}. * - * @param audioTrackName the audio track name of the {@link AudioStream} + *+ * The default value is {@code null}. + *
+ * + * @param audioTrackName the audio track name of the {@link AudioStream}, which can be null * @return this {@link Builder} instance */ public Builder setAudioTrackName(@Nullable final String audioTrackName) { @@ -204,6 +217,29 @@ public final class AudioStream extends Stream { return this; } + /** + * Set whether this {@link AudioStream} is a descriptive audio. + * + *+ * A descriptive audio is an audio in which descriptions of visual elements of a video are + * added in the original audio, with the goal to make a video more accessible to blind and + * visually impaired people. + *
+ * + *+ * The default value is {@code false}. + *
+ * + * @param isDescriptive whether this {@link AudioStream} is a descriptive audio + * @return this {@link Builder} instance + * @see + * https://en.wikipedia.org/wiki/Audio_description + */ + public Builder setIsDescriptive(final boolean isDescriptive) { + this.isDescriptive = isDescriptive; + return this; + } + /** * Set the {@link ItagItem} corresponding to the {@link AudioStream}. * @@ -257,7 +293,7 @@ public final class AudioStream extends Stream { } return new AudioStream(id, content, isUrl, mediaFormat, deliveryMethod, averageBitrate, - manifestUrl, audioTrackId, audioTrackName, itagItem); + manifestUrl, audioTrackId, audioTrackName, isDescriptive, itagItem); } } @@ -291,6 +327,7 @@ public final class AudioStream extends Stream { @Nullable final String manifestUrl, @Nullable final String audioTrackId, @Nullable final String audioTrackName, + final boolean isDescriptive, @Nullable final ItagItem itagItem) { super(id, content, isUrl, format, deliveryMethod, manifestUrl); if (itagItem != null) { @@ -307,6 +344,7 @@ public final class AudioStream extends Stream { this.averageBitrate = averageBitrate; this.audioTrackId = audioTrackId; this.audioTrackName = audioTrackName; + this.isDescriptive = isDescriptive; } /** @@ -316,7 +354,8 @@ public final class AudioStream extends Stream { public boolean equalStats(final Stream cmp) { return super.equalStats(cmp) && cmp instanceof AudioStream && averageBitrate == ((AudioStream) cmp).averageBitrate - && Objects.equals(audioTrackId, ((AudioStream) cmp).audioTrackId); + && Objects.equals(audioTrackId, ((AudioStream) cmp).audioTrackId) + && isDescriptive == ((AudioStream) cmp).isDescriptive; } /** @@ -421,15 +460,33 @@ public final class AudioStream extends Stream { } /** - * Get the name of the audio track. + * Get the name of the audio track, which may be {@code null} if this information is not + * provided by the service. * - * @return the name of the audio track + * @return the name of the audio track or {@code null} */ @Nullable public String getAudioTrackName() { return audioTrackName; } + /** + * Returns whether this stream is a descriptive audio. + * + *+ * A descriptive audio is an audio in which descriptions of visual elements of a video are + * added in the original audio, with the goal to make a video more accessible to blind and + * visually impaired people. + *
+ * + * @return {@code true} this audio stream is a descriptive audio, {@code false} otherwise + * @see + * https://en.wikipedia.org/wiki/Audio_description + */ + public boolean isDescriptive() { + return isDescriptive; + } + /** * {@inheritDoc} */