From 11fd5363ce4015e5e91ffdf1b3cf0feef353b224 Mon Sep 17 00:00:00 2001 From: George Politis Date: Wed, 15 Jul 2020 15:55:30 +0200 Subject: [PATCH] fix: Avoid overwriting the max resolution requested by the tile-view. (#7320) Part of [1] replaces a `setPreferredVideoQuality` call with a `setMaxReceiverVideoQuality` call. The change was part of a bigger changeset that adds logic that tries to adjust the max based on reduced ui turned on or off and allow to set prefered through the config. However, by calling `setMaxReceiverVideoQuality` instead of `setPreferredVideoQuality`, the new feature overrides the lower resolution requested by tile-view earlier in some occasions. This PR reverts back to using `setPreferredVideoQuality` instead of `setMaxReceiverVideoQuality` as this achieves the same result without overwriting the max set by the tile-view. NOTE that this is a quick-fix and all the handling related to setting the receive resolution will be reworked soon. [1]: https://github.com/jitsi/jitsi-meet/commit/7d513738d2179b68a8b21233d2bc9e93d3da05ab --- react/features/conference/middleware.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/react/features/conference/middleware.js b/react/features/conference/middleware.js index 6348e8d32..cf8fcf42f 100644 --- a/react/features/conference/middleware.js +++ b/react/features/conference/middleware.js @@ -6,7 +6,7 @@ import { VIDEO_QUALITY_LEVELS, conferenceLeft, getCurrentConference, - setMaxReceiverVideoQuality + setPreferredVideoQuality } from '../base/conference'; import { hideDialog, isDialogOpen } from '../base/dialog'; import { setActiveModalId } from '../base/modal'; @@ -33,7 +33,7 @@ MiddlewareRegistry.register(store => next => action => { dispatch(setFilmstripEnabled(!reducedUI)); dispatch( - setMaxReceiverVideoQuality( + setPreferredVideoQuality( reducedUI ? VIDEO_QUALITY_LEVELS.LOW : VIDEO_QUALITY_LEVELS.HIGH));