From 573ca97b6c6065360b3f0a97af1752d517b10990 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Thu, 9 Feb 2017 12:02:06 +0100 Subject: [PATCH] [RN] Add workaround for Android view clipping Looks like Android gets confused as to what surface to blit when we hide or show toolbars. Setting a border on the container, seems to force the entire area to blit properly. Other attempted approaches, with no success: - zIndex of -100 - width and height of 0 - opacity of 0 and setting 'disabled' on touch containers This patch applies the workaround in the welcome page and conference containers. --- react/features/conference/components/styles.js | 6 ++++++ react/features/welcome/components/styles.js | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/react/features/conference/components/styles.js b/react/features/conference/components/styles.js index ae07436ef..d39a89031 100644 --- a/react/features/conference/components/styles.js +++ b/react/features/conference/components/styles.js @@ -18,6 +18,12 @@ export const styles = createStyleSheet({ conference: { alignSelf: 'stretch', backgroundColor: ColorPalette.appBackground, + + // XXX These properties are a workaround for Android views clipping, + // RN doesn't properly blit our overlays on top of video views. + borderColor: ColorPalette.appBackground, + borderWidth: 0.2, + flex: 1 }, diff --git a/react/features/welcome/components/styles.js b/react/features/welcome/components/styles.js index 4ea5f7949..421fa46ee 100644 --- a/react/features/welcome/components/styles.js +++ b/react/features/welcome/components/styles.js @@ -38,6 +38,12 @@ export const styles = createStyleSheet({ container: { alignSelf: 'stretch', backgroundColor: ColorPalette.blue, + + // XXX These properties are a workaround for Android views clipping, + // RN doesn't properly blit our overlays on top of video views. + borderColor: ColorPalette.appBackground, + borderWidth: 0.2, + flex: 1 },