From 86130c14784709a2cfe793ce4a434674db328613 Mon Sep 17 00:00:00 2001 From: horymury <39557534+horymury@users.noreply.github.com> Date: Tue, 18 Feb 2020 11:56:09 +0200 Subject: [PATCH] chrome-banner: log success of retrieving configs --- .../components/ChromeExtensionBanner.web.js | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/react/features/chrome-extension-banner/components/ChromeExtensionBanner.web.js b/react/features/chrome-extension-banner/components/ChromeExtensionBanner.web.js index 35e2e491b..0cd2a002c 100644 --- a/react/features/chrome-extension-banner/components/ChromeExtensionBanner.web.js +++ b/react/features/chrome-extension-banner/components/ChromeExtensionBanner.web.js @@ -102,11 +102,19 @@ class ChromeExtensionBanner extends PureComponent { * * @inheritdoc */ - async componentDidUpdate() { + async componentDidUpdate(prevProps) { if (!this._isSupportedEnvironment()) { return; } + if (this.props.chromeExtensionUrl && !prevProps.chromeExtensionUrl) { + logger.info('Chrome extension URL found.'); + } + + if (this.props.chromeExtensionsInfo.length && !prevProps.chromeExtensionsInfo.length) { + logger.info('Chrome extension(s) info found.'); + } + const hasExtensions = await this._checkExtensionsInstalled(); if ( @@ -175,10 +183,6 @@ class ChromeExtensionBanner extends PureComponent { }); const extensionInstalledFunction = info => isExtensionInstalled(info); - if (!this.props.chromeExtensionsInfo.length) { - logger.warn('Further configuration needed, missing chrome extension(s) info'); - } - return Promise.all( this.props.chromeExtensionsInfo.map(info => extensionInstalledFunction(info)) ); @@ -196,15 +200,10 @@ class ChromeExtensionBanner extends PureComponent { return true; } - if (!this.props.chromeExtensionUrl) { - logger.warn('Further configuration needed, missing chrome extension URL'); - - return true; - } - const dontShowAgain = localStorage.getItem(DONT_SHOW_AGAIN_CHECKED) === 'true'; - return dontShowAgain + return !this.props.chromeExtensionUrl + || dontShowAgain || this.state.closePressed || !this.state.shouldShow || this.props.iAmRecorder;