From 961e1d611f17a9c56ee9b795d99648bb6147ad69 Mon Sep 17 00:00:00 2001
From: Bettenbuk Zoltan <zoltan.bettenbuk@gmail.com>
Date: Wed, 11 Jul 2018 11:43:40 +0200
Subject: [PATCH] [RN] Only ask for calendar permission on user interaction

---
 .../react/components/native/AbstractPagedList.js    | 10 ++++++----
 react/features/calendar-sync/actionTypes.js         |  3 ++-
 react/features/calendar-sync/actions.js             | 13 +++++++++----
 .../calendar-sync/components/MeetingList.native.js  |  6 ++++--
 react/features/calendar-sync/middleware.js          |  3 ++-
 5 files changed, 23 insertions(+), 12 deletions(-)

diff --git a/react/features/base/react/components/native/AbstractPagedList.js b/react/features/base/react/components/native/AbstractPagedList.js
index eca687487..c991106e2 100644
--- a/react/features/base/react/components/native/AbstractPagedList.js
+++ b/react/features/base/react/components/native/AbstractPagedList.js
@@ -82,7 +82,7 @@ export default class AbstractPagedList extends Component<Props, State> {
      * @inheritdoc
      */
     componentDidMount() {
-        this._maybeRefreshSelectedPage();
+        this._maybeRefreshSelectedPage(false);
     }
 
     /**
@@ -118,7 +118,7 @@ export default class AbstractPagedList extends Component<Props, State> {
         );
     }
 
-    _maybeRefreshSelectedPage: () => void;
+    _maybeRefreshSelectedPage: ?boolean => void;
 
     /**
      * Components that this PagedList displays may have a refresh function to
@@ -126,9 +126,11 @@ export default class AbstractPagedList extends Component<Props, State> {
      * function invokes this logic if it's present.
      *
      * @private
+     * @param {boolean} isInteractive - If true this refresh was caused by
+     * direct user interaction, false otherwise.
      * @returns {void}
      */
-    _maybeRefreshSelectedPage() {
+    _maybeRefreshSelectedPage(isInteractive: boolean = true) {
         const selectedPage = this.props.pages[this.state.pageIndex];
         let component;
 
@@ -136,7 +138,7 @@ export default class AbstractPagedList extends Component<Props, State> {
             const { refresh } = component;
 
             typeof refresh === 'function'
-                && refresh.call(component, this.props.dispatch);
+                && refresh.call(component, this.props.dispatch, isInteractive);
         }
     }
 
diff --git a/react/features/calendar-sync/actionTypes.js b/react/features/calendar-sync/actionTypes.js
index 1d98fe0de..a458513aa 100644
--- a/react/features/calendar-sync/actionTypes.js
+++ b/react/features/calendar-sync/actionTypes.js
@@ -5,7 +5,8 @@
  *
  * {
  *     type: REFRESH_CALENDAR,
- *     forcePermission: boolean
+ *     forcePermission: boolean,
+ *     isInteractive: boolean
  * }
  */
 export const REFRESH_CALENDAR = Symbol('REFRESH_CALENDAR');
diff --git a/react/features/calendar-sync/actions.js b/react/features/calendar-sync/actions.js
index cdbbc0357..ac0276d15 100644
--- a/react/features/calendar-sync/actions.js
+++ b/react/features/calendar-sync/actions.js
@@ -9,17 +9,22 @@ import {
 /**
  * Sends an action to refresh the entry list (fetches new data).
  *
- * @param {boolean|undefined} forcePermission - Whether to force to re-ask for
+ * @param {boolean} forcePermission - Whether to force to re-ask for
  * the permission or not.
+ * @param {boolean} isInteractive - If true this refresh was caused by
+ * direct user interaction, false otherwise.
  * @returns {{
  *     type: REFRESH_CALENDAR,
- *     forcePermission: boolean
+ *     forcePermission: boolean,
+ *     isInteractive: boolean
  * }}
  */
-export function refreshCalendar(forcePermission: boolean = false) {
+export function refreshCalendar(
+        forcePermission: boolean = false, isInteractive: boolean = true) {
     return {
         type: REFRESH_CALENDAR,
-        forcePermission
+        forcePermission,
+        isInteractive
     };
 }
 
diff --git a/react/features/calendar-sync/components/MeetingList.native.js b/react/features/calendar-sync/components/MeetingList.native.js
index db8913766..fb5ecb7b5 100644
--- a/react/features/calendar-sync/components/MeetingList.native.js
+++ b/react/features/calendar-sync/components/MeetingList.native.js
@@ -65,11 +65,13 @@ class MeetingList extends Component<Props> {
      * change).
      *
      * @param {Function} dispatch - The Redux dispatch function.
+     * @param {boolean} isInteractive - If true this refresh was caused by
+     * direct user interaction, false otherwise.
      * @public
      * @returns {void}
      */
-    static refresh(dispatch) {
-        dispatch(refreshCalendar());
+    static refresh(dispatch, isInteractive) {
+        dispatch(refreshCalendar(false, isInteractive));
     }
 
     /**
diff --git a/react/features/calendar-sync/middleware.js b/react/features/calendar-sync/middleware.js
index bb02c3848..4091a30eb 100644
--- a/react/features/calendar-sync/middleware.js
+++ b/react/features/calendar-sync/middleware.js
@@ -75,7 +75,8 @@ CALENDAR_ENABLED
         case REFRESH_CALENDAR: {
             const result = next(action);
 
-            _fetchCalendarEntries(store, true, action.forcePermission);
+            _fetchCalendarEntries(
+                store, action.isInteractive, action.forcePermission);
 
             return result;
         }