diff --git a/lang/main.json b/lang/main.json index 443639820..d98229c7d 100644 --- a/lang/main.json +++ b/lang/main.json @@ -94,7 +94,8 @@ "unableToUnmutePopup": "You cannot un-mute while the shared video is on.", "cameraDisabled": "Camera is not available", "micDisabled": "Microphone is not available", - "filmstrip": "Show / hide videos" + "filmstrip": "Show / hide videos", + "raiseHand": "Raise hand to speak" }, "bottomtoolbar": { "chat": "Open / close chat", diff --git a/modules/UI/toolbars/Toolbar.js b/modules/UI/toolbars/Toolbar.js index d055f70aa..94f92f6b6 100644 --- a/modules/UI/toolbars/Toolbar.js +++ b/modules/UI/toolbars/Toolbar.js @@ -168,8 +168,13 @@ const buttonHandlers = { }, "toolbar_film_strip": function () { JitsiMeetJS.analytics.sendEvent( - 'bottomtoolbar.filmstrip.toggled'); + 'toolbar.filmstrip.toggled'); emitter.emit(UIEvents.TOGGLE_FILM_STRIP); + }, + "toolbar_button_raisehand": function () { + JitsiMeetJS.analytics.sendEvent( + 'toolbar.raiseHand.clicked'); + APP.conference.maybeToggleRaisedHand(); } }; @@ -288,6 +293,19 @@ const defaultToolbarButtons = { APP.UI.toggleFilmStrip(); }, shortcutDescription: "keyboardShortcuts.toggleFilmstrip" + }, + 'raisehand': { + id: "toolbar_button_raisehand", + className: "button icon-raised-hand", + shortcut: "R", + shortcutAttr: "raiseHandPopover", + shortcutFunc: function() { + JitsiMeetJS.analytics.sendEvent("shortcut.raisehand.clicked"); + APP.conference.maybeToggleRaisedHand(); + }, + shortcutDescription: "keyboardShortcuts.raiseHand", + content: "Raise Hand", + i18n: "[content]toolbar.raiseHand" } }; @@ -679,16 +697,9 @@ const Toolbar = { } ); }, + /** - * TODO: Fix mic popups - * - * - * - * + * Initialise main toolbar buttons. */ _initMainToolbarButtons() { interfaceConfig.MAIN_TOOLBAR_BUTTONS.forEach((value, index) => { diff --git a/modules/keyboardshortcut/keyboardshortcut.js b/modules/keyboardshortcut/keyboardshortcut.js index 7a54b7321..4bb98fb2c 100644 --- a/modules/keyboardshortcut/keyboardshortcut.js +++ b/modules/keyboardshortcut/keyboardshortcut.js @@ -17,11 +17,6 @@ function initGlobalShortcuts() { APP.UI.toggleKeyboardShortcutsPanel(); }, "keyboardShortcuts.toggleShortcuts"); - KeyboardShortcut.registerShortcut("R", null, function() { - JitsiMeetJS.analytics.sendEvent("shortcut.raisedhand.toggled"); - APP.conference.maybeToggleRaisedHand(); - }, "keyboardShortcuts.raiseHand"); - KeyboardShortcut.registerShortcut("T", null, function() { JitsiMeetJS.analytics.sendEvent("shortcut.talk.clicked"); APP.conference.muteAudio(true);