From 9d96276e5d5fe7d660fff4e2e37308a76e753fbf Mon Sep 17 00:00:00 2001 From: George Politis Date: Fri, 16 Sep 2022 14:15:52 +0000 Subject: [PATCH] ref(callstats): Removes redundant config.js option. --- config.js | 2 +- .../base/logging/JitsiMeetLogStorage.ts | 22 +++---------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/config.js b/config.js index a5d749e7c..b54679e39 100644 --- a/config.js +++ b/config.js @@ -824,7 +824,7 @@ var config = { // Application ID and Secret. // callStatsID: '', // callStatsSecret: '', - // callstatsStoreLogs: true, + // callStatsApplicationLogsDisabled: false, // The callstats initialize config params as described in the API: // https://docs.callstats.io/docs/javascript#callstatsinitialize-with-app-secret diff --git a/react/features/base/logging/JitsiMeetLogStorage.ts b/react/features/base/logging/JitsiMeetLogStorage.ts index 348195b8c..56f17df29 100644 --- a/react/features/base/logging/JitsiMeetLogStorage.ts +++ b/react/features/base/logging/JitsiMeetLogStorage.ts @@ -50,22 +50,6 @@ export default class JitsiMeetLogStorage { return Boolean(conference); } - /** - * Checks whether callstats logs storage is enabled. - * - * @returns {boolean} true when this storage can store logs to - * callstats, false otherwise. - */ - canStoreLogsCallstats() { - const { callstatsStoreLogs } = this.getState()['features/base/config']; - - // The behavior prior to adding this configuration parameter, is to send logs to callstats (if callstats is - // enabled). So, in order to maintain backwards compatibility I set the default of this option to be true, i.e. - // if the config.callstatsStoreLogs is not set, the JS console logs will be sent to callstats (if callstats is - // enabled) - return callstatsStoreLogs || callstatsStoreLogs === undefined; - } - /** * Checks whether rtcstats logs storage is enabled. * @@ -92,9 +76,9 @@ export default class JitsiMeetLogStorage { */ storeLogs(logEntries: Array) { - if (this.canStoreLogsCallstats()) { - this.storeLogsCallstats(logEntries); - } + // XXX the config.callStatsApplicationLogsDisabled controls whether or not the logs will be sent to callstats. + // this is done in LJM + this.storeLogsCallstats(logEntries); if (this.canStoreLogsRtcstats()) { RTCStats.sendLogs(logEntries);