From 9e1ac3bea693c104fb97df12e4716fcc03cbfd7d Mon Sep 17 00:00:00 2001
From: Hristo Terezov <hristo@jitsi.org>
Date: Thu, 20 Oct 2022 19:17:10 -0500
Subject: [PATCH] fix(recording): recording link.

Show the start recording notification on jicofo update only. This way
the initiator will be available and we will be able to fetch and display
recording link and send iframe API event.
---
 react/features/recording/middleware.js | 48 +++++++++++++++-----------
 1 file changed, 28 insertions(+), 20 deletions(-)

diff --git a/react/features/recording/middleware.js b/react/features/recording/middleware.js
index 982e663da..381bc822b 100644
--- a/react/features/recording/middleware.js
+++ b/react/features/recording/middleware.js
@@ -222,31 +222,39 @@ MiddlewareRegistry.register(({ dispatch, getState }) => next => async action =>
         } else if (updatedSessionData.status !== PENDING) {
             dispatch(hidePendingRecordingNotification(mode));
 
-            if (updatedSessionData.status === ON
-                && (!oldSessionData || oldSessionData.status !== ON)) {
-                if (typeof recordingLimit === 'object') {
-                    // Show notification with additional information to the initiator.
-                    dispatch(showRecordingLimitNotification(mode));
-                } else {
-                    dispatch(showStartedRecordingNotification(mode, initiator, action.sessionData.id));
+            if (updatedSessionData.status === ON) {
+
+                // We receive 2 updates of the session status ON. The first one is from jibri when it joins.
+                // The second one is from jicofo which will deliever the initiator value. Since the start
+                // recording notification uses the initiator value we skip the jibri update and show the
+                // notification on the update from jicofo.
+                // FIXE: simplify checks when the backend start sending only one status ON update containing the
+                // initiator.
+                if (initiator && (!oldSessionData || !oldSessionData.initiator)) {
+                    if (typeof recordingLimit === 'object') {
+                        dispatch(showRecordingLimitNotification(mode));
+                    } else {
+                        dispatch(showStartedRecordingNotification(mode, initiator, action.sessionData.id));
+                    }
                 }
+                if (!oldSessionData || oldSessionData.status !== ON) {
+                    sendAnalytics(createRecordingEvent('start', mode));
 
-                sendAnalytics(createRecordingEvent('start', mode));
+                    let soundID;
 
-                let soundID;
+                    if (mode === JitsiRecordingConstants.mode.FILE) {
+                        soundID = RECORDING_ON_SOUND_ID;
+                    } else if (mode === JitsiRecordingConstants.mode.STREAM) {
+                        soundID = LIVE_STREAMING_ON_SOUND_ID;
+                    }
 
-                if (mode === JitsiRecordingConstants.mode.FILE) {
-                    soundID = RECORDING_ON_SOUND_ID;
-                } else if (mode === JitsiRecordingConstants.mode.STREAM) {
-                    soundID = LIVE_STREAMING_ON_SOUND_ID;
-                }
+                    if (soundID) {
+                        dispatch(playSound(soundID));
+                    }
 
-                if (soundID) {
-                    dispatch(playSound(soundID));
-                }
-
-                if (typeof APP !== 'undefined') {
-                    APP.API.notifyRecordingStatusChanged(true, mode);
+                    if (typeof APP !== 'undefined') {
+                        APP.API.notifyRecordingStatusChanged(true, mode);
+                    }
                 }
             } else if (updatedSessionData.status === OFF
                 && (!oldSessionData || oldSessionData.status !== OFF)) {