From a39da15c94a0b886837a3ab37aa0a17cd2aae2fa Mon Sep 17 00:00:00 2001 From: virtuacoplenny Date: Thu, 22 Mar 2018 16:22:26 -0700 Subject: [PATCH] ref(invite): remove unused nuclear-js dep (#2642) --- package-lock.json | 13 ------------- package.json | 1 - .../invite/components/AddPeopleDialog.web.js | 9 +-------- react/features/invite/functions.js | 2 +- 4 files changed, 2 insertions(+), 23 deletions(-) diff --git a/package-lock.json b/package-lock.json index 307c85123..f5e0de370 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6785,11 +6785,6 @@ "resolved": "https://registry.npmjs.org/image-size/-/image-size-0.6.2.tgz", "integrity": "sha512-pH3vDzpczdsKHdZ9xxR3O46unSjisgVx0IImay7Zz2EdhRVbCkj+nthx9OuuWEhakx9FAO+fNVGrF0rZ2oMOvw==" }, - "immutable": { - "version": "3.8.2", - "resolved": "https://registry.npmjs.org/immutable/-/immutable-3.8.2.tgz", - "integrity": "sha1-wkOZUUVbs5kT2vKBN28VMOEErfM=" - }, "import-local": { "version": "0.1.1", "resolved": "https://registry.npmjs.org/import-local/-/import-local-0.1.1.tgz", @@ -8644,14 +8639,6 @@ "gauge": "1.2.7" } }, - "nuclear-js": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/nuclear-js/-/nuclear-js-1.4.0.tgz", - "integrity": "sha1-bJwAGwZz8K6dj4sYjE2gTtaTp74=", - "requires": { - "immutable": "3.8.2" - } - }, "num2fraction": { "version": "1.2.2", "resolved": "https://registry.npmjs.org/num2fraction/-/num2fraction-1.2.2.tgz", diff --git a/package.json b/package.json index b16199844..96ae5fa70 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,6 @@ "lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#0503ec4d3f175b154b1c6fd7037520ce0768fa58", "lodash": "4.17.4", "moment": "2.19.4", - "nuclear-js": "1.4.0", "postis": "2.2.0", "prop-types": "15.6.0", "react": "16.2.0", diff --git a/react/features/invite/components/AddPeopleDialog.web.js b/react/features/invite/components/AddPeopleDialog.web.js index 1da468247..554106673 100644 --- a/react/features/invite/components/AddPeopleDialog.web.js +++ b/react/features/invite/components/AddPeopleDialog.web.js @@ -2,7 +2,6 @@ import Avatar from '@atlaskit/avatar'; import InlineMessage from '@atlaskit/inline-message'; -import { Immutable } from 'nuclear-js'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; import { connect } from 'react-redux'; @@ -114,16 +113,10 @@ class AddPeopleDialog extends Component<*, *> { */ addToCallInProgress: false, - - // FIXME: Remove usage of Immutable. {@code MultiSelectAutocomplete} - // will default to having its internal implementation use a plain array - // if no {@link defaultValue} is passed in. As such is the case, this - // instance of Immutable.List gets overridden with an array on the first - // search. /** * The list of invite items. */ - inviteItems: new Immutable.List() + inviteItems: [] }; /** diff --git a/react/features/invite/functions.js b/react/features/invite/functions.js index 89d58a559..cb216399d 100644 --- a/react/features/invite/functions.js +++ b/react/features/invite/functions.js @@ -30,7 +30,7 @@ export function invitePeopleAndChatRooms( // eslint-disable-line max-params inviteServiceUrl: string, inviteUrl: string, jwt: string, - inviteItems: Object): Promise { + inviteItems: Array): Promise { if (!inviteItems || inviteItems.length === 0) { return Promise.resolve(); }