From a6e58c310175b67ffe8617a223e94585e024723b Mon Sep 17 00:00:00 2001 From: Hristo Terezov Date: Fri, 16 Oct 2020 15:59:33 -0500 Subject: [PATCH] fix(thumbnail): cleanup unused hover properties. --- modules/UI/videolayout/RemoteVideo.js | 12 ------------ modules/UI/videolayout/SmallVideo.js | 25 +------------------------ 2 files changed, 1 insertion(+), 36 deletions(-) diff --git a/modules/UI/videolayout/RemoteVideo.js b/modules/UI/videolayout/RemoteVideo.js index f01278293..77b9f04b7 100644 --- a/modules/UI/videolayout/RemoteVideo.js +++ b/modules/UI/videolayout/RemoteVideo.js @@ -86,7 +86,6 @@ export default class RemoteVideo extends SmallVideo { this.bindHoverHandler(); this.flipX = false; this.isLocal = false; - this.popupMenuIsHovered = false; this._isRemoteControlSessionActive = false; /** @@ -137,17 +136,6 @@ export default class RemoteVideo extends SmallVideo { return this.container; } - /** - * Checks whether current video is considered hovered. Currently it is hovered - * if the mouse is over the video, or if the connection indicator or the popup - * menu is shown(hovered). - * @private - * NOTE: extends SmallVideo's method - */ - _isHovered() { - return super._isHovered() || this.popupMenuIsHovered; - } - /** * Generates the popup menu content. * diff --git a/modules/UI/videolayout/SmallVideo.js b/modules/UI/videolayout/SmallVideo.js index 8a4c9ca22..e310dec27 100644 --- a/modules/UI/videolayout/SmallVideo.js +++ b/modules/UI/videolayout/SmallVideo.js @@ -100,15 +100,6 @@ export default class SmallVideo { */ this._connectionStatus = null; - /** - * Whether or not the ConnectionIndicator's popover is hovered. Modifies - * how the video overlays display based on hover state. - * - * @private - * @type {boolean} - */ - this._popoverIsHovered = false; - /** * Whether or not the connection indicator should be displayed. * @@ -134,7 +125,6 @@ export default class SmallVideo { this._showRaisedHand = false; // Bind event handlers so they are only bound once for every instance. - this._onPopoverHover = this._onPopoverHover.bind(this); this.updateView = this.updateView.bind(this); this._onContainerClick = this._onContainerClick.bind(this); @@ -513,7 +503,7 @@ export default class SmallVideo { * @private */ _isHovered() { - return this.videoIsHovered || this._popoverIsHovered; + return this.videoIsHovered; } /** @@ -836,19 +826,6 @@ export default class SmallVideo { } } - /** - * Updates the current state of the connection indicator popover being hovered. - * If hovered, display the small video as if it is hovered. - * - * @param {boolean} popoverIsHovered - Whether or not the mouse cursor is - * currently over the connection indicator popover. - * @returns {void} - */ - _onPopoverHover(popoverIsHovered) { - this._popoverIsHovered = popoverIsHovered; - this.updateView(); - } - /** * Sets the size of the thumbnail. */