From ae8c5287e4237808118fea40ced8c1e814d35c7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Tue, 4 Apr 2017 14:57:06 +0200 Subject: [PATCH] [RN] Remove workaround for video mirroring on iOS It's now natively supported: https://github.com/oney/react-native-webrtc/pull/244 --- .../base/media/components/native/Video.js | 32 ++----------------- .../base/media/components/native/styles.js | 9 ------ 2 files changed, 2 insertions(+), 39 deletions(-) diff --git a/react/features/base/media/components/native/Video.js b/react/features/base/media/components/native/Video.js index 9ac10ff14..7ed4bcdb6 100644 --- a/react/features/base/media/components/native/Video.js +++ b/react/features/base/media/components/native/Video.js @@ -1,20 +1,8 @@ import React, { Component } from 'react'; -import { View } from 'react-native'; import { RTCView } from 'react-native-webrtc'; -import { Platform } from '../../../react'; - import { styles } from './styles'; -/** - * Indicates whether RTCView (is to be considered that it) natively supports - * i.e. implements mirroring the video it renders. If false, a workaround will - * be used in an attempt to support mirroring in Video. If RTCView does not - * implement mirroring on a specific platform but the workaround causes issues, - * set to true for that platform to disable the workaround. - */ -const RTCVIEW_SUPPORTS_MIRROR = Platform.OS === 'android'; - /** * The React Native component which is similar to Web's video element and wraps * around react-native-webrtc's RTCView. @@ -91,31 +79,15 @@ export class Video extends Component { const style = styles.video; const objectFit = (style && style.objectFit) || 'cover'; - const { mirror } = this.props; - - // XXX RTCView may not support support mirroring, even when - // providing a transform style property (e.g. iOS) . As a - // workaround, wrap the RTCView inside another View and apply the - // transform style property to that View instead. - const mirrorWorkaround = mirror && !RTCVIEW_SUPPORTS_MIRROR; - // eslint-disable-next-line no-extra-parens - const video = ( + return ( ); - - if (mirrorWorkaround) { - return ( - { video } - ); - } - - return video; } // RTCView has peculiarities which may or may not be platform specific. diff --git a/react/features/base/media/components/native/styles.js b/react/features/base/media/components/native/styles.js index 17e08c519..b1f13f833 100644 --- a/react/features/base/media/components/native/styles.js +++ b/react/features/base/media/components/native/styles.js @@ -7,18 +7,9 @@ const video = { flex: 1 }; -/** - * Transform local videos to behave like a mirror. - */ -const mirroredVideo = { - ...video, - transform: [ { scaleX: -1 } ] -}; - /** * Native-specific styles for media components. */ export const styles = StyleSheet.create({ - mirroredVideo, video });