From b5489b7c81d65d7939e6e0aa9f18a2fb1aedd2f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Tue, 30 Jul 2019 14:18:42 +0200 Subject: [PATCH] rn,filmstrip: don't unpin participant when hiding filmstrip The filmstrip is currently only hidden when PiP mode is entered. There is no real reason not to leave the large view as it was. --- react/features/filmstrip/middleware.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/react/features/filmstrip/middleware.js b/react/features/filmstrip/middleware.js index 71af8b6aa..a04b718ea 100644 --- a/react/features/filmstrip/middleware.js +++ b/react/features/filmstrip/middleware.js @@ -1,7 +1,6 @@ // @flow import { setLastN } from '../base/conference'; -import { pinParticipant } from '../base/participants'; import { MiddlewareRegistry } from '../base/redux'; import { SET_FILMSTRIP_ENABLED } from './actionTypes'; @@ -33,16 +32,12 @@ MiddlewareRegistry.register(store => next => action => { function _setFilmstripEnabled({ dispatch, getState }, next, action) { const result = next(action); - // FIXME The logic for participant pinning / unpinning is not on React yet - // so dispatching the action is not enough. Hence, perform the following - // only where it will be sufficient i.e. mobile. + // FIXME This action is not currently dispatched on web. if (typeof APP === 'undefined') { const state = getState(); const { enabled } = state['features/filmstrip']; const { audioOnly } = state['features/base/conference']; - enabled || dispatch(pinParticipant(null)); - // FIXME Audio-only mode fiddles with lastN as well. That's why we don't // touch lastN in audio-only mode. But it's not clear what the value of // lastN should be upon exit from audio-only mode if the filmstrip is