From c2539bf61587ba7f7ffbe71adfcc7720cd7f699c Mon Sep 17 00:00:00 2001 From: damencho Date: Thu, 5 Nov 2020 12:00:16 -0600 Subject: [PATCH] feat: Drop buttons tooltips specific to guests. --- lang/main.json | 3 --- .../components/LiveStream/AbstractLiveStreamButton.js | 8 +------- .../components/Recording/AbstractRecordButton.js | 8 +------- react/features/toolbox/components/web/Toolbox.js | 10 +--------- 4 files changed, 3 insertions(+), 26 deletions(-) diff --git a/lang/main.json b/lang/main.json index bc1f95d25..f62cc54a5 100644 --- a/lang/main.json +++ b/lang/main.json @@ -220,7 +220,6 @@ "kickTitle": "Ouch! {{participantDisplayName}} kicked you out of the meeting", "liveStreaming": "Live Streaming", "liveStreamingDisabledBecauseOfActiveRecordingTooltip": "Not possible while recording is active", - "liveStreamingDisabledForGuestTooltip": "Guests can't start live streaming.", "liveStreamingDisabledTooltip": "Start live stream disabled.", "lockMessage": "Failed to lock the conference.", "lockRoom": "Add meeting $t(lockRoomPasswordUppercase)", @@ -255,7 +254,6 @@ "readMore": "more", "recording": "Recording", "recordingDisabledBecauseOfActiveLiveStreamingTooltip": "Not possible while a live stream is active", - "recordingDisabledForGuestTooltip": "Guests can't start recordings.", "recordingDisabledTooltip": "Start recording disabled.", "rejoinNow": "Rejoin now", "remoteControlAllowedMessage": "{{user}} accepted your remote control request!", @@ -287,7 +285,6 @@ "shareVideoTitle": "Share a video", "shareYourScreen": "Share your screen", "shareYourScreenDisabled": "Screen sharing disabled.", - "shareYourScreenDisabledForGuest": "Guests can't screen share.", "startLiveStreaming": "Start live stream", "startRecording": "Start recording", "startRemoteControlErrorMessage": "An error occurred while trying to start the remote control session!", diff --git a/react/features/recording/components/LiveStream/AbstractLiveStreamButton.js b/react/features/recording/components/LiveStream/AbstractLiveStreamButton.js index cd6e22c06..0eb8b3cae 100644 --- a/react/features/recording/components/LiveStream/AbstractLiveStreamButton.js +++ b/react/features/recording/components/LiveStream/AbstractLiveStreamButton.js @@ -144,13 +144,7 @@ export function _mapStateToProps(state: Object, ownProps: Props) { if (!visible && !_disabled) { _disabled = true; visible = true; - - // button and tooltip - if (state['features/base/jwt'].isGuest) { - _tooltip = 'dialog.liveStreamingDisabledForGuestTooltip'; - } else { - _tooltip = 'dialog.liveStreamingDisabledTooltip'; - } + _tooltip = 'dialog.liveStreamingDisabledTooltip'; } } } diff --git a/react/features/recording/components/Recording/AbstractRecordButton.js b/react/features/recording/components/Recording/AbstractRecordButton.js index 7c23f26e8..a77c0ccf3 100644 --- a/react/features/recording/components/Recording/AbstractRecordButton.js +++ b/react/features/recording/components/Recording/AbstractRecordButton.js @@ -153,13 +153,7 @@ export function _mapStateToProps(state: Object, ownProps: Props): Object { if (!visible && !_disabled) { _disabled = true; visible = true; - - // button and tooltip - if (state['features/base/jwt'].isGuest) { - _tooltip = 'dialog.recordingDisabledForGuestTooltip'; - } else { - _tooltip = 'dialog.recordingDisabledTooltip'; - } + _tooltip = 'dialog.recordingDisabledTooltip'; } } } diff --git a/react/features/toolbox/components/web/Toolbox.js b/react/features/toolbox/components/web/Toolbox.js index b6da5063a..86b97f7d8 100644 --- a/react/features/toolbox/components/web/Toolbox.js +++ b/react/features/toolbox/components/web/Toolbox.js @@ -1426,15 +1426,7 @@ function _mapStateToProps(state) { desktopSharingEnabled = getParticipants(state) .find(({ features = {} }) => String(features['screen-sharing']) === 'true') !== undefined; - - // we want to show button and tooltip - if (state['features/base/jwt'].isGuest) { - desktopSharingDisabledTooltipKey - = 'dialog.shareYourScreenDisabledForGuest'; - } else { - desktopSharingDisabledTooltipKey - = 'dialog.shareYourScreenDisabled'; - } + desktopSharingDisabledTooltipKey = 'dialog.shareYourScreenDisabled'; } // NB: We compute the buttons again here because if URL parameters were used to