ref(TS) Remove unnecessary ts-ignores (#12136)

react/features/base/audio-only/actions.ts

@@ -3,8 +3,8 @@ import type { Dispatch } from 'redux';
 
 // @ts-ignore
 import UIEvents from '../../../../service/UI/UIEvents';
-// @ts-ignore
+import { createAudioOnlyChangedEvent } from '../../analytics/AnalyticsEvents';
-import { createAudioOnlyChangedEvent, sendAnalytics } from '../../analytics';
+import { sendAnalytics } from '../../analytics/functions';
 
 import { SET_AUDIO_ONLY } from './actionTypes';
 import logger from './logger';

react/features/conference/components/native/carmode/EndMeetingButton.tsx

@@ -2,8 +2,8 @@
 import React, { useCallback } from 'react';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../../../analytics';
+import { sendAnalytics } from '../../../../analytics/functions';
 // @ts-ignore
 import { appNavigate } from '../../../../app/actions';
 import Button from '../../../../base/ui/components/native/Button';

react/features/conference/components/native/carmode/MicrophoneButton.tsx

@@ -5,11 +5,10 @@ import { useDispatch, useSelector } from 'react-redux';
 
 import {
     createShortcutEvent,
-    sendAnalytics,
     ACTION_SHORTCUT_PRESSED as PRESSED,
     ACTION_SHORTCUT_RELEASED as RELEASED
-    // @ts-ignore
+} from '../../../../analytics/AnalyticsEvents';
-} from '../../../../analytics';
+import { sendAnalytics } from '../../../../analytics/functions';
 import { IState } from '../../../../app/types';
 // @ts-ignore
 import { getFeatureFlag, AUDIO_MUTE_BUTTON_ENABLED } from '../../../../base/flags';

react/features/e2ee/components/E2EESection.tsx

@@ -3,8 +3,8 @@ import React, { Component } from 'react';
 import { WithTranslation } from 'react-i18next';
 import type { Dispatch } from 'redux';
 
-// @ts-ignore
+import { createE2EEEvent } from '../../analytics/AnalyticsEvents';
-import { createE2EEEvent, sendAnalytics } from '../../analytics';
+import { sendAnalytics } from '../../analytics/functions';
 import { IState } from '../../app/types';
 import { translate } from '../../base/i18n/functions';
 import { connect } from '../../base/redux/functions';

react/features/filmstrip/components/web/Filmstrip.tsx

@@ -7,12 +7,8 @@ import { WithTranslation } from 'react-i18next';
 import { FixedSizeList, FixedSizeGrid } from 'react-window';
 import type { Dispatch } from 'redux';
 
-import {
+import { ACTION_SHORTCUT_TRIGGERED, createShortcutEvent, createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-    createShortcutEvent,
+import { sendAnalytics } from '../../../analytics/functions';
-    createToolbarEvent,
-    sendAnalytics
-    // @ts-ignore
-} from '../../../analytics';
 import { IState } from '../../../app/types';
 // @ts-ignore
 import { getSourceNameSignalingFeatureFlag, getToolbarButtons } from '../../../base/config';
@@ -797,6 +793,7 @@ class Filmstrip extends PureComponent <Props, State> {
     _onShortcutToggleFilmstrip() {
         sendAnalytics(createShortcutEvent(
             'toggle.filmstrip',
+            ACTION_SHORTCUT_TRIGGERED,
             {
                 enable: this.props._mainFilmstripVisible
             }));

react/features/filmstrip/components/web/Thumbnail.tsx

@@ -4,8 +4,8 @@ import clsx from 'clsx';
 import debounce from 'lodash/debounce';
 import React, { Component } from 'react';
 
-// @ts-ignore
+import { createScreenSharingIssueEvent } from '../../../analytics/AnalyticsEvents';
-import { createScreenSharingIssueEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 import { IState } from '../../../app/types';
 // @ts-ignore
 import { Avatar } from '../../../base/avatar';

react/features/gifs/components/web/GifsMenu.tsx

@@ -7,8 +7,8 @@ import React, { useCallback, useEffect, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { batch, useDispatch, useSelector } from 'react-redux';
 
-// @ts-ignore
+import { createGifSentEvent } from '../../../analytics/AnalyticsEvents';
-import { createGifSentEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 import { IState } from '../../../app/types';
 // @ts-ignore
 import InputField from '../../../base/premeeting/components/web/InputField';

react/features/participants-pane/components/breakout-rooms/components/native/LeaveBreakoutRoomButton.tsx

@@ -2,8 +2,8 @@
 import React, { useCallback } from 'react';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createBreakoutRoomsEvent } from '../../../../../analytics/AnalyticsEvents';
-import { createBreakoutRoomsEvent, sendAnalytics } from '../../../../../analytics';
+import { sendAnalytics } from '../../../../../analytics/functions';
 import Button from '../../../../../base/ui/components/native/Button';
 import { BUTTON_TYPES } from '../../../../../base/ui/constants';
 // @ts-ignore

react/features/participants-pane/components/breakout-rooms/components/web/JoinQuickActionButton.tsx

@@ -4,8 +4,8 @@ import React, { useCallback } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createBreakoutRoomsEvent } from '../../../../../analytics/AnalyticsEvents';
-import { createBreakoutRoomsEvent, sendAnalytics } from '../../../../../analytics';
+import { sendAnalytics } from '../../../../../analytics/functions';
 import Button from '../../../../../base/ui/components/web/Button';
 import { Theme } from '../../../../../base/ui/types';
 // @ts-ignore

react/features/participants-pane/components/breakout-rooms/components/web/LeaveButton.tsx

@@ -3,8 +3,8 @@ import React, { useCallback } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createBreakoutRoomsEvent } from '../../../../../analytics/AnalyticsEvents';
-import { createBreakoutRoomsEvent, sendAnalytics } from '../../../../../analytics';
+import { sendAnalytics } from '../../../../../analytics/functions';
 import Button from '../../../../../base/ui/components/web/Button';
 import { BUTTON_TYPES } from '../../../../../base/ui/constants';
 // @ts-ignore

react/features/participants-pane/components/web/InviteButton.tsx

@@ -3,8 +3,8 @@ import React, { useCallback } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 import { IconInviteMore } from '../../../base/icons/svg';
 import Button from '../../../base/ui/components/web/Button';
 import { BUTTON_TYPES } from '../../../base/ui/constants';

react/features/polls/components/AbstractPollAnswer.tsx

@@ -3,8 +3,8 @@ import React, { ComponentType, useCallback, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch, useSelector } from 'react-redux';
 
-// @ts-ignore
+import { createPollEvent } from '../../analytics/AnalyticsEvents';
-import { sendAnalytics, createPollEvent } from '../../analytics';
+import { sendAnalytics } from '../../analytics/functions';
 import { IState } from '../../app/types';
 import { getLocalParticipant, getParticipantById } from '../../base/participants/functions';
 import { useBoundSelector } from '../../base/util/hooks';

react/features/reactions/components/web/ReactionsMenu.tsx

@@ -5,12 +5,8 @@ import React, { Component } from 'react';
 import { WithTranslation } from 'react-i18next';
 import { bindActionCreators } from 'redux';
 
-import {
+import { createReactionMenuEvent, createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-    createReactionMenuEvent,
+import { sendAnalytics } from '../../../analytics/functions';
-    createToolbarEvent,
-    sendAnalytics
-    // @ts-ignore
-} from '../../../analytics';
 import { IState, IStore } from '../../../app/types';
 import { isMobileBrowser } from '../../../base/environment/utils';
 import { translate } from '../../../base/i18n/functions';

react/features/reactions/middleware.ts

@@ -1,8 +1,8 @@
 /* eslint-disable lines-around-comment */
 import { batch } from 'react-redux';
 
-// @ts-ignore
+import { createReactionSoundsDisabledEvent } from '../analytics/AnalyticsEvents';
-import { createReactionSoundsDisabledEvent, sendAnalytics } from '../analytics';
+import { sendAnalytics } from '../analytics/functions';
 import { IStore } from '../app/types';
 import { APP_WILL_MOUNT, APP_WILL_UNMOUNT } from '../base/app/actionTypes';
 import {

react/features/recording/components/Recording/AbstractStartRecordingDialogContent.tsx

@@ -2,11 +2,8 @@
 import { Component } from 'react';
 import { WithTranslation } from 'react-i18next';
 
-import {
+import { createRecordingDialogEvent } from '../../../analytics/AnalyticsEvents';
-    createRecordingDialogEvent,
+import { sendAnalytics } from '../../../analytics/functions';
-    sendAnalytics
-    // @ts-ignore
-} from '../../../analytics';
 import { IState } from '../../../app/types';
 // @ts-ignore
 import { ColorSchemeRegistry } from '../../../base/color-scheme';

react/features/rtcstats/RTCStats.ts

@@ -5,8 +5,8 @@ import rtcstatsInit from '@jitsi/rtcstats/rtcstats';
 // @ts-ignore
 import traceInit from '@jitsi/rtcstats/trace-ws';
 
-// @ts-ignore
+import { createRTCStatsTraceCloseEvent } from '../analytics/AnalyticsEvents';
-import { createRTCStatsTraceCloseEvent, sendAnalytics } from '../analytics';
+import { sendAnalytics } from '../analytics/functions';
 
 import logger from './logger';
 import {

react/features/rtcstats/functions.ts

@@ -2,8 +2,7 @@
 // @ts-ignore
 import { jitsiLocalStorage } from '@jitsi/js-utils';
 
-// @ts-ignore
+import { getAmplitudeIdentity } from '../analytics/functions';
-import { getAmplitudeIdentity } from '../analytics';
 import {
     getConferenceOptions,
     getAnalyticsRoomName

react/features/settings/components/web/ProfileTab.tsx

@@ -4,11 +4,8 @@ import { WithTranslation } from 'react-i18next';
 
 // @ts-ignore
 import UIEvents from '../../../../../service/UI/UIEvents';
-import {
+import { createProfilePanelButtonEvent } from '../../../analytics/AnalyticsEvents';
-    sendAnalytics,
+import { sendAnalytics } from '../../../analytics/functions';
-    createProfilePanelButtonEvent
-    // @ts-ignore
-} from '../../../analytics';
 // @ts-ignore
 import { AbstractDialogTab } from '../../../base/dialog';
 // @ts-ignore

react/features/toolbox/components/native/HangupMenu.tsx

@@ -3,8 +3,8 @@ import React, { useCallback } from 'react';
 import { View } from 'react-native';
 import { useDispatch, useSelector } from 'react-redux';
 
-// @ts-ignore
+import { createBreakoutRoomsEvent, createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-import { createBreakoutRoomsEvent, createToolbarEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 // @ts-ignore
 import { appNavigate } from '../../../app/actions';
 // @ts-ignore

react/features/toolbox/components/web/HangupMenuButton.tsx

@@ -3,8 +3,8 @@ import InlineDialog from '@atlaskit/inline-dialog';
 import React, { Component } from 'react';
 import { WithTranslation } from 'react-i18next';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 import { translate } from '../../../base/i18n/functions';
 
 import HangupToggleButton from './HangupToggleButton';

react/features/toolbox/components/web/LeaveConferenceButton.tsx

@@ -3,8 +3,8 @@ import React, { useCallback } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch } from 'react-redux';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 // @ts-ignore
 import { leaveConference } from '../../../base/conference/actions';
 import Button from '../../../base/ui/components/web/Button';

react/features/toolbox/components/web/OverflowMenuButton.tsx

@@ -4,8 +4,8 @@ import { withStyles } from '@material-ui/styles';
 import React, { Component, ReactElement } from 'react';
 import { WithTranslation } from 'react-i18next';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../../analytics';
+import { sendAnalytics } from '../../../analytics/functions';
 import { IState } from '../../../app/types';
 import { translate } from '../../../base/i18n/functions';
 import { connect } from '../../../base/redux/functions';

react/features/toolbox/components/web/Toolbox.tsx

@@ -6,13 +6,8 @@ import { batch } from 'react-redux';
 
 // @ts-ignore
 import keyboardShortcut from '../../../../../modules/keyboardshortcut/keyboardshortcut';
-import {
+import { ACTION_SHORTCUT_TRIGGERED, createShortcutEvent, createToolbarEvent } from '../../../analytics/AnalyticsEvents';
-    ACTION_SHORTCUT_TRIGGERED,
+import { sendAnalytics } from '../../../analytics/functions';
-    createShortcutEvent,
-    createToolbarEvent,
-    sendAnalytics
-    // @ts-ignore
-} from '../../../analytics';
 import { IState } from '../../../app/types';
 import ContextMenu from '../../../base/components/context-menu/ContextMenu';
 import ContextMenuItemGroup from '../../../base/components/context-menu/ContextMenuItemGroup';
@@ -1092,6 +1087,7 @@ class Toolbox extends Component<Props> {
     _onShortcutToggleChat() {
         sendAnalytics(createShortcutEvent(
             'toggle.chat',
+            ACTION_SHORTCUT_TRIGGERED,
             {
                 enable: !this.props._chatOpen
             }));
@@ -1116,6 +1112,7 @@ class Toolbox extends Component<Props> {
     _onShortcutToggleParticipantsPane() {
         sendAnalytics(createShortcutEvent(
             'toggle.participants-pane',
+            ACTION_SHORTCUT_TRIGGERED,
             {
                 enable: !this.props._participantsPaneOpen
             }));
@@ -1145,6 +1142,7 @@ class Toolbox extends Component<Props> {
     _onShortcutToggleTileView() {
         sendAnalytics(createShortcutEvent(
             'toggle.tileview',
+            ACTION_SHORTCUT_TRIGGERED,
             {
                 enable: !this.props._tileViewEnabled
             }));
@@ -1162,6 +1160,7 @@ class Toolbox extends Component<Props> {
     _onShortcutToggleFullScreen() {
         sendAnalytics(createShortcutEvent(
             'toggle.fullscreen',
+            ACTION_SHORTCUT_TRIGGERED,
             {
                 enable: !this.props._fullScreen
             }));
@@ -1307,7 +1306,6 @@ class Toolbox extends Component<Props> {
     _onToolbarToggleScreenshare() {
         sendAnalytics(createToolbarEvent(
             'toggle.screen.sharing',
-            ACTION_SHORTCUT_TRIGGERED,
             { enable: !this.props._screenSharing }));
 
         this._closeOverflowMenuIfOpen();

react/features/video-quality/components/VideoQualitySlider.web.tsx

@@ -5,8 +5,8 @@ import React, { Component } from 'react';
 import { WithTranslation } from 'react-i18next';
 import type { Dispatch } from 'redux';
 
-// @ts-ignore
+import { createToolbarEvent } from '../../analytics/AnalyticsEvents';
-import { createToolbarEvent, sendAnalytics } from '../../analytics';
+import { sendAnalytics } from '../../analytics/functions';
 import { IState } from '../../app/types';
 // @ts-ignore
 import { setAudioOnly } from '../../base/audio-only';