From d66f23ca4a352da5e6d033dd21ae4720bff2130c Mon Sep 17 00:00:00 2001 From: Jaya Allamsetty Date: Wed, 29 Sep 2021 13:28:29 -0400 Subject: [PATCH] fix(logging) Remove logs that are very chatty. The receiver video constraints that are actually sent to the bridge are logged in LJM and need not be logged in the application. --- react/features/base/lastn/middleware.js | 1 - react/features/filmstrip/components/web/Thumbnail.js | 5 ----- react/features/video-quality/subscriber.js | 1 - 3 files changed, 7 deletions(-) diff --git a/react/features/base/lastn/middleware.js b/react/features/base/lastn/middleware.js index ba63cb301..a30848d90 100644 --- a/react/features/base/lastn/middleware.js +++ b/react/features/base/lastn/middleware.js @@ -82,7 +82,6 @@ const _updateLastN = debounce(({ dispatch, getState }) => { lastNSelected = 1; } - logger.info(`Setting last N to: ${lastNSelected}`); dispatch(setLastN(lastNSelected)); }, 1000); /* Don't send this more often than once a second. */ diff --git a/react/features/filmstrip/components/web/Thumbnail.js b/react/features/filmstrip/components/web/Thumbnail.js index 4f4794610..c8daed0c7 100644 --- a/react/features/filmstrip/components/web/Thumbnail.js +++ b/react/features/filmstrip/components/web/Thumbnail.js @@ -31,14 +31,12 @@ import { LocalVideoMenuTriggerButton, RemoteVideoMenuTriggerButton } from '../.. import { setVolume } from '../../actions.web'; import { DISPLAY_MODE_TO_CLASS_NAME, - DISPLAY_MODE_TO_STRING, DISPLAY_VIDEO, DISPLAY_VIDEO_WITH_NAME, VIDEO_TEST_EVENTS, SHOW_TOOLBAR_CONTEXT_MENU_AFTER } from '../../constants'; import { isVideoPlayable, computeDisplayMode } from '../../functions'; -import logger from '../../logger'; const JitsiTrackEvents = JitsiMeetJS.events.track; @@ -333,11 +331,8 @@ class Thumbnail extends Component { */ _onDisplayModeChanged() { const input = Thumbnail.getDisplayModeInput(this.props, this.state); - const displayModeString = DISPLAY_MODE_TO_STRING[this.state.displayMode]; - const id = this.props._participant?.id; this._maybeSendScreenSharingIssueEvents(input); - logger.debug(`Displaying ${displayModeString} for ${id}, data: [${JSON.stringify(input)}]`); } /** diff --git a/react/features/video-quality/subscriber.js b/react/features/video-quality/subscriber.js index 5143949fb..c8499d575 100644 --- a/react/features/video-quality/subscriber.js +++ b/react/features/video-quality/subscriber.js @@ -229,7 +229,6 @@ function _updateReceiverVideoConstraints({ getState }) { } } - logger.info(`Setting receiver video constraints to ${JSON.stringify(receiverConstraints)}`); try { conference.setReceiverConstraints(receiverConstraints); } catch (error) {