diff --git a/modules/RTC/DataChannels.js b/modules/RTC/DataChannels.js index a97efc03c..11ccdefbc 100644 --- a/modules/RTC/DataChannels.js +++ b/modules/RTC/DataChannels.js @@ -167,14 +167,13 @@ DataChannels.prototype.handleSelectedEndpointEvent = function (userResource) { DataChannels.prototype.handlePinnedEndpointEvent = function (userResource) { logger.log('pinned endpoint changed: ', userResource); - if (this._dataChannels && this._dataChannels.length != 0) { + if (this._dataChannels && this._dataChannels.length !== 0) { this._dataChannels.some(function (dataChannel) { if (dataChannel.readyState == 'open') { dataChannel.send(JSON.stringify({ 'colibriClass': 'PinnedEndpointChangedEvent', 'pinnedEndpoint': - (!userResource || userResource == null)? - null : userResource + userResource ? userResource : null })); return true; diff --git a/modules/RTC/RTCUtils.js b/modules/RTC/RTCUtils.js index e6c6672ef..f47ff68e4 100644 --- a/modules/RTC/RTCUtils.js +++ b/modules/RTC/RTCUtils.js @@ -33,9 +33,10 @@ function getPreviousResolution(resolution) { var order = Resolutions[resolution].order; var res = null; var resName = null; - for(var i in Resolutions) { - var tmp = Resolutions[i]; - if(res == null || (res.order < tmp.order && tmp.order < order)) { + var tmp, i; + for(i in Resolutions) { + tmp = Resolutions[i]; + if (!res || (res.order < tmp.order && tmp.order < order)) { resName = i; res = tmp; } @@ -678,7 +679,7 @@ var RTCUtils = { error.name == "OverconstrainedError") && (error.constraintName == "minWidth" || error.constraintName == "maxWidth" || error.constraintName == "minHeight" || error.constraintName == "maxHeight") - && resolution != null) { + && resolution) { self.getUserMediaWithConstraints(['audio', 'video'], function (stream) { var streams = self.successCallback(stream, resolution); diff --git a/modules/connectionquality/connectionquality.js b/modules/connectionquality/connectionquality.js index e1832a531..c1ddb14b8 100644 --- a/modules/connectionquality/connectionquality.js +++ b/modules/connectionquality/connectionquality.js @@ -108,7 +108,7 @@ var ConnectionQuality = { updateLocalStats: function (data) { stats = data; eventEmitter.emit(CQEvents.LOCALSTATS_UPDATED, 100 - stats.packetLoss.total, stats); - if (sendIntervalId == null) { + if (!sendIntervalId) { startSendingStats(); } }, @@ -119,7 +119,7 @@ var ConnectionQuality = { * @param data the statistics */ updateRemoteStats: function (jid, data) { - if (data == null || data.packetLoss_total == null) { + if (!data || !data.packetLoss_total) { eventEmitter.emit(CQEvents.REMOTESTATS_UPDATED, jid, null, null); return; } diff --git a/modules/xmpp/JingleSessionPC.js b/modules/xmpp/JingleSessionPC.js index 2c20d10d9..c5e18ae15 100644 --- a/modules/xmpp/JingleSessionPC.js +++ b/modules/xmpp/JingleSessionPC.js @@ -843,7 +843,7 @@ JingleSessionPC.prototype.addSource = function (elem, fromJid) { return this.getAttribute('ssrc'); }).get(); - if (ssrcs.length != 0) { + if (ssrcs.length) { lines += 'a=ssrc-group:' + semantics + ' ' + ssrcs.join(' ') + '\r\n'; } }); @@ -922,7 +922,7 @@ JingleSessionPC.prototype.removeSource = function (elem, fromJid) { return this.getAttribute('ssrc'); }).get(); - if (ssrcs.length != 0) { + if (ssrcs.length) { lines += 'a=ssrc-group:' + semantics + ' ' + ssrcs.join(' ') + '\r\n'; } }); @@ -1367,7 +1367,7 @@ JingleSessionPC.prototype.setLocalDescription = function () { var session = transform.parse(this.peerconnection.localDescription.sdp); session.media.forEach(function (media) { - if (media.ssrcs != null && media.ssrcs.length > 0) { + if (media.ssrcs && media.ssrcs.length > 0) { // TODO(gp) maybe exclude FID streams? media.ssrcs.forEach(function (ssrc) { if (ssrc.attribute !== 'cname') { diff --git a/modules/xmpp/SDP.js b/modules/xmpp/SDP.js index da68346b1..e5e70f052 100644 --- a/modules/xmpp/SDP.js +++ b/modules/xmpp/SDP.js @@ -47,7 +47,7 @@ SDP.prototype.getMediaSsrcMap = function() { tmp.forEach(function(line){ var semantics = line.substr(0, idx).substr(13); var ssrcs = line.substr(14 + semantics.length).split(' '); - if (ssrcs.length != 0) { + if (ssrcs.length) { media.ssrcGroups.push({ semantics: semantics, ssrcs: ssrcs @@ -268,7 +268,7 @@ SDP.prototype.toJingle = function (elem, thecreator, ssrcs) { idx = line.indexOf(' '); var semantics = line.substr(0, idx).substr(13); var ssrcs = line.substr(14 + semantics.length).split(' '); - if (ssrcs.length != 0) { + if (ssrcs.length) { elem.c('ssrc-group', { semantics: semantics, xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' }); ssrcs.forEach(function(ssrc) { elem.c('source', { ssrc: ssrc }) @@ -599,7 +599,7 @@ SDP.prototype.jingle2media = function (content) { return this.getAttribute('ssrc'); }).get(); - if (ssrcs.length != 0) { + if (ssrcs.length) { media += 'a=ssrc-group:' + semantics + ' ' + ssrcs.join(' ') + '\r\n'; } }); diff --git a/modules/xmpp/SDPDiffer.js b/modules/xmpp/SDPDiffer.js index ff4341e39..38d52150a 100644 --- a/modules/xmpp/SDPDiffer.js +++ b/modules/xmpp/SDPDiffer.js @@ -143,7 +143,7 @@ SDPDiffer.prototype.toJingle = function(modify) { // generate source groups from lines media.ssrcGroups.forEach(function(ssrcGroup) { - if (ssrcGroup.ssrcs.length != 0) { + if (ssrcGroup.ssrcs.length) { modify.c('ssrc-group', { semantics: ssrcGroup.semantics, diff --git a/modules/xmpp/TraceablePeerConnection.js b/modules/xmpp/TraceablePeerConnection.js index 9b579d19f..171d1a975 100644 --- a/modules/xmpp/TraceablePeerConnection.js +++ b/modules/xmpp/TraceablePeerConnection.js @@ -182,7 +182,7 @@ var normalizePlanB = function(desc) { for (i = 0; i