From ecfc05bcc8c61e52f2d858c8e8f68ad0f171661d Mon Sep 17 00:00:00 2001 From: paweldomas Date: Thu, 22 Sep 2016 10:38:05 -0500 Subject: [PATCH] fix(LargeVideoManager): enable video problems filter on VideoContainer Only the VideoContainer is interested in showing the video problems filter which is meant to be displayed when ICE is disconnected. --- modules/UI/shared_video/SharedVideo.js | 4 ---- modules/UI/videolayout/LargeVideoManager.js | 3 +-- modules/UI/videolayout/VideoContainer.js | 11 +++++++++++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/modules/UI/shared_video/SharedVideo.js b/modules/UI/shared_video/SharedVideo.js index f873de0a5..92e153190 100644 --- a/modules/UI/shared_video/SharedVideo.js +++ b/modules/UI/shared_video/SharedVideo.js @@ -567,10 +567,6 @@ class SharedVideoContainer extends LargeContainer { this.player = player; } - get $video () { - return this.$iframe; - } - show () { let self = this; return new Promise(resolve => { diff --git a/modules/UI/videolayout/LargeVideoManager.js b/modules/UI/videolayout/LargeVideoManager.js index 8c145e77e..54bc097ef 100644 --- a/modules/UI/videolayout/LargeVideoManager.js +++ b/modules/UI/videolayout/LargeVideoManager.js @@ -213,8 +213,7 @@ export default class LargeVideoManager { * @param enable true to enable, false to disable */ enableVideoProblemFilter (enable) { - let container = this.getContainer(this.state); - container.$video.toggleClass("videoProblemFilter", enable); + this.videoContainer.enableVideoProblemFilter(enable); } /** diff --git a/modules/UI/videolayout/VideoContainer.js b/modules/UI/videolayout/VideoContainer.js index 99cef5e70..2043344c2 100644 --- a/modules/UI/videolayout/VideoContainer.js +++ b/modules/UI/videolayout/VideoContainer.js @@ -184,6 +184,17 @@ export class VideoContainer extends LargeContainer { this.$video[0].onplay = onPlay; } + /** + * Enables a filter on the video which indicates that there are some + * problems with the media connection. + * + * @param {boolean} enable true if the filter is to be enabled or + * false otherwise. + */ + enableVideoProblemFilter (enable) { + this.$video.toggleClass("videoProblemFilter", enable); + } + /** * Get size of video element. * @returns {{width, height}}