From eec2c487fdcec791ed5cb514e68becb045e0df84 Mon Sep 17 00:00:00 2001 From: yanas Date: Wed, 27 Aug 2014 09:20:05 +0200 Subject: [PATCH] Fixes setting of default display name in remote videos. --- app.js | 9 ++------- index.html | 3 +-- videolayout.js | 9 +++++++-- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/app.js b/app.js index 136deb99d..fa1e0c10d 100644 --- a/app.js +++ b/app.js @@ -594,14 +594,9 @@ $(document).bind('joined.muc', function (event, jid, info) { // Once we've joined the muc show the toolbar Toolbar.showToolbar(); - var displayName = ''; if (info.displayName) - displayName = info.displayName + ' (me)'; - else - displayName = "Me"; - - $(document).trigger('displaynamechanged', - ['localVideoContainer', displayName]); + $(document).trigger('displaynamechanged', + ['localVideoContainer', info.displayName + ' (me)']); }); $(document).bind('entered.muc', function (event, jid, info, pres) { diff --git a/index.html b/index.html index a09a4ff66..3a5f2ff5e 100644 --- a/index.html +++ b/index.html @@ -58,7 +58,7 @@ - + @@ -277,6 +277,5 @@ - diff --git a/videolayout.js b/videolayout.js index 069565cc1..fa28ed927 100644 --- a/videolayout.js +++ b/videolayout.js @@ -28,6 +28,9 @@ var VideoLayout = (function (my) { var localVideoContainer = document.getElementById('localVideoWrapper'); localVideoContainer.appendChild(localVideo); + // Set default display name. + setDisplayName('localVideoContainer'); + AudioLevels.updateAudioLevelCanvas(); var localVideoSelector = $('#' + localVideo.id); @@ -103,7 +106,6 @@ var VideoLayout = (function (my) { } }; - /** * Updates the large video with the given new video source. */ @@ -306,6 +308,9 @@ var VideoLayout = (function (my) { var container = VideoLayout.addRemoteVideoContainer(peerJid, videoSpanId); + // Set default display name. + setDisplayName(videoSpanId); + var nickfield = document.createElement('span'); nickfield.className = "nick"; nickfield.appendChild(document.createTextNode(resourceJid)); @@ -541,7 +546,7 @@ var VideoLayout = (function (my) { editableText.className = 'displayname'; editableText.id = 'editDisplayName'; - if (displayName.length) { + if (displayName && displayName.length) { editableText.value = displayName.substring(0, displayName.indexOf(' (me)')); }