From f702f828e3127f7ac76832ed7f46fb5f34f91853 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Sun, 22 Sep 2019 15:26:57 +0200 Subject: [PATCH] android: fix NPE when handling onHostPause If the Activity is put into the background before the ReactContext is created we get an NPE here. While the window might be short, it's thechnically possible to hit this, as our Crashlytics reports show. --- .../main/java/org/jitsi/meet/sdk/JitsiMeetActivityDelegate.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetActivityDelegate.java b/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetActivityDelegate.java index a0aa2b5af..d6377f688 100644 --- a/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetActivityDelegate.java +++ b/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetActivityDelegate.java @@ -122,7 +122,7 @@ public class JitsiMeetActivityDelegate { // https://github.com/facebook/react-native/blob/df4e67fe75d781d1eb264128cadf079989542755/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L512 // Why this happens is a mystery wrapped in an enigma. ReactContext reactContext = reactInstanceManager.getCurrentReactContext(); - if (activity == reactContext.getCurrentActivity()) { + if (reactContext != null && activity == reactContext.getCurrentActivity()) { reactInstanceManager.onHostPause(activity); } }