From b0c81985d44cbda227ed1df898fdfddc38c6947b Mon Sep 17 00:00:00 2001 From: Boris Grozev Date: Wed, 22 Jul 2015 16:37:15 -0500 Subject: [PATCH] Removes the useBundle and useRtcpMux options from config.js. These are now fully supported by jitsi-videobridge and all browsers which we support (and if we need to enable them conditionally because of browser compatibility in the future, we should do it based on run-time browser detection.) --- config.js | 2 -- modules/RTC/RTCUtils.js | 6 ++---- modules/statistics/CallStats.js | 4 +--- modules/xmpp/strophe.jingle.js | 12 +++++------- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/config.js b/config.js index ff1749044..8c8637ebc 100644 --- a/config.js +++ b/config.js @@ -26,8 +26,6 @@ var config = { channelLastN: -1, // The default value of the channel attribute last-n. adaptiveLastN: false, adaptiveSimulcast: false, - useRtcpMux: true, // required for FF support - useBundle: true, // required for FF support enableRecording: false, enableWelcomePage: true, enableSimulcast: false, // blocks FF support diff --git a/modules/RTC/RTCUtils.js b/modules/RTC/RTCUtils.js index b182fe7c1..a7d14feb9 100644 --- a/modules/RTC/RTCUtils.js +++ b/modules/RTC/RTCUtils.js @@ -146,7 +146,7 @@ function RTCUtils(RTCService, onTemasysPluginReady) this.service = RTCService; if (RTCBrowserType.isFirefox()) { var FFversion = RTCBrowserType.getFirefoxVersion(); - if (FFversion >= 40 && config.useBundle && config.useRtcpMux) { + if (FFversion >= 40) { this.peerconnection = mozRTCPeerConnection; this.getUserMedia = navigator.mozGetUserMedia.bind(navigator); this.pc_constraints = {}; @@ -188,9 +188,7 @@ function RTCUtils(RTCService, onTemasysPluginReady) RTCIceCandidate = mozRTCIceCandidate; } else { console.error( - "Firefox requirements not met, ver: " + FFversion + - ", bundle: " + config.useBundle + - ", rtcp-mux: " + config.useRtcpMux); + "Firefox version too old: " + FFversion + ". Required >= 40."); window.location.href = 'unsupported_browser.html'; return; } diff --git a/modules/statistics/CallStats.js b/modules/statistics/CallStats.js index 7692c2345..b2413301f 100644 --- a/modules/statistics/CallStats.js +++ b/modules/statistics/CallStats.js @@ -27,9 +27,7 @@ var CallStats = { this.userID, initCallback); - var usage = callStats.fabricUsage.unbundled; - if(config.useBundle) - usage = callStats.fabricUsage.multiplex; + var usage = callStats.fabricUsage.multiplex; callStats.addNewFabric(this.peerconnection, Strophe.getResourceFromJid(jingleSession.peerjid), diff --git a/modules/xmpp/strophe.jingle.js b/modules/xmpp/strophe.jingle.js index 662f0faa8..57d50462b 100644 --- a/modules/xmpp/strophe.jingle.js +++ b/modules/xmpp/strophe.jingle.js @@ -55,15 +55,13 @@ module.exports = function(XMPP, eventEmitter) this.connection.disco.addFeature('urn:ietf:rfc:4588'); } - // this is dealt with by SDP O/A so we don't need to annouce this + // this is dealt with by SDP O/A so we don't need to announce this //this.connection.disco.addFeature('urn:xmpp:jingle:apps:rtp:rtcp-fb:0'); // XEP-0293 //this.connection.disco.addFeature('urn:xmpp:jingle:apps:rtp:rtp-hdrext:0'); // XEP-0294 - if (config.useRtcpMux) { - this.connection.disco.addFeature('urn:ietf:rfc:5761'); // rtcp-mux - } - if (config.useBundle) { - this.connection.disco.addFeature('urn:ietf:rfc:5888'); // a=group, e.g. bundle - } + + this.connection.disco.addFeature('urn:ietf:rfc:5761'); // rtcp-mux + this.connection.disco.addFeature('urn:ietf:rfc:5888'); // a=group, e.g. bundle + //this.connection.disco.addFeature('urn:ietf:rfc:5576'); // a=ssrc } this.connection.addHandler(this.onJingle.bind(this), 'urn:xmpp:jingle:1', 'iq', 'set', null, null);