haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/pcbnew/kicad_plugin.cpp

2268 lines
75 KiB
C++
Raw Normal View History

Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2012 CERN
Organize trace debugging code for ease of maintenance.
2018-04-13 13:58:25 +00:00
* Copyright (C) 1992-2018 KiCad Developers, see AUTHORS.txt for contributors.
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include <fctsys.h>
#include <kicad_string.h>
#include <common.h>
#include <build_version.h> // LEGACY_BOARD_FILE_VERSION
#include <macros.h>
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
#include <wildcards_and_files_ext.h>
Initial release of pl_editor, the page layout and title block editor.
2013-07-19 18:27:22 +00:00
#include <base_units.h>
Organize trace debugging code for ease of maintenance.
2018-04-13 13:58:25 +00:00
#include <trace_helpers.h>
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
#include <class_board.h>
#include <class_module.h>
#include <class_pcb_text.h>
#include <class_dimension.h>
#include <class_track.h>
#include <class_zone.h>
#include <class_drawsegment.h>
cleanup: replace CLASS_MIRE with CLASS_PCB_TARGET for naming clarity
2017-10-31 15:38:10 +00:00
#include <class_pcb_target.h>
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
#include <class_edge_mod.h>
Commit Dick's Pcbnew s-expression file parser bug fixes. * Apply Dick's patch along with a few minor changes to fix some clashes with changes in my branch. Thanks Dick! * Added missing DRAWSEGMENT line angle. * Fix thru hole pad layer mask issue.
2012-06-11 00:47:15 +00:00
#include <pcb_plot_params.h>
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
#include <zones.h>
#include <kicad_plugin.h>
#include <pcb_parser.h>
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
#include <wx/dir.h>
#include <wx/filename.h>
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
#include <wx/wfstream.h>
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
#include <boost/ptr_container/ptr_map.hpp>
#include <memory.h>
pcbnew: Separating connectivity to subdir
2018-10-12 06:17:15 +00:00
#include <connectivity/connectivity_data.h>
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
using namespace PCB_KEYS_T;
Convert footpint library log functions to trace functions to reduce debug output.
2012-10-07 22:26:17 +00:00
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
///> Removes empty nets (i.e. with node count equal zero) from net classes
void filterNetClass( const BOARD& aBoard, NETCLASS& aNetClass )
{
Removed legacy connectivity/ratsnest algorithm, replaced with the new one. No legacy autorouting for the moment
2017-03-22 13:51:07 +00:00
auto connectivity = aBoard.GetConnectivity();
Code formatting and clean-up
2017-06-23 11:56:28 +00:00
Avoid cast from const_iterator to iterator The standard library requires iterators passed to functions that modify the container to be mutable iterators, but GCC's implementation accepts const_iterator in some places where these are only used to mark a place, but the actual modification happens through a different parameter. As this breaks implementations that use the passed iterator to modify the container (e.g. because they use a different data organization), this is not portable; because we already have a non-const reference to the container anyway, this is trivially fixed as well.
2016-01-17 17:31:00 +00:00
for( NETCLASS::iterator it = aNetClass.begin(); it != aNetClass.end(); )
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
{
NETINFO_ITEM* netinfo = aBoard.FindNet( *it );
Removed legacy connectivity/ratsnest algorithm, replaced with the new one. No legacy autorouting for the moment
2017-03-22 13:51:07 +00:00
if( netinfo && connectivity->GetNodeCount( netinfo->GetNet() ) <= 0 ) // hopefully there are no nets with negative
bugfix: pcbnew crashes when you try to save a file
2014-07-13 17:08:42 +00:00
aNetClass.Remove( it++ ); // node count, but you never know..
else
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
++it;
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
}
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
/**
* Class FP_CACHE_ITEM
* is helper class for creating a footprint library cache.
*
* The new footprint library design is a file path of individual module files
* that contain a single module per file. This class is a helper only for the
* footprint portion of the PLUGIN API, and only for the #PCB_IO plugin. It is
* private to this implementation file so it is not placed into a header.
*/
class FP_CACHE_ITEM
{
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
WX_FILENAME m_filename;
Code cleanup: Remove outdated decimils to/from iu defines and conversion functions (decimils are no more in use since a long time). Remove convert_from_iu.h file, only used for one define, and containing brokenand duplicate defines. Only convert_to_biu.h is now used.
2016-06-05 11:49:25 +00:00
std::unique_ptr<MODULE> m_module;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
public:
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
FP_CACHE_ITEM( MODULE* aModule, const WX_FILENAME& aFileName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
const WX_FILENAME& GetFileName() const { return m_filename; }
const MODULE* GetModule() const { return m_module.get(); }
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
};
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
FP_CACHE_ITEM::FP_CACHE_ITEM( MODULE* aModule, const WX_FILENAME& aFileName ) :
m_filename( aFileName ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_module( aModule )
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
{ }
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
typedef boost::ptr_map< wxString, FP_CACHE_ITEM > MODULE_MAP;
typedef MODULE_MAP::iterator MODULE_ITER;
typedef MODULE_MAP::const_iterator MODULE_CITER;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
class FP_CACHE
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
PCB_IO* m_owner; // Plugin object that owns the cache.
wxFileName m_lib_path; // The path of the library.
wxString m_lib_raw_path; // For quick comparisons.
MODULE_MAP m_modules; // Map of footprint file name per MODULE*.
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Add GetLibraryTimestamp to other plugins. Fixes: lp:1752719 * https://bugs.launchpad.net/kicad/+bug/1752719
2018-03-02 20:41:37 +00:00
bool m_cache_dirty; // Stored separately because it's expensive to check
// m_cache_timestamp against all the files.
long long m_cache_timestamp; // A hash of the timestamps for all the footprint
// files.
Don't bail out of loading when one library couldn't be found. Also includes some cleanup to the error dialog (removing sunken border, fixing OK button, etc.) Fixes: lp:1749572 * https://bugs.launchpad.net/kicad/+bug/1749572
2018-02-10 23:10:39 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
public:
FP_CACHE( PCB_IO* aOwner, const wxString& aLibraryPath );
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
wxString GetPath() const { return m_lib_raw_path; }
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
bool IsWritable() const { return m_lib_path.IsOk() && m_lib_path.IsDirWritable(); }
Improve error message granularity When saving a library, check and report on libraries that do not exist as well as those that exist but are read-only. Fixes: lp:1769190 * https://bugs.launchpad.net/kicad/+bug/1769190
2018-05-04 16:10:51 +00:00
bool Exists() const { return m_lib_path.IsOk() && m_lib_path.DirExists(); }
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
MODULE_MAP& GetModules() { return m_modules; }
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
// Most all functions in this class throw IO_ERROR exceptions. There are no
// error codes nor user interface calls from here, nor in any PLUGIN.
// Catch these exceptions higher up please.
pcbnew: Save only edited footprint when saving Don't re-save all files in a library when editing a single footprint. This creates issues with formatting in version control systems where unmodified files are re-written without being explicitly changed by the user. Fixes: lp:1752991 * https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 21:39:26 +00:00
/**
* Function Save
* Save the footprint cache or a single module from it to disk
*
* @param aModule if set, save only this module, otherwise, save the full library
*/
void Save( MODULE* aModule = NULL );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
void Load();
void Remove( const wxString& aFootprintName );
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
/**
* Function GetTimestamp
* Generate a timestamp representing all source files in the cache (including the
* parent directory).
* Timestamps should not be considered ordered. They either match or they don't.
*/
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
static long long GetTimestamp( const wxString& aLibPath );
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
/**
* Function IsModified
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
* Return true if the cache is not up-to-date.
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
*/
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
bool IsModified();
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
/**
* Function IsPath
* checks if \a aPath is the same as the current cache path.
*
* This tests paths by converting \a aPath using the native separators. Internally
* #FP_CACHE stores the current path using native separators. This prevents path
* miscompares on Windows due to the fact that paths can be stored with / instead of \\
* in the footprint library table.
*
* @param aPath is the library path to test against.
* @return true if \a aPath is the same as the cache path.
*/
bool IsPath( const wxString& aPath ) const;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
};
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
FP_CACHE::FP_CACHE( PCB_IO* aOwner, const wxString& aLibraryPath )
{
m_owner = aOwner;
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
m_lib_raw_path = aLibraryPath;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
m_lib_path.SetPath( aLibraryPath );
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
m_cache_timestamp = 0;
m_cache_dirty = true;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
pcbnew: Save only edited footprint when saving Don't re-save all files in a library when editing a single footprint. This creates issues with formatting in version control systems where unmodified files are re-written without being explicitly changed by the user. Fixes: lp:1752991 * https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 21:39:26 +00:00
void FP_CACHE::Save( MODULE* aModule )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
m_cache_timestamp = 0;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !m_lib_path.DirExists() && !m_lib_path.Mkdir() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "Cannot create footprint library path \"%s\"" ),
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
m_lib_raw_path ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
if( !m_lib_path.IsDirWritable() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "Footprint library path \"%s\" is read only" ),
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
m_lib_raw_path ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( MODULE_ITER it = m_modules.begin(); it != m_modules.end(); ++it )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
pcbnew: Save only edited footprint when saving Don't re-save all files in a library when editing a single footprint. This creates issues with formatting in version control systems where unmodified files are re-written without being explicitly changed by the user. Fixes: lp:1752991 * https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 21:39:26 +00:00
if( aModule && aModule != it->second->GetModule() )
continue;
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
WX_FILENAME fn = it->second->GetFileName();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Minor fixes. Remove unused icon. Add 3 new icons. Change one icon (3 icons are from Konstantin Baranowskiy)
2014-12-11 12:00:59 +00:00
wxString tempFileName =
#ifdef USE_TMP_FILE
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxFileName::CreateTempFileName( fn.GetPath() );
Minor fixes. Remove unused icon. Add 3 new icons. Change one icon (3 icons are from Konstantin Baranowskiy)
2014-12-11 12:00:59 +00:00
#else
fn.GetFullPath();
#endif
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
// Allow file output stream to go out of scope to close the file stream before
// renaming the file.
{
Organize trace debugging code for ease of maintenance.
2018-04-13 13:58:25 +00:00
wxLogTrace( traceKicadPcbPlugin, wxT( "Creating temporary library file %s" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
GetChars( tempFileName ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
streamline the FILE_OUTPUTFORMATTER API for ease of use
2012-10-25 07:10:59 +00:00
FILE_OUTPUTFORMATTER formatter( tempFileName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
add class FILE_OUTPUTFORMATTER and use it in PCB_IO, since it is about 8-10 faster than STREAM_OUTPUTFORMATTER
2012-10-25 05:52:55 +00:00
m_owner->SetOutputFormatter( &formatter );
m_owner->Format( (BOARD_ITEM*) it->second->GetModule() );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Minor fixes. Remove unused icon. Add 3 new icons. Change one icon (3 icons are from Konstantin Baranowskiy)
2014-12-11 12:00:59 +00:00
#ifdef USE_TMP_FILE
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
wxRemove( fn.GetFullPath() ); // it is not an error if this does not exist
Fix temporary file bug when saving modified footprints. (fixes lp:1384550) * Use wxRenameFile which falls back to a file copy and file remove when wxRename fails.
2014-10-23 20:25:04 +00:00
// Even on linux you can see an _intermittent_ error when calling wxRename(),
// and it is fully inexplicable. See if this dodges the error.
wxMilliSleep( 250L );
if( !wxRenameFile( tempFileName, fn.GetFullPath() ) )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
cvpcb was not filtering on the current library when USE_FP_LIB_TABLE. <%s> being replaced with '%s' because the former in invisible in html panels. Cure some compiler warnings.
2013-10-31 21:30:57 +00:00
wxString msg = wxString::Format(
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
_( "Cannot rename temporary file \"%s\" to footprint library file \"%s\"" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
GetChars( tempFileName ),
GetChars( fn.GetFullPath() )
);
cvpcb was not filtering on the current library when USE_FP_LIB_TABLE. <%s> being replaced with '%s' because the former in invisible in html panels. Cure some compiler warnings.
2013-10-31 21:30:57 +00:00
THROW_IO_ERROR( msg );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Minor fixes. Remove unused icon. Add 3 new icons. Change one icon (3 icons are from Konstantin Baranowskiy)
2014-12-11 12:00:59 +00:00
#endif
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
m_cache_timestamp += fn.GetTimestamp();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
m_cache_timestamp += m_lib_path.GetModificationTime().GetValue().GetValue();
pcbnew: Save only edited footprint when saving Don't re-save all files in a library when editing a single footprint. This creates issues with formatting in version control systems where unmodified files are re-written without being explicitly changed by the user. Fixes: lp:1752991 * https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 21:39:26 +00:00
// If we've saved the full cache, we clear the dirty flag.
if( !aModule )
m_cache_dirty = false;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
void FP_CACHE::Load()
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
{
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
m_cache_dirty = false;
m_cache_timestamp = 0;
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxDir dir( m_lib_raw_path );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !dir.IsOpened() )
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
wxString msg = wxString::Format( _( "Footprint library path \"%s\" does not exist" ),
m_lib_raw_path );
cvpcb was not filtering on the current library when USE_FP_LIB_TABLE. <%s> being replaced with '%s' because the former in invisible in html panels. Cure some compiler warnings.
2013-10-31 21:30:57 +00:00
THROW_IO_ERROR( msg );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxString fullName;
wxString fileSpec = wxT( "*." ) + KiCadFootprintFileExtension;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
// wxFileName construction is egregiously slow. Construct it once and just swap out
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
// the filename thereafter.
WX_FILENAME fn( m_lib_raw_path, wxT( "dummyName" ) );
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
if( dir.GetFirst( &fullName, fileSpec ) )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
wxString cacheError;
fix FP_CACHE::Load()
2013-07-28 16:30:02 +00:00
do
{
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
fn.SetFullName( fullName );
fix FP_CACHE::Load()
2013-07-28 16:30:02 +00:00
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
// Queue I/O errors so only files that fail to parse don't get loaded.
try
{
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
FILE_LINE_READER reader( fn.GetFullPath() );
move PCB_PARSER into PCB_IO as a member
2012-10-24 18:20:33 +00:00
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
m_owner->m_parser->SetLineReader( &reader );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
MODULE* footprint = (MODULE*) m_owner->m_parser->Parse();
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
wxString fpName = fn.GetName();
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
Handle separate parsing rules for ID_SCH and ID_PCB. This removes the existing constructors so that all parsing must be explicit and callers are made aware that they need to think about illegal characters, malformed ids, etc. Fixes: lp:1783474 * https://bugs.launchpad.net/kicad/+bug/1783474
2018-07-26 14:38:30 +00:00
footprint->SetFPID( LIB_ID( wxEmptyString, fpName ) );
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
m_modules.insert( fpName, new FP_CACHE_ITEM( footprint, fn ) );
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
m_cache_timestamp += fn.GetTimestamp();
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
}
catch( const IO_ERROR& ioe )
{
if( !cacheError.IsEmpty() )
cacheError += "\n\n";
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
cacheError += ioe.What();
}
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
} while( dir.GetNext( &fullName ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Pcbnew: continue loading footprints after first failure. The footprint library cache handler would throw an exception on the first error it encountered preventing all subsequent footprint files from being parsed even if there was nothing wrong with them. This commit queues errors until all of the footprint files in the folder have been parsed. Fixes lp:1416736 https://bugs.launchpad.net/kicad/+bug/1416736
2017-05-03 19:27:07 +00:00
if( !cacheError.IsEmpty() )
THROW_IO_ERROR( cacheError );
fix FP_CACHE::Load()
2013-07-28 16:30:02 +00:00
}
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
void FP_CACHE::Remove( const wxString& aFootprintName )
{
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
MODULE_CITER it = m_modules.find( aFootprintName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( it == m_modules.end() )
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
wxString msg = wxString::Format( _( "library \"%s\" has no footprint \"%s\" to delete" ),
m_lib_raw_path,
aFootprintName );
cvpcb was not filtering on the current library when USE_FP_LIB_TABLE. <%s> being replaced with '%s' because the former in invisible in html panels. Cure some compiler warnings.
2013-10-31 21:30:57 +00:00
THROW_IO_ERROR( msg );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
// Remove the module from the cache and delete the module file from the library.
wxString fullPath = it->second->GetFileName().GetFullPath();
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
m_modules.erase( aFootprintName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
wxRemoveFile( fullPath );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
bool FP_CACHE::IsPath( const wxString& aPath ) const
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
return aPath == m_lib_raw_path;
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
bool FP_CACHE::IsModified()
{
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
m_cache_dirty = m_cache_dirty || GetTimestamp( m_lib_path.GetFullPath() ) != m_cache_timestamp;
return m_cache_dirty;
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
}
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
long long FP_CACHE::GetTimestamp( const wxString& aLibPath )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxString fileSpec = wxT( "*." ) + KiCadFootprintFileExtension;
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
return TimestampDir( aLibPath, fileSpec );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
void PCB_IO::Save( const wxString& aFileName, BOARD* aBoard, const PROPERTIES* aProperties )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle; // toggles on, then off, the C locale.
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
add CTL_OMIT_INITIAL_COMMENTS and CTL_FOR_BOARD PCB_IO::Format()ing flags
2013-06-24 05:30:22 +00:00
init( aProperties );
m_board = aBoard; // after init()
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Added NETINFO_MAPPING, to ease saving nets with consecutive net codes (without modifying the net codes during the run time). Now, nets are saved with consecutive net codes (both modern & legacy plugins). Zones are saved together with their nets, without depending on the fact if there are any pads with such net. Therefore validation of zone net names was removed (pcbnew/class_board.cpp). Performed tests: - Changed a pad's net name from empty to existent - ok, name was changed. - Changed a pad's net name from empty to nonexistent - ok, error message is displayed, net name stays empty. - Changed a pad's net name from existent to empty - ok, net name became empty - Changed a pad's net name from existent to nonexistent - ok, error message is displayed, net name is not changed. - Drawn a zone that belongs to a net, then modified schematics so the net does not exist anymore. After reloading the net list, all pads/tracks are updated. Zones still belongs to the net that does not exist in the schematic (but still exists in .kicad_pcb file). After running DRC, the zone becomes not filled. - Undo & redo affects assignment of a polygon to a specific net (you may change net of a polygon, refill it and undo/redo the changes). - KiCad s-expr & legacy, Eagle, P-CAD boards seem to load without any problem (they also contain correct net names assigned to the appropriate pads). All types of board file formats were loaded, then saved in sexpr format and reopened with a KiCad built from the master branch (without my modifications). - A few boards were also saved using the legacy format and were opened with the master KiCad without any issues. - Change a net name for a pad, restore with undo/redo - ok - Remove everything, restore with undo - ok - Remove everything, reload netlist - ok Differences observed between files saved by the master branch KiCad and this one: - list of nets are not saved in any particular order, so net codes may differ - the default net class does not contain the unconnected net
2014-01-28 09:19:51 +00:00
// Prepare net mapping that assures that net codes saved in a file are consecutive integers
m_mapping->SetBoard( aBoard );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
FILE_OUTPUTFORMATTER formatter( aFileName );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out = &formatter; // no ownership
m_out->Print( 0, "(kicad_pcb (version %d) (host pcbnew %s)\n", SEXPR_BOARD_FILE_VERSION,
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
formatter.Quotew( GetBuildVersion() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Format( aBoard, 1 );
m_out->Print( 0, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Add support for PCB and footprint format versioning Currently, kicad_pcb files have a (version ...) tag, but it is ignored. This commit does the following: 1. Parse the version. If it's later than the last supported version, present an alternative error message suggesting an upgrade if the file does not load correctly. The version will be interpreted as an integer YYYYMMDD to suggest a KiCad release date. 2. Accept a (version ...) tag also in kicad_mod files, but do not write them yet. If no version tag is present in these files, assume the version to be that of the current format version at the time of this commit. This is meant to be merged to the 4.x stable series, and preps for KiCad 5 which will start emitting version tags also in footprints - users with what will then be 'old stable' will not get a parse error when we introduce this for footprints, and we can safely increment the format version later.
2016-05-10 19:07:35 +00:00
BOARD_ITEM* PCB_IO::Parse( const wxString& aClipboardSourceInput )
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
{
std::string input = TO_UTF8( aClipboardSourceInput );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
STRING_LINE_READER reader( input, wxT( "clipboard" ) );
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
move PCB_PARSER into PCB_IO as a member
2012-10-24 18:20:33 +00:00
m_parser->SetLineReader( &reader );
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
Add support for PCB and footprint format versioning Currently, kicad_pcb files have a (version ...) tag, but it is ignored. This commit does the following: 1. Parse the version. If it's later than the last supported version, present an alternative error message suggesting an upgrade if the file does not load correctly. The version will be interpreted as an integer YYYYMMDD to suggest a KiCad release date. 2. Accept a (version ...) tag also in kicad_mod files, but do not write them yet. If no version tag is present in these files, assume the version to be that of the current format version at the time of this commit. This is meant to be merged to the 4.x stable series, and preps for KiCad 5 which will start emitting version tags also in footprints - users with what will then be 'old stable' will not get a parse error when we introduce this for footprints, and we can safely increment the format version later.
2016-05-10 19:07:35 +00:00
try
{
return m_parser->Parse();
}
catch( const PARSE_ERROR& parse_error )
{
if( m_parser->IsTooRecent() )
throw FUTURE_FORMAT_ERROR( parse_error, m_parser->GetRequiredVersion() );
else
throw;
}
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::Format( BOARD_ITEM* aItem, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle; // public API function, perform anything convenient for caller
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aItem->Type() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
case PCB_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<BOARD*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_DIMENSION_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<DIMENSION*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_LINE_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<DRAWSEGMENT*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_MODULE_EDGE_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<EDGE_MODULE*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_TARGET_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<PCB_TARGET*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_MODULE_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<MODULE*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_PAD_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<D_PAD*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_TEXT_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<TEXTE_PCB*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_MODULE_TEXT_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<TEXTE_MODULE*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_TRACE_T:
case PCB_VIA_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<TRACK*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
case PCB_ZONE_AREA_T:
TEXTE_MODULE cleanup in preparation for text on different layers - Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE (as in the @todo comment) - Refactored the Rotate/Flip/Mirror for text in modules into the TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule, MirrorWithModule) - New behaviour in coloring text on screen: reference and value still take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE visibles; other text takes the color of the layer containing it (except when hidden, obviously) but still get its visibility controlled by those visibles (probably the most intuitive and useful behaviour) - Still need to decide: should text on a layer be hidden when the layer is? Probably yes (still to be implemented); - Some comment fixed and many cast converted to static_cast
2014-09-10 15:18:42 +00:00
format( static_cast<ZONE_CONTAINER*>( aItem ), aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
default:
wxFAIL_MSG( wxT( "Cannot format item " ) + aItem->GetClass() );
}
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
void PCB_IO::formatLayer( const BOARD_ITEM* aItem ) const
{
Consistent with my email posting from a day or two ago, remove the translated standard layer name support from BOARD::GetLayerName(). This function evolved in a contorted direction over time, and was being asked to return one of 3 different kinds of layer names, even though it only took a boolean to control that choice. Users are better served by forcing them to get to know the concise new English Standard layer names. This is because these concise names show up in the "pretty" footprint/module files as the standard representation of both feature and copper layers. Change the name of BOARD::GetDefaultLayerName() to GetStandardLayerName(). Drop boolean argument to both BOARD::GetStandardLayerName() and BOARD::GetLayerName().
2013-03-20 04:46:32 +00:00
if( m_ctl & CTL_STD_LAYER_NAMES )
switch to new s-expression format for footprint exports, use english layernames for naked footprints, dodge conflict with pythons HAVE_GETC_UNLOCKED
2012-11-10 06:39:18 +00:00
{
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
PCB_LAYER_ID layer = aItem->GetLayer();
switch to new s-expression format for footprint exports, use english layernames for naked footprints, dodge conflict with pythons HAVE_GETC_UNLOCKED
2012-11-10 06:39:18 +00:00
// English layer names should never need quoting.
Consistent with my email posting from a day or two ago, remove the translated standard layer name support from BOARD::GetLayerName(). This function evolved in a contorted direction over time, and was being asked to return one of 3 different kinds of layer names, even though it only took a boolean to control that choice. Users are better served by forcing them to get to know the concise new English Standard layer names. This is because these concise names show up in the "pretty" footprint/module files as the standard representation of both feature and copper layers. Change the name of BOARD::GetDefaultLayerName() to GetStandardLayerName(). Drop boolean argument to both BOARD::GetStandardLayerName() and BOARD::GetLayerName().
2013-03-20 04:46:32 +00:00
m_out->Print( 0, " (layer %s)", TO_UTF8( BOARD::GetStandardLayerName( layer ) ) );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
else
switch to new s-expression format for footprint exports, use english layernames for naked footprints, dodge conflict with pythons HAVE_GETC_UNLOCKED
2012-11-10 06:39:18 +00:00
m_out->Print( 0, " (layer %s)", m_out->Quotew( aItem->GetLayerName() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
updating patch to master
2017-09-17 12:04:57 +00:00
void PCB_IO::formatSetup( BOARD* aBoard, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
const BOARD_DESIGN_SETTINGS& dsnSettings = aBoard->GetDesignSettings();
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Setup
m_out->Print( aNestLevel, "(setup\n" );
// Save current default track width, for compatibility with older Pcbnew version;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(last_trace_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetCurrentTrackWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save custom tracks width list (the first is not saved here: this is the netclass value
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
for( unsigned ii = 1; ii < dsnSettings.m_TrackWidthList.size(); ii++ )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(user_trace_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TrackWidthList[ii] ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(trace_clearance %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetDefault()->GetClearance() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// ZONE_SETTINGS
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(zone_clearance %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aBoard->GetZoneSettings().m_ZoneClearance ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(zone_45_only %s)\n",
aBoard->GetZoneSettings().m_Zone_45_Only ? "yes" : "no" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(trace_min %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TrackMinWidth ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save current default via size, for compatibility with older Pcbnew version;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(via_size %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetDefault()->GetViaDiameter() ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(via_drill %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetDefault()->GetViaDrill() ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(via_min_size %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_ViasMinSize ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(via_min_drill %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_ViasMinDrill ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save custom vias diameters list (the first is not saved here: this is
// the netclass value
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
for( unsigned ii = 1; ii < dsnSettings.m_ViasDimensionsList.size(); ii++ )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(user_via %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_ViasDimensionsList[ii].m_Diameter ).c_str(),
FormatInternalUnits( dsnSettings.m_ViasDimensionsList[ii].m_Drill ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
// for old versions compatibility:
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
if( dsnSettings.m_BlindBuriedViaAllowed )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(blind_buried_vias_allowed yes)\n" );
m_out->Print( aNestLevel+1, "(uvia_size %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetDefault()->GetuViaDiameter() ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(uvia_drill %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetDefault()->GetuViaDrill() ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(uvias_allowed %s)\n",
( dsnSettings.m_MicroViasAllowed ) ? "yes" : "no" );
m_out->Print( aNestLevel+1, "(uvia_min_size %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_MicroViasMinSize ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(uvia_min_drill %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_MicroViasMinDrill ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
// 6.0 TODO: are we going to update the tokens we save these under?
// 6.0 TODO: need to save the LAYER_CLASS_OTHERS stuff
// 6.0 TODO: need to save the TextItalic and TextUpright settings
m_out->Print( aNestLevel+1, "(edge_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_LineThickness[ LAYER_CLASS_EDGES ] ).c_str() );
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
m_out->Print( aNestLevel+1, "(segment_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_LineThickness[ LAYER_CLASS_COPPER ] ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pcb_text_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TextThickness[ LAYER_CLASS_COPPER ] ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pcb_text_size %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TextSize[ LAYER_CLASS_COPPER ].x ).c_str(),
FormatInternalUnits( dsnSettings.m_TextSize[ LAYER_CLASS_COPPER ].y ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(mod_edge_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_LineThickness[ LAYER_CLASS_SILK ] ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(mod_text_size %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TextSize[ LAYER_CLASS_SILK ].x ).c_str(),
FormatInternalUnits( dsnSettings.m_TextSize[ LAYER_CLASS_SILK ].y ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(mod_text_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_TextThickness[ LAYER_CLASS_SILK ] ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pad_size %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_Pad_Master.GetSize().x ).c_str(),
FormatInternalUnits( dsnSettings.m_Pad_Master.GetSize().y ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pad_drill %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_Pad_Master.GetDrillSize().x ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pad_to_mask_clearance %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_SolderMaskMargin ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
if( dsnSettings.m_SolderMaskMinWidth )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(solder_mask_min_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_SolderMaskMinWidth ).c_str() );
Add a min width parameter to plot solder mask layers.
2012-11-05 20:20:34 +00:00
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
if( dsnSettings.m_SolderPasteMargin != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pad_to_paste_clearance %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.m_SolderPasteMargin ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
if( dsnSettings.m_SolderPasteMarginRatio != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(pad_to_paste_clearance_ratio %s)\n",
Double2Str( dsnSettings.m_SolderPasteMarginRatio ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(aux_axis_origin %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aBoard->GetAuxOrigin().x ).c_str(),
FormatInternalUnits( aBoard->GetAuxOrigin().y ).c_str() );
*) retain grid origin in the BOARD and save it in legacy and kicad board files. *) add hotkey for setting the grid origin as 'S', in board editor, module editor. *) re-position the function interface for cursor movement from BASE_SCREEN into class EDA_DRAW_FRAME. This is a prelude to getting rid of BASE_SCREEN or splitting it up.
2013-08-03 05:15:23 +00:00
Pcbnew: add hotkey Z to reset grid origin. Save grid origin in .kicad_pcb files only if not 0,0 (to keep compatibility with previous versions of pcbnew, mainly the stable version) Very minor other fixes (set modify flag when grid origin is moved from the dialog grid)
2013-08-03 16:16:57 +00:00
if( aBoard->GetGridOrigin().x || aBoard->GetGridOrigin().y )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(grid_origin %s %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aBoard->GetGridOrigin().x ).c_str(),
FormatInternalUnits( aBoard->GetGridOrigin().y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(visible_elements %X)\n",
dsnSettings.GetVisibleElements() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aBoard->GetPlotOptions().Format( m_out, aNestLevel+1 );
Commit Dick's Pcbnew s-expression file parser bug fixes. * Apply Dick's patch along with a few minor changes to fix some clashes with changes in my branch. Thanks Dick! * Added missing DRAWSEGMENT line angle. * Fix thru hole pad layer mask issue.
2012-06-11 00:47:15 +00:00
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, ")\n\n" );
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
updating patch to master
2017-09-17 12:04:57 +00:00
void PCB_IO::formatGeneral( BOARD* aBoard, int aNestLevel ) const
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
{
const BOARD_DESIGN_SETTINGS& dsnSettings = aBoard->GetDesignSettings();
m_out->Print( 0, "\n" );
m_out->Print( aNestLevel, "(general\n" );
// Write Bounding box info
m_out->Print( aNestLevel+1, "(thickness %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( dsnSettings.GetBoardThickness() ).c_str() );
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
updating patch to master
2017-09-17 12:04:57 +00:00
m_out->Print( aNestLevel+1, "(drawings %d)\n", aBoard->Drawings().Size() );
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
m_out->Print( aNestLevel+1, "(tracks %d)\n", aBoard->GetNumSegmTrack() );
m_out->Print( aNestLevel+1, "(zones %d)\n", aBoard->GetNumSegmZone() );
m_out->Print( aNestLevel+1, "(modules %d)\n", aBoard->m_Modules.GetCount() );
m_out->Print( aNestLevel+1, "(nets %d)\n", m_mapping->GetSize() );
m_out->Print( aNestLevel, ")\n\n" );
aBoard->GetPageSettings().Format( m_out, aNestLevel, m_ctl );
aBoard->GetTitleBlock().Format( m_out, aNestLevel, m_ctl );
}
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
updating patch to master
2017-09-17 12:04:57 +00:00
void PCB_IO::formatBoardLayers( BOARD* aBoard, int aNestLevel ) const
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
{
m_out->Print( aNestLevel, "(layers\n" );
// Save only the used copper layers from front to back.
LSET visible_layers = aBoard->GetVisibleLayers();
for( LSEQ cu = aBoard->GetEnabledLayers().CuStack(); cu; ++cu )
{
PCB_LAYER_ID layer = *cu;
m_out->Print( aNestLevel+1, "(%d %s %s", layer,
m_out->Quotew( aBoard->GetLayerName( layer ) ).c_str(),
LAYER::ShowType( aBoard->GetLayerType( layer ) ) );
if( !visible_layers[layer] )
m_out->Print( 0, " hide" );
m_out->Print( 0, ")\n" );
}
// Save used non-copper layers in the order they are defined.
// desired sequence for non Cu BOARD layers.
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
static const PCB_LAYER_ID non_cu[] =
{
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
B_Adhes, // 32
F_Adhes,
B_Paste,
F_Paste,
B_SilkS,
F_SilkS,
B_Mask,
F_Mask,
Dwgs_User,
Cmts_User,
Eco1_User,
Eco2_User,
Edge_Cuts,
Margin,
B_CrtYd,
F_CrtYd,
B_Fab,
F_Fab
};
Replace DIM() macro The standard DIM() macro was not typesafe as it happily deferred errors to runtime that can be caught at compile time. Replacing it with a generic C++11 constexpr allows for typecasting, comparison and compile time error checking.
2019-01-06 16:43:12 +00:00
for( LSEQ seq = aBoard->GetEnabledLayers().Seq( non_cu, arrayDim( non_cu ) ); seq; ++seq )
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
{
PCB_LAYER_ID layer = *seq;
m_out->Print( aNestLevel+1, "(%d %s user", layer,
m_out->Quotew( aBoard->GetLayerName( layer ) ).c_str() );
if( !visible_layers[layer] )
m_out->Print( 0, " hide" );
m_out->Print( 0, ")\n" );
}
m_out->Print( aNestLevel, ")\n\n" );
}
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
updating patch to master
2017-09-17 12:04:57 +00:00
void PCB_IO::formatNetInformation( BOARD* aBoard, int aNestLevel ) const
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
{
const BOARD_DESIGN_SETTINGS& dsnSettings = aBoard->GetDesignSettings();
Added NETINFO_MAPPING, to ease saving nets with consecutive net codes (without modifying the net codes during the run time). Now, nets are saved with consecutive net codes (both modern & legacy plugins). Zones are saved together with their nets, without depending on the fact if there are any pads with such net. Therefore validation of zone net names was removed (pcbnew/class_board.cpp). Performed tests: - Changed a pad's net name from empty to existent - ok, name was changed. - Changed a pad's net name from empty to nonexistent - ok, error message is displayed, net name stays empty. - Changed a pad's net name from existent to empty - ok, net name became empty - Changed a pad's net name from existent to nonexistent - ok, error message is displayed, net name is not changed. - Drawn a zone that belongs to a net, then modified schematics so the net does not exist anymore. After reloading the net list, all pads/tracks are updated. Zones still belongs to the net that does not exist in the schematic (but still exists in .kicad_pcb file). After running DRC, the zone becomes not filled. - Undo & redo affects assignment of a polygon to a specific net (you may change net of a polygon, refill it and undo/redo the changes). - KiCad s-expr & legacy, Eagle, P-CAD boards seem to load without any problem (they also contain correct net names assigned to the appropriate pads). All types of board file formats were loaded, then saved in sexpr format and reopened with a KiCad built from the master branch (without my modifications). - A few boards were also saved using the legacy format and were opened with the master KiCad without any issues. - Change a net name for a pad, restore with undo/redo - ok - Remove everything, restore with undo - ok - Remove everything, reload netlist - ok Differences observed between files saved by the master branch KiCad and this one: - list of nets are not saved in any particular order, so net codes may differ - the default net class does not contain the unconnected net
2014-01-28 09:19:51 +00:00
for( NETINFO_MAPPING::iterator net = m_mapping->begin(), netEnd = m_mapping->end();
Added iterators for NETINFO_LIST (as net codes for existing net codes may be not consecutive).
2014-01-16 15:47:31 +00:00
net != netEnd; ++net )
EAGLE_PLUGIN now establishes (trace_min), (via_min_size), (via_min_drill), and Default Net's (clearance) by groking the eagle *.brd info. This makes it more probable that fewer DRC errors come about on first DRC attempt.
2013-03-14 22:54:47 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel, "(net %d %s)\n",
m_mapping->Translate( net->GetNet() ),
m_out->Quotew( net->GetNetname() ).c_str() );
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, "\n" );
// Save the default net class first.
Minor BOARD_DESIGN_SETTINGS refactoring. Removed SetCurrentClassName() (it was not used anywhere and less safe than SetCurrentClass()). Added BOARD_DESIGN_SETTIGNS::GetDefault() to make some pieces of shorter and clearer.
2014-05-15 08:51:08 +00:00
NETCLASS defaultNC = *dsnSettings.GetDefault();
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
filterNetClass( *aBoard, defaultNC ); // Remove empty nets (from a copy of a netclass)
defaultNC.Format( m_out, aNestLevel, m_ctl );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save the rest of the net classes alphabetically.
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
for( NETCLASSES::const_iterator it = dsnSettings.m_NetClasses.begin();
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
it != dsnSettings.m_NetClasses.end();
++it )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Moved NETCLASSES to BOARD_DESIGN_SETTINGS. Most of the changes are just adding GetDesignSettings() before every occurence of m_NetClasses. More complex changes: class_netclass.cpp - NETCLASS does not store the pointer to the parent BOARD anymore. Added function SetParams( BOARD_DESIGN_SETTINGS& ). class_netclass.h - Removed GetTrackMinWidth(), GetViaMinDiameter(), GetViaMinDrill(), GetuViaMinDiameter(), GetuViaMinDrill() as they were refering to BOARD_DESIGN_SETTINGS anyway (they are not net class specific). kicad_plugin.cpp - filters out empty nets (that are anyway not saved) when storing net class information. Previously it was done in NETCLASS::Format() function.
2014-05-13 09:22:51 +00:00
NETCLASS netclass = *it->second;
filterNetClass( *aBoard, netclass ); // Remove empty nets (from a copy of a netclass)
netclass.Format( m_out, aNestLevel, m_ctl );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Added a new plugin that can save and load to clipboard, using ctrl+shift+c/v for copy pasting Added the needed kicad_clipboard files and made copy pasted modules have no path
2017-04-15 16:08:23 +00:00
}
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
updating patch to master
2017-09-17 12:04:57 +00:00
void PCB_IO::formatHeader( BOARD* aBoard, int aNestLevel ) const
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
{
Removed extra space in header part, fixed coding style
2017-10-27 08:59:49 +00:00
formatGeneral( aBoard, aNestLevel );
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
// Layers.
Removed extra space in header part, fixed coding style
2017-10-27 08:59:49 +00:00
formatBoardLayers( aBoard, aNestLevel );
Made the formatHeader into multiple small functions
2017-05-18 16:43:01 +00:00
// Setup
formatSetup( aBoard, aNestLevel );
// Save net codes and names
formatNetInformation( aBoard, aNestLevel );
}
Added a new plugin that can save and load to clipboard, using ctrl+shift+c/v for copy pasting Added the needed kicad_clipboard files and made copy pasted modules have no path
2017-04-15 16:08:23 +00:00
void PCB_IO::format( BOARD* aBoard, int aNestLevel ) const
{
Removed extra space in header part, fixed coding style
2017-10-27 08:59:49 +00:00
formatHeader( aBoard, aNestLevel );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save the modules.
1. Fixed copy paste error in append_board_to_current.cpp ruining a if else condition, should fix a possible bounding box computation bug 2. Whole bunch of pointless casts removed 3. Unused variables removed 4. Fix bug caused by JP on April 25, 2015 where strings were adjusted for translation and the hotkeys section table accidentally swapped the footprint editor title with tag, resulting in "footprint editor" being exported instead of "[footprinteditor]" No functional changes besides #4, technically it'll "break" imports hotkeys files but April 25 broke imports as well.
2015-11-04 08:48:34 +00:00
for( MODULE* module = aBoard->m_Modules; module; module = module->Next() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Format( module, aNestLevel );
m_out->Print( 0, "\n" );
}
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
// Save the graphical items on the board (not owned by a module)
Hide DLISTs behind iterators, first step towards refactoring the storage model
2016-09-27 18:04:30 +00:00
for( auto item : aBoard->Drawings() )
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
Format( item, aNestLevel );
Hide DLISTs behind iterators, first step towards refactoring the storage model
2016-09-27 18:04:30 +00:00
if( aBoard->Drawings().Size() )
Switch over to *.kicad_pcb format as the default BOARD format. Add KiCadPcbFileExt global.
2012-12-14 16:54:54 +00:00
m_out->Print( 0, "\n" );
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Do not save MARKER_PCBs, they can be regenerated easily.
// Save the tracks and vias.
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( TRACK* track = aBoard->m_Track; track; track = track->Next() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Format( track, aNestLevel );
Switch over to *.kicad_pcb format as the default BOARD format. Add KiCadPcbFileExt global.
2012-12-14 16:54:54 +00:00
if( aBoard->m_Track.GetCount() )
m_out->Print( 0, "\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
/// @todo Add warning here that the old segment filed zones are no longer supported and
/// will not be saved.
// Save the polygon (which are the newer technology) zones.
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( int i = 0; i < aBoard->GetAreaCount(); ++i )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Format( aBoard->GetArea( i ), aNestLevel );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( DIMENSION* aDimension, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
m_out->Print( aNestLevel, "(dimension %s (width %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->GetValue() ).c_str(),
FormatInternalUnits( aDimension->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
formatLayer( aDimension );
if( aDimension->GetTimeStamp() )
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long)aDimension->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, "\n" );
1. Fixed copy paste error in append_board_to_current.cpp ruining a if else condition, should fix a possible bounding box computation bug 2. Whole bunch of pointless casts removed 3. Unused variables removed 4. Fix bug caused by JP on April 25, 2015 where strings were adjusted for translation and the hotkeys section table accidentally swapped the footprint editor title with tag, resulting in "footprint editor" being exported instead of "[footprinteditor]" No functional changes besides #4, technically it'll "break" imports hotkeys files but April 25 broke imports as well.
2015-11-04 08:48:34 +00:00
Format( &aDimension->Text(), aNestLevel+1 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(feature1 (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_featureLineDO.x ).c_str(),
FormatInternalUnits( aDimension->m_featureLineDO.y ).c_str(),
FormatInternalUnits( aDimension->m_featureLineDF.x ).c_str(),
FormatInternalUnits( aDimension->m_featureLineDF.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(feature2 (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_featureLineGO.x ).c_str(),
FormatInternalUnits( aDimension->m_featureLineGO.y ).c_str(),
FormatInternalUnits( aDimension->m_featureLineGF.x ).c_str(),
FormatInternalUnits( aDimension->m_featureLineGF.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(crossbar (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_crossBarO.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarO.y ).c_str(),
FormatInternalUnits( aDimension->m_crossBarF.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarF.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(arrow1a (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_crossBarF.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarF.y ).c_str(),
FormatInternalUnits( aDimension->m_arrowD1F.x ).c_str(),
FormatInternalUnits( aDimension->m_arrowD1F.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(arrow1b (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_crossBarF.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarF.y ).c_str(),
FormatInternalUnits( aDimension->m_arrowD2F.x ).c_str(),
FormatInternalUnits( aDimension->m_arrowD2F.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(arrow2a (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_crossBarO.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarO.y ).c_str(),
FormatInternalUnits( aDimension->m_arrowG1F.x ).c_str(),
FormatInternalUnits( aDimension->m_arrowG1F.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel+1, "(arrow2b (pts (xy %s %s) (xy %s %s)))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aDimension->m_crossBarO.x ).c_str(),
FormatInternalUnits( aDimension->m_crossBarO.y ).c_str(),
FormatInternalUnits( aDimension->m_arrowG2F.x ).c_str(),
FormatInternalUnits( aDimension->m_arrowG2F.y ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( DRAWSEGMENT* aSegment, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aSegment->GetShape() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
case S_SEGMENT: // Line
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(gr_line (start %s) (end %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aSegment->GetStart() ).c_str(),
FormatInternalUnits( aSegment->GetEnd() ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( aSegment->GetAngle() != 0.0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (angle %s)", FormatAngle( aSegment->GetAngle() ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_CIRCLE: // Circle
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(gr_circle (center %s) (end %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aSegment->GetStart() ).c_str(),
FormatInternalUnits( aSegment->GetEnd() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_ARC: // Arc
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(gr_arc (start %s) (end %s) (angle %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aSegment->GetStart() ).c_str(),
FormatInternalUnits( aSegment->GetEnd() ).c_str(),
FormatAngle( aSegment->GetAngle() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_POLYGON: // Polygon
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
if( aSegment->IsPolyShapeValid() )
{
SHAPE_POLY_SET& poly = aSegment->GetPolyShape();
SHAPE_LINE_CHAIN& outline = poly.Outline( 0 );
int pointsCount = outline.PointCount();
m_out->Print( aNestLevel, "(gr_poly (pts" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
for( int ii = 0; ii < pointsCount; ++ii )
{
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (xy %s)", FormatInternalUnits( outline.CPoint( ii ) ).c_str() );
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
m_out->Print( 0, ")" );
}
Don't save broken polygon If a polygon has fewer than 3 points, it is invalid. We need to register this as failure, otherwise we save the formatting/closing s-expr for the polygon without the actual polygon points. This breaks the footprint and board.
2018-04-02 17:02:47 +00:00
else
{
wxFAIL_MSG( wxT( "Cannot format invalid polygon." ) );
return;
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_CURVE: // Bezier curve
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, "(gr_curve (pts (xy %s) (xy %s) (xy %s) (xy %s))",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aSegment->GetStart() ).c_str(),
FormatInternalUnits( aSegment->GetBezControl1() ).c_str(),
FormatInternalUnits( aSegment->GetBezControl2() ).c_str(),
FormatInternalUnits( aSegment->GetEnd() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
default:
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
wxFAIL_MSG( wxT( "Cannot format invalid DRAWSEGMENT type." ) );
Don't save broken polygon If a polygon has fewer than 3 points, it is invalid. We need to register this as failure, otherwise we save the formatting/closing s-expr for the polygon without the actual polygon points. This breaks the footprint and board.
2018-04-02 17:02:47 +00:00
return;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
};
formatLayer( aSegment );
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (width %s)", FormatInternalUnits( aSegment->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aSegment->GetTimeStamp() )
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long)aSegment->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aSegment->GetStatus() )
m_out->Print( 0, " (status %X)", aSegment->GetStatus() );
m_out->Print( 0, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( EDGE_MODULE* aModuleDrawing, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aModuleDrawing->GetShape() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
case S_SEGMENT: // Line
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(fp_line (start %s) (end %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModuleDrawing->GetStart0() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetEnd0() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_CIRCLE: // Circle
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(fp_circle (center %s) (end %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModuleDrawing->GetStart0() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetEnd0() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_ARC: // Arc
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(fp_arc (start %s) (end %s) (angle %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModuleDrawing->GetStart0() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetEnd0() ).c_str(),
FormatAngle( aModuleDrawing->GetAngle() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
case S_POLYGON: // Polygonal segment
if( aModuleDrawing->IsPolyShapeValid() )
fixes for plugins
2012-08-11 05:50:17 +00:00
{
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
SHAPE_POLY_SET& poly = aModuleDrawing->GetPolyShape();
SHAPE_LINE_CHAIN& outline = poly.Outline( 0 );
int pointsCount = outline.PointCount();
m_out->Print( aNestLevel, "(fp_poly (pts" );
fixes for plugins
2012-08-11 05:50:17 +00:00
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
for( int ii = 0; ii < pointsCount; ++ii )
fixes for plugins
2012-08-11 05:50:17 +00:00
{
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
int nestLevel = 0;
if( ii && !( ii%4 ) ) // newline every 4 pts
{
nestLevel = aNestLevel + 1;
m_out->Print( 0, "\n" );
}
m_out->Print( nestLevel, "%s(xy %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
nestLevel ? "" : " ", FormatInternalUnits( outline.CPoint( ii ) ).c_str() );
fixes for plugins
2012-08-11 05:50:17 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
DRAWSEGMENT, S_POLYGON shape: remove useless copies or conversion to std::vector<wxPoint> of SHPE_POLY_SET polygon shape. Rename GetPolyPoint() to BuildPolyPointsList(), because GetPolyPoint() looks like an accessor, but it is not an accessor. (Using it as accessor can creates a *very long calculation time* for very basic access to polygon vertices) Fixes: lp:1745050 https://bugs.launchpad.net/kicad/+bug/1745050
2018-01-24 13:22:43 +00:00
m_out->Print( 0, ")" );
fixes for plugins
2012-08-11 05:50:17 +00:00
}
Don't save broken polygon If a polygon has fewer than 3 points, it is invalid. We need to register this as failure, otherwise we save the formatting/closing s-expr for the polygon without the actual polygon points. This breaks the footprint and board.
2018-04-02 17:02:47 +00:00
else
{
wxFAIL_MSG( wxT( "Cannot format invalid polygon." ) );
return;
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
case S_CURVE: // Bezier curve
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, "(fp_curve (pts (xy %s) (xy %s) (xy %s) (xy %s))",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModuleDrawing->GetStart0() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetBezier0_C1() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetBezier0_C2() ).c_str(),
FormatInternalUnits( aModuleDrawing->GetEnd0() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
break;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
default:
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
wxFAIL_MSG( wxT( "Cannot format invalid DRAWSEGMENT type." ) );
Don't save broken polygon If a polygon has fewer than 3 points, it is invalid. We need to register this as failure, otherwise we save the formatting/closing s-expr for the polygon without the actual polygon points. This breaks the footprint and board.
2018-04-02 17:02:47 +00:00
return;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
};
formatLayer( aModuleDrawing );
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (width %s)", FormatInternalUnits( aModuleDrawing->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( PCB_TARGET* aTarget, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
m_out->Print( aNestLevel, "(target %s (at %s) (size %s)",
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
( aTarget->GetShape() ) ? "x" : "plus",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aTarget->GetPosition() ).c_str(),
FormatInternalUnits( aTarget->GetSize() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aTarget->GetWidth() != 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (width %s)", FormatInternalUnits( aTarget->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
formatLayer( aTarget );
if( aTarget->GetTimeStamp() )
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long)aTarget->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
m_out->Print( 0, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( MODULE* aModule, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( !( m_ctl & CTL_OMIT_INITIAL_COMMENTS ) )
Support for 'initial single line comments' in the pretty footprint format. This is limited to round tripping the lines of commented text in the loading and saving to disk through PCBIO::Format() and PCBIO::Parse(). No editing of the comments is given.
2013-06-23 19:18:33 +00:00
{
add CTL_OMIT_INITIAL_COMMENTS and CTL_FOR_BOARD PCB_IO::Format()ing flags
2013-06-24 05:30:22 +00:00
const wxArrayString* initial_comments = aModule->GetInitialComments();
if( initial_comments )
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( unsigned i=0; i<initial_comments->GetCount(); ++i )
m_out->Print( aNestLevel, "%s\n", TO_UTF8( (*initial_comments)[i] ) );
add CTL_OMIT_INITIAL_COMMENTS and CTL_FOR_BOARD PCB_IO::Format()ing flags
2013-06-24 05:30:22 +00:00
m_out->Print( 0, "\n" ); // improve readability?
}
Support for 'initial single line comments' in the pretty footprint format. This is limited to round tripping the lines of commented text in the loading and saving to disk through PCBIO::Format() and PCBIO::Parse(). No editing of the comments is given.
2013-06-23 19:18:33 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel, "(module %s",
m_out->Quotes( aModule->GetFPID().Format() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->IsLocked() )
FIX: removed unwanted indent in *.kicad_pcb files ahead of "placed" and "locked"
2013-08-08 16:09:49 +00:00
m_out->Print( 0, " locked" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->IsPlaced() )
FIX: removed unwanted indent in *.kicad_pcb files ahead of "placed" and "locked"
2013-08-08 16:09:49 +00:00
m_out->Print( 0, " placed" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
formatLayer( aModule );
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tedit %lX)", (unsigned long)aModule->GetLastEditTime() );
.kicad_mod files: always save the "last edited date" because only the footprint editor changes this parameter. Usefull to know if/when a footprint was actually modified. Also fix a minor issue in footprint editor which always set the "modified" flag even when no change was made.
2014-06-02 10:46:29 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( !( m_ctl & CTL_OMIT_TSTAMPS ) )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)\n", (unsigned long)aModule->GetTimeStamp() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
else
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
m_out->Print( 0, "\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( !( m_ctl & CTL_OMIT_AT ) )
*.kicad_mod omits (at 0 0) for brevity.
2013-11-28 16:40:23 +00:00
{
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( aNestLevel+1, "(at %s", FormatInternalUnits( aModule->GetPosition() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
*.kicad_mod omits (at 0 0) for brevity.
2013-11-28 16:40:23 +00:00
if( aModule->GetOrientation() != 0.0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatAngle( aModule->GetOrientation() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
*.kicad_mod omits (at 0 0) for brevity.
2013-11-28 16:40:23 +00:00
m_out->Print( 0, ")\n" );
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( !aModule->GetDescription().IsEmpty() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(descr %s)\n",
m_out->Quotew( aModule->GetDescription() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( !aModule->GetKeywords().IsEmpty() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(tags %s)\n",
m_out->Quotew( aModule->GetKeywords() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( !( m_ctl & CTL_OMIT_PATH ) && !!aModule->GetPath() )
m_out->Print( aNestLevel+1, "(path %s)\n",
m_out->Quotew( aModule->GetPath() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetPlacementCost90() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(autoplace_cost90 %d)\n", aModule->GetPlacementCost90() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetPlacementCost180() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(autoplace_cost180 %d)\n", aModule->GetPlacementCost180() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->GetLocalSolderMaskMargin() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(solder_mask_margin %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModule->GetLocalSolderMaskMargin() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->GetLocalSolderPasteMargin() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(solder_paste_margin %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModule->GetLocalSolderPasteMargin() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->GetLocalSolderPasteMarginRatio() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(solder_paste_ratio %s)\n",
Double2Str( aModule->GetLocalSolderPasteMarginRatio() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aModule->GetLocalClearance() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(clearance %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModule->GetLocalClearance() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
if( aModule->GetZoneConnection() != PAD_ZONE_CONN_INHERITED )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(zone_connect %d)\n", aModule->GetZoneConnection() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetThermalWidth() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(thermal_width %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModule->GetThermalWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetThermalGap() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(thermal_gap %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aModule->GetThermalGap() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
// Attributes
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetAttributes() != MOD_DEFAULT )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(attr" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetAttributes() & MOD_CMS )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, " smd" );
Pcbnew encapsulation and code cleaning. * Encapsulate most of the MODULE class. * Start encapsulating the DIMENSION class. * Lay some groundwork for EDA_TEXT encapsulation. * Move cleverly hidden MODULE functions into class_module.cpp. * Use std::swap to exchange TEXTE_PCB values for undo/redo. * Remove unused members from MODULE class. * The usual coding policy and documentation fixes.
2013-03-13 18:53:58 +00:00
if( aModule->GetAttributes() & MOD_VIRTUAL )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, " virtual" );
m_out->Print( 0, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Format( (BOARD_ITEM*) &aModule->Reference(), aNestLevel+1 );
Format( (BOARD_ITEM*) &aModule->Value(), aNestLevel+1 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save drawing elements.
further DLIST/Iterators cleanup, some code formatting
2017-04-25 09:06:24 +00:00
for( BOARD_ITEM* gr = aModule->GraphicalItemsList(); gr; gr = gr->Next() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Format( gr, aNestLevel+1 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save pads.
further DLIST/Iterators cleanup, some code formatting
2017-04-25 09:06:24 +00:00
for( D_PAD* pad = aModule->PadsList(); pad; pad = pad->Next() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
format( pad, aNestLevel+1 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save 3D info.
refactoring: removed dependency of libpcbcommon on 3d-viewer.
2017-10-27 14:25:20 +00:00
auto bs3D = aModule->Models().begin();
auto es3D = aModule->Models().end();
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
while( bs3D != es3D )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
if( !bs3D->m_Filename.IsEmpty() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(model %s\n",
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
m_out->Quotew( bs3D->m_Filename ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
CHANGE file format for 3D model offset - Reverts behaviour of 3e71ed2421f5df433c11a554e0756f6898e25b06 - 3D model offset now explicitly written in mm, using "offset" tag - Any read "at" tag is converted from inches to mm - This will not break any 3D model offset when reading files - It will however render files incompatible with old versions
2017-11-23 10:21:48 +00:00
/* Write 3D model offset in mm
* 4.0.x wrote "at" which was actually in inches
Decode "offset" in STEP export tool - Read "at" as inches - Read "offset" as mm
2017-11-26 21:20:02 +00:00
* 5.0.x onwards, 3D model offset is written using "offset"
Write "offset" only if non-zero - Use "at" if all offset dimensions are zero - Use "offset" otherwise
2017-11-27 10:46:53 +00:00
*
* If the offset is all zero, write "at" (fewer file changes)
* Otherwise, write "offset"
CHANGE file format for 3D model offset - Reverts behaviour of 3e71ed2421f5df433c11a554e0756f6898e25b06 - 3D model offset now explicitly written in mm, using "offset" tag - Any read "at" tag is converted from inches to mm - This will not break any 3D model offset when reading files - It will however render files incompatible with old versions
2017-11-23 10:21:48 +00:00
*/
Decode "offset" in STEP export tool - Read "at" as inches - Read "offset" as mm
2017-11-26 21:20:02 +00:00
Write "offset" only if non-zero - Use "at" if all offset dimensions are zero - Use "offset" otherwise
2017-11-27 10:46:53 +00:00
wxString offsetTag = "offset";
if( bs3D->m_Offset.x == 0 &&
bs3D->m_Offset.y == 0 &&
bs3D->m_Offset.z == 0 )
{
offsetTag = "at";
}
m_out->Print( aNestLevel+2, "(%s (xyz %s %s %s))\n",
offsetTag.ToStdString().c_str(),
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
Double2Str( bs3D->m_Offset.x ).c_str(),
Double2Str( bs3D->m_Offset.y ).c_str(),
Double2Str( bs3D->m_Offset.z ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+2, "(scale (xyz %s %s %s))\n",
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
Double2Str( bs3D->m_Scale.x ).c_str(),
Double2Str( bs3D->m_Scale.y ).c_str(),
Double2Str( bs3D->m_Scale.z ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+2, "(rotate (xyz %s %s %s))\n",
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
Double2Str( bs3D->m_Rotation.x ).c_str(),
Double2Str( bs3D->m_Rotation.y ).c_str(),
Double2Str( bs3D->m_Rotation.z ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
++bs3D;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
m_out->Print( aNestLevel, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
void PCB_IO::formatLayers( LSET aLayerMask, int aNestLevel ) const
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
std::string output;
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
if( aNestLevel == 0 )
output += ' ';
output += "(layers";
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
static const LSET cu_all( LSET::AllCuMask() );
static const LSET fr_bk( 2, B_Cu, F_Cu );
static const LSET adhes( 2, B_Adhes, F_Adhes );
static const LSET paste( 2, B_Paste, F_Paste );
static const LSET silks( 2, B_SilkS, F_SilkS );
static const LSET mask( 2, B_Mask, F_Mask );
static const LSET crt_yd(2, B_CrtYd, F_CrtYd );
static const LSET fab( 2, B_Fab, F_Fab );
LSET cu_mask = cu_all;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
// output copper layers first, then non copper
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( ( aLayerMask & cu_mask ) == cu_mask )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " *.Cu";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~cu_all; // clear bits, so they are not output again below
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
else if( ( aLayerMask & cu_mask ) == fr_bk )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " F&B.Cu";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~fr_bk;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( ( aLayerMask & adhes ) == adhes )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " *.Adhes";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~adhes;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( ( aLayerMask & paste ) == paste )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " *.Paste";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~paste;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( ( aLayerMask & silks ) == silks )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " *.SilkS";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~silks;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( ( aLayerMask & mask ) == mask )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += " *.Mask";
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
aLayerMask &= ~mask;
}
if( ( aLayerMask & crt_yd ) == crt_yd )
{
output += " *.CrtYd";
aLayerMask &= ~crt_yd;
}
if( ( aLayerMask & fab ) == fab )
{
output += " *.Fab";
aLayerMask &= ~fab;
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
// output any individual layers not handled in wildcard combos above
wxString layerName;
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
for( LAYER_NUM layer = 0; layer < PCB_LAYER_ID_COUNT; ++layer )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( aLayerMask[layer] )
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( m_board && !( m_ctl & CTL_STD_LAYER_NAMES ) )
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
layerName = m_board->GetLayerName( PCB_LAYER_ID( layer ) );
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
else // I am being called from FootprintSave()
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
layerName = BOARD::GetStandardLayerName( PCB_LAYER_ID( layer ) );
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
output += ' ';
output += m_out->Quotew( layerName );
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
}
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
m_out->Print( aNestLevel, "%s)", output.c_str() );
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( D_PAD* aPad, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
fix ownership issue in wxFFile vs. FILE_LINE_READER
2012-10-24 18:42:39 +00:00
const char* shape;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aPad->GetShape() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
case PAD_SHAPE_CIRCLE: shape = "circle"; break;
case PAD_SHAPE_RECT: shape = "rect"; break;
case PAD_SHAPE_OVAL: shape = "oval"; break;
case PAD_SHAPE_TRAPEZOID: shape = "trapezoid"; break;
case PAD_SHAPE_ROUNDRECT: shape = "roundrect"; break;
case PAD_SHAPE_CUSTOM: shape = "custom"; break;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
default:
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
THROW_IO_ERROR( wxString::Format( _( "unknown pad type: %d"), aPad->GetShape() ) );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
fix ownership issue in wxFFile vs. FILE_LINE_READER
2012-10-24 18:42:39 +00:00
const char* type;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aPad->GetAttribute() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Rework on Enum PAD_SHAPE_T, PAD_DRILL_SHAPE_T and PAD_ATTR_T (see rev 6008) : the new and better names are now used in Kicad code and existing python scripts. PAD_SHAPE_T and PAD_ATTR_T still have a double definition (new names and old names) to be sure python scripts are nor broken by the change. PAD_DRILL_SHAPE_T does not have a double definition, because it is unlikely oblong holes are used in python scripts. Double definitions will be removed in the (next) future.
2015-08-23 19:40:33 +00:00
case PAD_ATTRIB_STANDARD: type = "thru_hole"; break;
case PAD_ATTRIB_SMD: type = "smd"; break;
case PAD_ATTRIB_CONN: type = "connect"; break;
case PAD_ATTRIB_HOLE_NOT_PLATED: type = "np_thru_hole"; break;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
default:
Fix a few I18n minor issues.
2018-11-16 08:43:40 +00:00
THROW_IO_ERROR( wxString::Format( "unknown pad attribute: %d", aPad->GetAttribute() ) );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel, "(pad %s %s %s",
Renamed D_PAD::{Set,Get}PadName() to D_PAD::{Set,Get}Name()
2017-08-11 09:22:13 +00:00
m_out->Quotew( aPad->GetName() ).c_str(),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
type, shape );
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (at %s", FormatInternalUnits( aPad->GetPos0() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetOrientation() != 0.0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatAngle( aPad->GetOrientation() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
m_out->Print( 0, ")" );
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (size %s)", FormatInternalUnits( aPad->GetSize() ).c_str() );
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( (aPad->GetDelta().GetWidth()) != 0 || (aPad->GetDelta().GetHeight() != 0 ) )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (rect_delta %s )", FormatInternalUnits( aPad->GetDelta() ).c_str() );
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
wxSize sz = aPad->GetDrillSize();
Pcbnew: fix Bug #1167364 pcb_calculator: fix bug Bug #1167345
2013-04-10 19:20:35 +00:00
wxPoint shapeoffset = aPad->GetOffset();
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( (sz.GetWidth() > 0) || (sz.GetHeight() > 0) ||
(shapeoffset.x != 0) || (shapeoffset.y != 0) )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " (drill" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Rework on Enum PAD_SHAPE_T, PAD_DRILL_SHAPE_T and PAD_ATTR_T (see rev 6008) : the new and better names are now used in Kicad code and existing python scripts. PAD_SHAPE_T and PAD_ATTR_T still have a double definition (new names and old names) to be sure python scripts are nor broken by the change. PAD_DRILL_SHAPE_T does not have a double definition, because it is unlikely oblong holes are used in python scripts. Double definitions will be removed in the (next) future.
2015-08-23 19:40:33 +00:00
if( aPad->GetDrillShape() == PAD_DRILL_SHAPE_OBLONG )
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
m_out->Print( 0, " oval" );
Minor Pcbnew s-expression improvements. * Put text effects on a single line. * Remove size token when defining drill sizes. * Don't save net in pad definition when pad has no connection.
2012-06-24 01:19:41 +00:00
if( sz.GetWidth() > 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatInternalUnits( sz.GetWidth() ).c_str() );
Minor Pcbnew s-expression improvements. * Put text effects on a single line. * Remove size token when defining drill sizes. * Don't save net in pad definition when pad has no connection.
2012-06-24 01:19:41 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( sz.GetHeight() > 0 && sz.GetWidth() != sz.GetHeight() )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatInternalUnits( sz.GetHeight() ).c_str() );
Pcbnew s-expression file parser bug fixes. * Change save order of drawings to match legacy file format object order. * Set end point of SEGVIA to start point so the round trip back to legacy format is the same. * Fixed bug saving and loading oval pad drill parameters. * Fixed bug saving and loading rectangular pad deltas. * Fixed missing layer for PCB_TARGET. * Fixed EDA_TEXT italic bug. Thanks Dick! * Remove some left over debug logging statements.
2012-06-13 23:04:42 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( (shapeoffset.x != 0) || (shapeoffset.y != 0) )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (offset %s)", FormatInternalUnits( aPad->GetOffset() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, ")" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Save layers regardless of view We do not modify the underlying board when saving. Previously only the visible layers were saved. This created a discrepancy between the board that the user was editing and the board that was saved to disk. Fixes: lp:1754049 * https://bugs.launchpad.net/kicad/+bug/1754049
2018-03-23 16:31:11 +00:00
formatLayers( aPad->GetLayerSet() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: Add rounded rect pad shape.
2016-04-06 18:15:49 +00:00
// Output the radius ratio for rounded rect pads
if( aPad->GetShape() == PAD_SHAPE_ROUNDRECT )
{
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
m_out->Print( 0, " (roundrect_rratio %s)",
Pcbnew: Add rounded rect pad shape.
2016-04-06 18:15:49 +00:00
Double2Str( aPad->GetRoundRectRadiusRatio() ).c_str() );
}
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
std::string output;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Minor Pcbnew s-expression improvements. * Put text effects on a single line. * Remove size token when defining drill sizes. * Don't save net in pad definition when pad has no connection.
2012-06-24 01:19:41 +00:00
// Unconnected pad is default net so don't save it.
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( !( m_ctl & CTL_OMIT_NETS ) && aPad->GetNetCode() != NETINFO_LIST::UNCONNECTED )
Renamed BOARD_CONNECTED_ITEM::GetNet() -> GetNetCode() Renamed BOARD_CONNECTED_ITEM::SetNet() -> SetNetCode() Added BOARD_CONNECTED_ITEM::GetNet() for accessing NETINFO_ITEM* of a given item. Fixed module editor crash when launched to edit a module from a PCB. Replaced some BOARD::FindNet( item->GetNet() ) calls with BOARD_CONNECTED_ITEM::GetNet().
2014-02-25 10:47:27 +00:00
StrPrintf( &output, " (net %d %s)", m_mapping->Translate( aPad->GetNetCode() ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Quotew( aPad->GetNetname() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: fix Bug #1089120. Also change "Length Die" expression to "Length Pad To Die" in code
2012-12-12 11:57:17 +00:00
if( aPad->GetPadToDieLength() != 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
StrPrintf( &output, " (die_length %s)", FormatInternalUnits( aPad->GetPadToDieLength() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetLocalSolderMaskMargin() != 0 )
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
StrPrintf( &output, " (solder_mask_margin %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aPad->GetLocalSolderMaskMargin() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetLocalSolderPasteMargin() != 0 )
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
StrPrintf( &output, " (solder_paste_margin %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aPad->GetLocalSolderPasteMargin() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetLocalSolderPasteMarginRatio() != 0 )
comment/doc cleanups
2013-09-26 15:02:46 +00:00
StrPrintf( &output, " (solder_paste_margin_ratio %s)",
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
Double2Str( aPad->GetLocalSolderPasteMarginRatio() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetLocalClearance() != 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
StrPrintf( &output, " (clearance %s)", FormatInternalUnits( aPad->GetLocalClearance() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
if( aPad->GetZoneConnection() != PAD_ZONE_CONN_INHERITED )
comment/doc cleanups
2013-09-26 15:02:46 +00:00
StrPrintf( &output, " (zone_connect %d)", aPad->GetZoneConnection() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetThermalWidth() != 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
StrPrintf( &output, " (thermal_width %s)", FormatInternalUnits( aPad->GetThermalWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aPad->GetThermalGap() != 0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
StrPrintf( &output, " (thermal_gap %s)", FormatInternalUnits( aPad->GetThermalGap() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
if( output.size() )
{
m_out->Print( 0, "\n" );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "%s", output.c_str()+1 ); // +1 skips 1st space on 1st element
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
}
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
if( aPad->GetShape() == PAD_SHAPE_CUSTOM )
{
m_out->Print( 0, "\n");
m_out->Print( aNestLevel+1, "(options" );
if( aPad->GetCustomShapeInZoneOpt() == CUST_PAD_SHAPE_IN_ZONE_CONVEXHULL )
m_out->Print( 0, " (clearance convexhull)" );
#if 1 // Set to 1 to output the default option
else
m_out->Print( 0, " (clearance outline)" );
#endif
// Output the anchor pad shape (circle/rect)
if( aPad->GetAnchorPadShape() == PAD_SHAPE_RECT )
shape = "rect";
else
shape = "circle";
m_out->Print( 0, " (anchor %s)", shape );
m_out->Print( 0, ")"); // end of (options ...
// Output graphic primitive of the pad shape
m_out->Print( 0, "\n");
m_out->Print( aNestLevel+1, "(primitives" );
int nested_level = aNestLevel+2;
// Output all basic shapes
replace "BasicShape" by "Primitive" in code, a better name
2017-09-20 08:28:52 +00:00
for( unsigned icnt = 0; icnt < aPad->GetPrimitives().size(); ++icnt )
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
{
m_out->Print( 0, "\n");
replace "BasicShape" by "Primitive" in code, a better name
2017-09-20 08:28:52 +00:00
const PAD_CS_PRIMITIVE& primitive = aPad->GetPrimitives()[icnt];
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
switch( primitive.m_Shape )
{
case S_SEGMENT: // usual segment : line with rounded ends
m_out->Print( nested_level, "(gr_line (start %s) (end %s) (width %s))",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( primitive.m_Start ).c_str(),
FormatInternalUnits( primitive.m_End ).c_str(),
FormatInternalUnits( primitive.m_Thickness ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
break;
case S_ARC: // Arc with rounded ends
m_out->Print( nested_level, "(gr_arc (start %s) (end %s) (angle %s) (width %s))",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( primitive.m_Start ).c_str(),
FormatInternalUnits( primitive.m_End ).c_str(),
FormatAngle( primitive.m_ArcAngle ).c_str(),
FormatInternalUnits( primitive.m_Thickness ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
break;
case S_CIRCLE: // ring or circle (circle if width == 0
m_out->Print( nested_level, "(gr_circle (center %s) (end %s %s) (width %s))",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( primitive.m_Start ).c_str(),
FormatInternalUnits( primitive.m_Start.x + primitive.m_Radius ).c_str(),
FormatInternalUnits( primitive.m_Start.y ).c_str(),
FormatInternalUnits( primitive.m_Thickness ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
break;
case S_POLYGON: // polygon
if( primitive.m_Poly.size() < 2 )
break; // Malformed polygon.
{
m_out->Print( nested_level, "(gr_poly (pts\n");
// Write the polygon corners coordinates:
const std::vector< wxPoint>& poly = primitive.m_Poly;
int newLine = 0;
for( unsigned ii = 0; ii < poly.size(); ii++ )
{
if( newLine == 0 )
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
m_out->Print( nested_level+1, " (xy %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( wxPoint( poly[ii].x, poly[ii].y ) ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
else
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
m_out->Print( 0, " (xy %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( wxPoint( poly[ii].x, poly[ii].y ) ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
if( ++newLine > 4 )
{
newLine = 0;
m_out->Print( 0, "\n" );
}
}
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, ") (width %s))", FormatInternalUnits( primitive.m_Thickness ).c_str() );
Add support for custom pad shape. Full support in DRC and PnS. add option to use shape or convex hull as clearance area in zones. simplify code to handle clearance area
2017-01-13 17:51:22 +00:00
}
break;
default:
break;
}
}
m_out->Print( 0, "\n");
m_out->Print( aNestLevel+1, ")" ); // end of (basic_shapes
}
Make pretty prettier by striving for single line module pads. Add slick std::string based strprintf(), twice.
2013-09-26 05:29:54 +00:00
m_out->Print( 0, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( TEXTE_PCB* aText, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel, "(gr_text %s (at %s",
m_out->Quotew( aText->GetText() ).c_str(),
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aText->GetTextPos() ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
EDA_TEXT object refactor. Make all EDA_TEXT data private and rename accessors to avoid function name collisions in derived classes. Overload EDA_TEXT's SetTextAngle() and SetEffects() in TEXTE_PCB. Add support for preserving Reference text position, size, orientation during a netlist import into a BOARD, as well as the one off footprint update dialog.
2017-01-23 20:30:11 +00:00
if( aText->GetTextAngle() != 0.0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatAngle( aText->GetTextAngle() ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, ")" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
formatLayer( aText );
if( aText->GetTimeStamp() )
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long)aText->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, "\n" );
aText->EDA_TEXT::Format( m_out, aNestLevel, m_ctl );
m_out->Print( aNestLevel, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( TEXTE_MODULE* aText, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
wxString type;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aText->GetType() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
EDA_TEXT object refactor. Make all EDA_TEXT data private and rename accessors to avoid function name collisions in derived classes. Overload EDA_TEXT's SetTextAngle() and SetEffects() in TEXTE_PCB. Add support for preserving Reference text position, size, orientation during a netlist import into a BOARD, as well as the one off footprint update dialog.
2017-01-23 20:30:11 +00:00
case TEXTE_MODULE::TEXT_is_REFERENCE: type = "reference"; break;
case TEXTE_MODULE::TEXT_is_VALUE: type = "value"; break;
case TEXTE_MODULE::TEXT_is_DIVERS: type = "user";
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel, "(fp_text %s %s (at %s",
m_out->Quotew( type ).c_str(),
m_out->Quotew( aText->GetText() ).c_str(),
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aText->GetPos0() ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
EDA_TEXT object refactor. Make all EDA_TEXT data private and rename accessors to avoid function name collisions in derived classes. Overload EDA_TEXT's SetTextAngle() and SetEffects() in TEXTE_PCB. Add support for preserving Reference text position, size, orientation during a netlist import into a BOARD, as well as the one off footprint update dialog.
2017-01-23 20:30:11 +00:00
// Due to Pcbnew history, fp_text angle is saved as an absolute on screen angle,
// but internally the angle is held relative to its parent footprint. parent
// may be NULL when saving a footprint outside a BOARD.
double orient = aText->GetTextAngle();
MODULE* parent = (MODULE*) aText->GetParent();
if( parent )
{
// GetTextAngle() is always in -360..+360 range because of
// TEXTE_MODULE::SetTextAngle(), but summing that angle with an
// additional board angle could kick sum up >= 360 or <= -360, so to have
// consistent results, normalize again for the BOARD save. A footprint
// save does not use this code path since parent is NULL.
#if 0
// This one could be considered reasonable if you like positive angles
// in your board text.
orient = NormalizeAnglePos( orient + parent->GetOrientation() );
#else
// Choose compatibility for now, even though this is only a 720 degree clamp
// with two possible values for every angle.
Pcbnew: fix issues with 360 deg angle arcs. Fixes: lp:1725943 https://bugs.launchpad.net/kicad/+bug/1725943
2017-10-23 13:35:03 +00:00
orient = NormalizeAngle360Min( orient + parent->GetOrientation() );
EDA_TEXT object refactor. Make all EDA_TEXT data private and rename accessors to avoid function name collisions in derived classes. Overload EDA_TEXT's SetTextAngle() and SetEffects() in TEXTE_PCB. Add support for preserving Reference text position, size, orientation during a netlist import into a BOARD, as well as the one off footprint update dialog.
2017-01-23 20:30:11 +00:00
#endif
}
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( orient != 0.0 )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " %s", FormatAngle( orient ).c_str() );
Commit Dick's Pcbnew s-expression file parser bug fixes. * Apply Dick's patch along with a few minor changes to fix some clashes with changes in my branch. Thanks Dick! * Added missing DRAWSEGMENT line angle. * Fix thru hole pad layer mask issue.
2012-06-11 00:47:15 +00:00
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
if( !aText->IsKeepUpright() )
Add "unlock" property to footprint texts This property decouples the text orientation from the board orientation, removing the restriction that it face the bottom or right side of the board.
2017-11-25 19:55:32 +00:00
m_out->Print( 0, " unlocked" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, ")" );
Commit Dick's Pcbnew s-expression file parser bug fixes. * Apply Dick's patch along with a few minor changes to fix some clashes with changes in my branch. Thanks Dick! * Added missing DRAWSEGMENT line angle. * Fix thru hole pad layer mask issue.
2012-06-11 00:47:15 +00:00
formatLayer( aText );
if( !aText->IsVisible() )
m_out->Print( 0, " hide" );
m_out->Print( 0, "\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Move "hide" back to prior fp_text location
2017-01-27 21:44:41 +00:00
aText->EDA_TEXT::Format( m_out, aNestLevel, m_ctl | CTL_OMIT_HIDE );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( TRACK* aTrack, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
if( aTrack->Type() == PCB_VIA_T )
{
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
PCB_LAYER_ID layer1, layer2;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
pcbnew: copy/paste code cleanup & formatting
2017-09-29 09:44:05 +00:00
const VIA* via = static_cast<const VIA*>( aTrack );
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
BOARD* board = (BOARD*) via->GetParent();
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Remove global units usage from GetSelectionText... ... and GetMsgPanelInfo. Step 4 in the g_UserUnit eradication effort. Also removes a couple of conversion routines that were close enough to extinction. (cherry picked from commit c75da51)
2018-04-10 10:52:12 +00:00
wxCHECK_RET( board != 0, wxT( "Via " ) + via->GetSelectMenuText( MILLIMETRES ) +
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
wxT( " has no parent." ) );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( aNestLevel, "(via" );
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
via->LayerPair( &layer1, &layer2 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( via->GetViaType() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
case VIA_THROUGH: // Default shape not saved.
break;
case VIA_BLIND_BURIED:
m_out->Print( 0, " blind" );
break;
case VIA_MICROVIA:
m_out->Print( 0, " micro" );
break;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
default:
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
THROW_IO_ERROR( wxString::Format( _( "unknown via type %d" ), via->GetViaType() ) );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " (at %s) (size %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aTrack->GetStart() ).c_str(),
FormatInternalUnits( aTrack->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
TRACK/SEGVIA cleanup - SEGVIA becomes VIA - Drill size moved from TRACK to VIA - Removed shape from TRACK, becomes ViaType in VIA - GetTrace becomes GetTrack, for uniformity - Some minor constification and typo fixes
2014-04-25 06:00:04 +00:00
if( via->GetDrill() != UNDEFINED_DRILL_DIAMETER )
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
m_out->Print( 0, " (drill %s)", FormatInternalUnits( via->GetDrill() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, " (layers %s %s)",
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Quotew( m_board->GetLayerName( layer1 ) ).c_str(),
m_out->Quotew( m_board->GetLayerName( layer2 ) ).c_str() );
}
else
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
m_out->Print( aNestLevel, "(segment (start %s) (end %s) (width %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aTrack->GetStart() ).c_str(), FormatInternalUnits( aTrack->GetEnd() ).c_str(),
FormatInternalUnits( aTrack->GetWidth() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, " (layer %s)", m_out->Quotew( aTrack->GetLayerName() ).c_str() );
}
Renamed BOARD_CONNECTED_ITEM::GetNet() -> GetNetCode() Renamed BOARD_CONNECTED_ITEM::SetNet() -> SetNetCode() Added BOARD_CONNECTED_ITEM::GetNet() for accessing NETINFO_ITEM* of a given item. Fixed module editor crash when launched to edit a module from a PCB. Replaced some BOARD::FindNet( item->GetNet() ) calls with BOARD_CONNECTED_ITEM::GetNet().
2014-02-25 10:47:27 +00:00
m_out->Print( 0, " (net %d)", m_mapping->Translate( aTrack->GetNetCode() ) );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aTrack->GetTimeStamp() != 0 )
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long)aTrack->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aTrack->GetStatus() != 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( 0, " (status %X)", aTrack->GetStatus() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( 0, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
void PCB_IO::format( ZONE_CONTAINER* aZone, int aNestLevel ) const
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Eeschema: fix broken mirroring for texts and labels in block mirror X and Y (this fixes Bug #1135505) Pcbnew: add in module popup menu an option to edit the footprint in Modedit (like in Eeschema for components) minor icons enhancements.
2013-03-01 19:59:29 +00:00
// Save the NET info; For keepout zones, net code and net name are irrelevant
// so be sure a dummy value is stored, just for ZONE_CONTAINER compatibility
// (perhaps netcode and netname should be not stored)
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out->Print( aNestLevel, "(zone (net %d) (net_name %s)",
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aZone->GetIsKeepout() ? 0 : m_mapping->Translate( aZone->GetNetCode() ),
m_out->Quotew( aZone->GetIsKeepout() ? wxT("") : aZone->GetNetname() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
pcbnew: code formatting, removed previous module editor copy/paste functions
2017-09-29 09:40:10 +00:00
// If a zone exists on multiple layers, format accordingly
if( aZone->GetLayerSet().count() > 1 )
{
formatLayers( aZone->GetLayerSet() );
}
else
{
formatLayer( aZone );
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: fix board I/O plugin formatter build warnings. Internally time stamps are defined as unsigned long. On some platforms, time_t is defined as unsigned long long. Cast all time_t instances to unsigned long to prevent the compiler from complaining.
2016-09-24 15:53:22 +00:00
m_out->Print( 0, " (tstamp %lX)", (unsigned long) aZone->GetTimeStamp() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
// Save the outline aux info
std::string hatch;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aZone->GetHatchStyle() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
default:
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
case ZONE_CONTAINER::NO_HATCH: hatch = "none"; break;
case ZONE_CONTAINER::DIAGONAL_EDGE: hatch = "edge"; break;
case ZONE_CONTAINER::DIAGONAL_FULL: hatch = "full"; break;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
m_out->Print( 0, " (hatch %s %s)\n", hatch.c_str(),
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aZone->GetHatchPitch() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( aZone->GetPriority() > 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(priority %d)\n", aZone->GetPriority() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(connect_pads" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aZone->GetPadConnection() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
default:
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
case PAD_ZONE_CONN_THERMAL: // Default option not saved or loaded.
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
break;
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
case PAD_ZONE_CONN_THT_THERMAL:
Pcbnew: commit Lorenzo Marcantonio's patch for THT thermals (added loading/saving using S. expr). Fix incorrect import of smd pads from Gpcb. Very minor change in dialog print.
2012-07-09 07:10:07 +00:00
m_out->Print( 0, " thru_hole_only" );
break;
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
case PAD_ZONE_CONN_FULL:
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " yes" );
break;
* Python scripting: brings pad.GetZoneConnection() and in example pad.SetZoneConnection(pcbnew.PAD_ZONE_CONN_FULL) to full workable. * Cleanup namespace in enum ZoneConnection in pcbnew/zones.h to self-explained names unification: PAD_ZONE_CONN_INHERITED, PAD_ZONE_CONN_NONE,PAD_ZONE_CONN_THERMAL,PAD_ZONE_CONN_FULL, PAD_ZONE_CONN_THT_THERMAL
2015-08-18 14:19:17 +00:00
case PAD_ZONE_CONN_NONE:
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " no" );
break;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " (clearance %s))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aZone->GetZoneClearance() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(min_thickness %s)\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aZone->GetMinThickness() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: Add keepout areas (Copper zones without tracks or/and vias). This is *a work in progress*, so some features are missing, and/or could be modified. Mainly keepout zones are not yet exported to autorouters, and pads are not taken in account. Some code cleanup in polygon.*
2012-07-13 18:55:29 +00:00
if( aZone->GetIsKeepout() )
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(keepout (tracks %s) (vias %s) (copperpour %s))\n",
aZone->GetDoNotAllowTracks() ? "not_allowed" : "allowed",
aZone->GetDoNotAllowVias() ? "not_allowed" : "allowed",
aZone->GetDoNotAllowCopperPour() ? "not_allowed" : "allowed" );
Pcbnew: Add keepout areas (Copper zones without tracks or/and vias). This is *a work in progress*, so some features are missing, and/or could be modified. Mainly keepout zones are not yet exported to autorouters, and pads are not taken in account. Some code cleanup in polygon.*
2012-07-13 18:55:29 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(fill" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
// Default is not filled.
if( aZone->IsFilled() )
m_out->Print( 0, " yes" );
// Default is polygon filled.
if( aZone->GetFillMode() )
a) (zone (fill (mode was wrong, b) put fill on one line
2012-06-19 04:23:42 +00:00
m_out->Print( 0, " (mode segment)" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
parsing problem was unbalanced (smoothing) element
2012-06-19 04:08:00 +00:00
m_out->Print( 0, " (arc_segments %d) (thermal_gap %s) (thermal_bridge_width %s)",
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aZone->GetArcSegmentCount(),
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aZone->GetThermalReliefGap() ).c_str(),
FormatInternalUnits( aZone->GetThermalReliefCopperBridge() ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( aZone->GetCornerSmoothingType() != ZONE_SETTINGS::SMOOTHING_NONE )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
a) (zone (fill (mode was wrong, b) put fill on one line
2012-06-19 04:23:42 +00:00
m_out->Print( 0, " (smoothing" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
switch( aZone->GetCornerSmoothingType() )
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
{
case ZONE_SETTINGS::SMOOTHING_CHAMFER:
m_out->Print( 0, " chamfer" );
break;
case ZONE_SETTINGS::SMOOTHING_FILLET:
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( 0, " fillet" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
break;
default:
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
THROW_IO_ERROR( wxString::Format( _( "unknown zone corner smoothing type %d" ),
aZone->GetCornerSmoothingType() ) );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
}
parsing problem was unbalanced (smoothing) element
2012-06-19 04:08:00 +00:00
m_out->Print( 0, ")" );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( aZone->GetCornerRadius() != 0 )
parsing problem was unbalanced (smoothing) element
2012-06-19 04:08:00 +00:00
m_out->Print( 0, " (radius %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( aZone->GetCornerRadius() ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
int newLine = 0;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
if( aZone->GetNumCorners() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
bool new_polygon = true;
bool is_closed = false;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
for( auto iterator = aZone->IterateWithHoles(); iterator; iterator++ )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
if( new_polygon )
{
newLine = 0;
m_out->Print( aNestLevel+1, "(polygon\n" );
m_out->Print( aNestLevel+2, "(pts\n" );
new_polygon = false;
is_closed = false;
}
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( newLine == 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+3, "(xy %s %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( iterator->x ).c_str(), FormatInternalUnits( iterator->y ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
else
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " (xy %s %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( iterator->x ).c_str(), FormatInternalUnits( iterator->y ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( newLine < 4 )
{
newLine += 1;
}
else
{
newLine = 0;
m_out->Print( 0, "\n" );
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
if( iterator.IsEndContour() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
is_closed = true;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( newLine != 0 )
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, "\n" );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+2, ")\n" );
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
m_out->Print( aNestLevel+1, ")\n" );
new_polygon = true;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
if( !is_closed ) // Should not happen, but...
pcbnew: properly close tags when handling bad poly The parenthesis depth is 2 when the polygon isn't closed. This shouldn't happen but we have the fall-through to handle odd cases Fixes: lp:1844872 * https://bugs.launchpad.net/kicad/+bug/1844872
2019-09-21 15:15:08 +00:00
{
if( newLine != 0 )
m_out->Print( 0, "\n" );
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
pcbnew: properly close tags when handling bad poly The parenthesis depth is 2 when the polygon isn't closed. This shouldn't happen but we have the fall-through to handle odd cases Fixes: lp:1844872 * https://bugs.launchpad.net/kicad/+bug/1844872
2019-09-21 15:15:08 +00:00
m_out->Print( aNestLevel+2, ")\n" );
m_out->Print( aNestLevel+1, ")\n" );
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
// Save the PolysList (filled areas)
Removed all dependencies on boost::polygon except for bitmap2component. Replaced almost all instances of CPOLYGONS_LIST with SHAPE_POLY_SET.
2015-07-27 19:45:57 +00:00
const SHAPE_POLY_SET& fv = aZone->GetFilledPolysList();
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
newLine = 0;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Removed all dependencies on boost::polygon except for bitmap2component. Replaced almost all instances of CPOLYGONS_LIST with SHAPE_POLY_SET.
2015-07-27 19:45:57 +00:00
if( !fv.IsEmpty() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
bool new_polygon = true;
bool is_closed = false;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
for( auto it = fv.CIterate(); it; ++it )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
if( new_polygon )
{
newLine = 0;
m_out->Print( aNestLevel+1, "(filled_polygon\n" );
m_out->Print( aNestLevel+2, "(pts\n" );
new_polygon = false;
is_closed = false;
}
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
if( newLine == 0 )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+3, "(xy %s %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( it->x ).c_str(), FormatInternalUnits( it->y ).c_str() );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
else
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, " (xy %s %s)",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( it->x ) .c_str(), FormatInternalUnits( it->y ).c_str() );
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( newLine < 4 )
{
newLine += 1;
}
else
{
newLine = 0;
m_out->Print( 0, "\n" );
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Removed all dependencies on boost::polygon except for bitmap2component. Replaced almost all instances of CPOLYGONS_LIST with SHAPE_POLY_SET.
2015-07-27 19:45:57 +00:00
if( it.IsEndContour() )
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
{
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
is_closed = true;
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
if( newLine != 0 )
Pcbnew s-expression file parser bug fixes and file size improvements. * Use index when saving layers to handle translated layer names. * Add LOCALE_IO switcher when loading s-expression format. * Make SEGVIA default to through hole to improve file size. * Don't save default orientation of 0 degrees in TEXTE_MODULE and TEXTE_PCB. * Don't save default zone configuration parameters. * Save multiple zone corners on a single line. * Fixed missing ( check in graphic and module arc parsers. * Consistency improvements for DRAWSEGMENT and EDGE_MODULE objects. * Minor tweaks to D_PAD formatting.
2012-06-16 22:49:24 +00:00
m_out->Print( 0, "\n" );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+2, ")\n" );
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
m_out->Print( aNestLevel+1, ")\n" );
new_polygon = true;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
}
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
Pcbnew: fix serious issues (broken files) when saving and loading .kicad_pcb files when zones have holes in outlines.
2017-04-07 06:02:26 +00:00
if( !is_closed ) // Should not happen, but...
m_out->Print( aNestLevel+1, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
// Save the filling segments list
pcbnew: made zone filling algorithm thread-safe. - moved zone filling algo outside ZONE_CONTAINER class - const'ified methods that don't need to modify zone's properties - cleanup: m_FillMode -> enum
2017-12-04 18:06:47 +00:00
const auto& segs = aZone->FillSegments();
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
if( segs.size() )
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, "(fill_segments\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
pcbnew: made zone filling algorithm thread-safe. - moved zone filling algo outside ZONE_CONTAINER class - const'ified methods that don't need to modify zone's properties - cleanup: m_FillMode -> enum
2017-12-04 18:06:47 +00:00
for( ZONE_SEGMENT_FILL::const_iterator it = segs.begin(); it != segs.end(); ++it )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+2, "(pts (xy %s) (xy %s))\n",
units: Move common units and add tests Centralizing duplicate code from Eeschema and pcbnew and adding unit tests
2019-01-08 05:42:50 +00:00
FormatInternalUnits( wxPoint( it->A ) ).c_str(),
FormatInternalUnits( wxPoint( it->B ) ).c_str() );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_out->Print( aNestLevel+1, ")\n" );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
m_out->Print( aNestLevel, ")\n" );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
PCB_IO::PCB_IO( int aControlFlags ) :
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
m_cache( 0 ),
m_ctl( aControlFlags ),
m_parser( new PCB_PARSER() ),
m_mapping( new NETINFO_MAPPING() )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
pcbnew import footprint fixed for legacy nanometer format
2012-10-22 20:41:26 +00:00
init( 0 );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
m_out = &m_sf;
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
PCB_IO::~PCB_IO()
{
delete m_cache;
move PCB_PARSER into PCB_IO as a member
2012-10-24 18:20:33 +00:00
delete m_parser;
Added NETINFO_MAPPING, to ease saving nets with consecutive net codes (without modifying the net codes during the run time). Now, nets are saved with consecutive net codes (both modern & legacy plugins). Zones are saved together with their nets, without depending on the fact if there are any pads with such net. Therefore validation of zone net names was removed (pcbnew/class_board.cpp). Performed tests: - Changed a pad's net name from empty to existent - ok, name was changed. - Changed a pad's net name from empty to nonexistent - ok, error message is displayed, net name stays empty. - Changed a pad's net name from existent to empty - ok, net name became empty - Changed a pad's net name from existent to nonexistent - ok, error message is displayed, net name is not changed. - Drawn a zone that belongs to a net, then modified schematics so the net does not exist anymore. After reloading the net list, all pads/tracks are updated. Zones still belongs to the net that does not exist in the schematic (but still exists in .kicad_pcb file). After running DRC, the zone becomes not filled. - Undo & redo affects assignment of a polygon to a specific net (you may change net of a polygon, refill it and undo/redo the changes). - KiCad s-expr & legacy, Eagle, P-CAD boards seem to load without any problem (they also contain correct net names assigned to the appropriate pads). All types of board file formats were loaded, then saved in sexpr format and reopened with a KiCad built from the master branch (without my modifications). - A few boards were also saved using the legacy format and were opened with the master KiCad without any issues. - Change a net name for a pad, restore with undo/redo - ok - Remove everything, restore with undo - ok - Remove everything, reload netlist - ok Differences observed between files saved by the master branch KiCad and this one: - list of nets are not saved in any particular order, so net codes may differ - the default net class does not contain the unconnected net
2014-01-28 09:19:51 +00:00
delete m_mapping;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
BOARD* PCB_IO::Load( const wxString& aFileName, BOARD* aAppendToMe, const PROPERTIES* aProperties )
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
FILE_LINE_READER reader( aFileName );
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
add CTL_OMIT_INITIAL_COMMENTS and CTL_FOR_BOARD PCB_IO::Format()ing flags
2013-06-24 05:30:22 +00:00
init( aProperties );
move PCB_PARSER into PCB_IO as a member
2012-10-24 18:20:33 +00:00
m_parser->SetLineReader( &reader );
m_parser->SetBoard( aAppendToMe );
Add support for PCB and footprint format versioning Currently, kicad_pcb files have a (version ...) tag, but it is ignored. This commit does the following: 1. Parse the version. If it's later than the last supported version, present an alternative error message suggesting an upgrade if the file does not load correctly. The version will be interpreted as an integer YYYYMMDD to suggest a KiCad release date. 2. Accept a (version ...) tag also in kicad_mod files, but do not write them yet. If no version tag is present in these files, assume the version to be that of the current format version at the time of this commit. This is meant to be merged to the 4.x stable series, and preps for KiCad 5 which will start emitting version tags also in footprints - users with what will then be 'old stable' will not get a parse error when we introduce this for footprints, and we can safely increment the format version later.
2016-05-10 19:07:35 +00:00
BOARD* board;
try
{
board = dynamic_cast<BOARD*>( m_parser->Parse() );
}
Clean up warnings from exception handlers The exception objects caught are either not referenced at all, or only in debug builds. This avoids the warnings for the unused variables.
2016-10-10 15:04:48 +00:00
catch( const FUTURE_FORMAT_ERROR& )
FUTURE_FORMAT_ERROR: don't nest errors unnecessarily
2016-08-17 02:02:05 +00:00
{
// Don't wrap a FUTURE_FORMAT_ERROR in another
throw;
}
Add support for PCB and footprint format versioning Currently, kicad_pcb files have a (version ...) tag, but it is ignored. This commit does the following: 1. Parse the version. If it's later than the last supported version, present an alternative error message suggesting an upgrade if the file does not load correctly. The version will be interpreted as an integer YYYYMMDD to suggest a KiCad release date. 2. Accept a (version ...) tag also in kicad_mod files, but do not write them yet. If no version tag is present in these files, assume the version to be that of the current format version at the time of this commit. This is meant to be merged to the 4.x stable series, and preps for KiCad 5 which will start emitting version tags also in footprints - users with what will then be 'old stable' will not get a parse error when we introduce this for footprints, and we can safely increment the format version later.
2016-05-10 19:07:35 +00:00
catch( const PARSE_ERROR& parse_error )
{
if( m_parser->IsTooRecent() )
throw FUTURE_FORMAT_ERROR( parse_error, m_parser->GetRequiredVersion() );
else
throw;
}
Fix null dereference for certain bad PCB files Coverity: CID 147344 Unchecked dynamic_cast If a file that parses validly in Parse() but does not return a BOARD is loaded, no exception will be thrown but the dynamic_cast will return NULL. This NULL is tested by wxASSERT(), which does not actually halt anything (especially in release builds), and then we proceed to board->SetFileName(). This can be demonstrated quickly by renaming a .kicad_mod to .kicad_pcb and trying to load it. pcbnew will crash.
2016-05-11 02:36:39 +00:00
if( !board )
{
// The parser loaded something that was valid, but wasn't a board.
THROW_PARSE_ERROR( _( "this file does not contain a PCB" ),
m_parser->CurSource(), m_parser->CurLine(),
m_parser->CurLineNumber(), m_parser->CurOffset() );
}
Script plotting patch
2012-08-29 16:59:50 +00:00
// Give the filename to the board if it's new
if( !aAppendToMe )
board->SetFileName( aFileName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Script plotting patch
2012-08-29 16:59:50 +00:00
return board;
Add Pcbnew s-expression file parser. * Add s-expression file parser object and keyword files. * Fix minor issues with s-expression file formatting. * Fix a minor bug the zone container fill state parsing in the legacy plugin. * Move EDA_TEXT visibility definition to eda_text.h. * Add minor BOARD_ITEM object improvements to support s-expression file parser.
2012-06-09 17:00:13 +00:00
}
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
void PCB_IO::init( const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
m_board = NULL;
More Coverity scan error fixes.
2015-02-22 21:25:29 +00:00
m_reader = NULL;
m_loading_format_version = SEXPR_BOARD_FILE_VERSION;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
m_props = aProperties;
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
void PCB_IO::validateCache( const wxString& aLibraryPath, bool checkModified )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Don't cache github libraries above nginx server. It's too expensive to fetch the timestamps when the github server is busy. See Dick Hollenbeck's comments at the top of github_plugin.cpp for more info. Also adds some safety to the other caching algorithms after seeing github_plugin's wild-west usage of the kicad_plugin. Fixes: lp:1753143 * https://bugs.launchpad.net/kicad/+bug/1753143
2018-03-04 01:13:09 +00:00
if( !m_cache || !m_cache->IsPath( aLibraryPath ) || ( checkModified && m_cache->IsModified() ) )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
// a spectacular episode in memory management:
delete m_cache;
m_cache = new FP_CACHE( this, aLibraryPath );
m_cache->Load();
}
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Workaround an issue where a throw terminates (even when there's a catch for it). You can trigger it before this fix by running Cvpcb when a .kicad_mod file is incorrectly set as "Legacy" in your footprint table. (cherry picked from commit e269b5d1b97f5f580801d51959e4ca766da69416)
2019-08-31 14:18:27 +00:00
void PCB_IO::FootprintEnumerate( wxArrayString& aFootprintNames, const wxString& aLibPath,
bool aBestEfforts, const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Workaround an issue where a throw terminates (even when there's a catch for it). You can trigger it before this fix by running Cvpcb when a .kicad_mod file is incorrectly set as "Legacy" in your footprint table. (cherry picked from commit e269b5d1b97f5f580801d51959e4ca766da69416)
2019-08-31 14:18:27 +00:00
LOCALE_IO toggle; // toggles on, then off, the C locale.
wxDir dir( aLibPath );
wxString errorMsg;
Pcbnew: minor Geda and KiCad plugin improvements. * Make GPCB_PLUGIN::EnumerateFootprints() read the directory contents instead of loading the entire cache. * Make KICAD_PLUGIN::EnumerateFootprints() read the directory contents instead of loading the entire cache.
2013-12-13 23:01:42 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
init( aProperties );
Pcbnew: plugin improvements. Allow partial library reads in libraries that support footprint per file. This includes the KiCad and GEDA footprint libraries. Allow for partially cached libraries rather than ignoring all valid files when an error occurs.
2017-06-11 20:20:44 +00:00
try
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Workaround an issue where a throw terminates (even when there's a catch for it). You can trigger it before this fix by running Cvpcb when a .kicad_mod file is incorrectly set as "Legacy" in your footprint table. (cherry picked from commit e269b5d1b97f5f580801d51959e4ca766da69416)
2019-08-31 14:18:27 +00:00
validateCache( aLibPath );
Pcbnew: plugin improvements. Allow partial library reads in libraries that support footprint per file. This includes the KiCad and GEDA footprint libraries. Allow for partially cached libraries rather than ignoring all valid files when an error occurs.
2017-06-11 20:20:44 +00:00
}
catch( const IO_ERROR& ioe )
{
errorMsg = ioe.What();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Pcbnew: minor Geda and KiCad plugin improvements. * Make GPCB_PLUGIN::EnumerateFootprints() read the directory contents instead of loading the entire cache. * Make KICAD_PLUGIN::EnumerateFootprints() read the directory contents instead of loading the entire cache.
2013-12-13 23:01:42 +00:00
Don't bail out of loading when one library couldn't be found. Also includes some cleanup to the error dialog (removing sunken border, fixing OK button, etc.) Fixes: lp:1749572 * https://bugs.launchpad.net/kicad/+bug/1749572
2018-02-10 23:10:39 +00:00
// Some of the files may have been parsed correctly so we want to add the valid files to
// the library.
Workaround an issue where a throw terminates (even when there's a catch for it). You can trigger it before this fix by running Cvpcb when a .kicad_mod file is incorrectly set as "Legacy" in your footprint table. (cherry picked from commit e269b5d1b97f5f580801d51959e4ca766da69416)
2019-08-31 14:18:27 +00:00
for( MODULE_CITER it = m_cache->GetModules().begin(); it != m_cache->GetModules().end(); ++it )
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
aFootprintNames.Add( it->first );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Workaround an issue where a throw terminates (even when there's a catch for it). You can trigger it before this fix by running Cvpcb when a .kicad_mod file is incorrectly set as "Legacy" in your footprint table. (cherry picked from commit e269b5d1b97f5f580801d51959e4ca766da69416)
2019-08-31 14:18:27 +00:00
if( !errorMsg.IsEmpty() && !aBestEfforts )
Pcbnew: plugin improvements. Allow partial library reads in libraries that support footprint per file. This includes the KiCad and GEDA footprint libraries. Allow for partially cached libraries rather than ignoring all valid files when an error occurs.
2017-06-11 20:20:44 +00:00
THROW_IO_ERROR( errorMsg );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
const MODULE* PCB_IO::getFootprint( const wxString& aLibraryPath,
const wxString& aFootprintName,
const PROPERTIES* aProperties,
bool checkModified )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle; // toggles on, then off, the C locale.
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
init( aProperties );
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
try
{
validateCache( aLibraryPath, checkModified );
}
Fix warnings for unreferenced local variables
2018-04-18 07:10:29 +00:00
catch( const IO_ERROR& )
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
{
// do nothing with the error
}
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
const MODULE_MAP& mods = m_cache->GetModules();
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
MODULE_CITER it = mods.find( aFootprintName );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( it == mods.end() )
{
return NULL;
}
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
return it->second->GetModule();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
const MODULE* PCB_IO::GetEnumeratedFootprint( const wxString& aLibraryPath,
const wxString& aFootprintName,
const PROPERTIES* aProperties )
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
return getFootprint( aLibraryPath, aFootprintName, aProperties, false );
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
}
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
Add FootprintExists() which can be more careful about FS differences. (And in particular, MSW's case-insensitive FS.) Fixes: lp:1835999 * https://bugs.launchpad.net/kicad/+bug/1835999 (cherry picked from commit 20036f810534db50894dc544adc132f181e55aa9)
2019-07-11 21:59:14 +00:00
bool PCB_IO::FootprintExists( const wxString& aLibraryPath, const wxString& aFootprintName,
const PROPERTIES* aProperties )
{
// Note: checking the cache sounds like a good idea, but won't catch files which differ
// only in case.
//
// Since this goes out to the native filesystem, we get platform differences (ie: MSW's
// case-insensitive filesystem) handled "for free".
wxFileName footprintFile( aLibraryPath, aFootprintName );
footprintFile.SetExt( KiCadFootprintFileExtension );
return footprintFile.Exists();
}
Fix segfault when not all libraries loaded. Fixes: lp:1751464 * https://bugs.launchpad.net/kicad/+bug/1751464
2018-02-24 17:41:44 +00:00
MODULE* PCB_IO::FootprintLoad( const wxString& aLibraryPath, const wxString& aFootprintName,
const PROPERTIES* aProperties )
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
const MODULE* footprint = getFootprint( aLibraryPath, aFootprintName, aProperties, true );
return footprint ? new MODULE( *footprint ) : nullptr;
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
}
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
void PCB_IO::FootprintSave( const wxString& aLibraryPath, const MODULE* aFootprint,
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle; // toggles on, then off, the C locale.
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
init( aProperties );
1) Switch to boost hashtable support from wx macros which did not handle std::string. This required the additional compiler command line option "-std=c++0x". 2) Switch to unique_ptr from auto_ptr which is C++ deprecated. 3) Change to new English layer names per mailing list discussion, see class_board.cpp. 4) When saving to *.kicad_pcb or *.kicad_mod, identify opportunities to use wildcard layer sets, for pads so far. 5) Switch to two std::string hashtables in pcb_parser.cpp, away from one wxString based one for layer names and layer sets mapping. One hashtable holds the mask, the other the index. Layer sets are only in the mask table. 6) Move "LOCALE_IO toggle" into PCB_IO::Format() since it is a public API function and caller should find it as convenient as possible to use. LOCALE_IO should handle nesting OK in the case where public Format() is called from one of the Footprint*() functions. 7) Drop support for "export module to new library". Creating new libraries will have to be handled in concert with library table entries, and we've talked recently about creating a better footprint library manager, one that resides in a DLL/DSO. So this kind of functionality needs to be handled in there in the near future. 8) Change name of exported PCB_IO module/footprint to *.kicad_mod and not *.emp.
2012-11-14 07:15:59 +00:00
// In this public PLUGIN API function, we can safely assume it was
// called for saving into a library path.
m_ctl = CTL_FOR_LIBRARY;
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
validateCache( aLibraryPath );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !m_cache->IsWritable() )
{
Improve error message granularity When saving a library, check and report on libraries that do not exist as well as those that exist but are read-only. Fixes: lp:1769190 * https://bugs.launchpad.net/kicad/+bug/1769190
2018-05-04 16:10:51 +00:00
if( !m_cache->Exists() )
{
Query user to create library on save Revising 5ca6864a4, this prompts the user to create the missing library directory when attempting to save to a non-existent library.
2018-05-04 16:59:35 +00:00
const wxString msg = wxString::Format( _( "Library \"%s\" does not exist.\n"
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
"Would you like to create it?"),
GetChars( aLibraryPath ) );
Query user to create library on save Revising 5ca6864a4, this prompts the user to create the missing library directory when attempting to save to a non-existent library.
2018-05-04 16:59:35 +00:00
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
if( wxMessageBox( msg, _( "Library Not Found"), wxYES_NO | wxICON_QUESTION ) != wxYES )
Query user to create library on save Revising 5ca6864a4, this prompts the user to create the missing library directory when attempting to save to a non-existent library.
2018-05-04 16:59:35 +00:00
return;
// Save throws its own IO_ERROR on failure, so no need to recreate here
m_cache->Save( NULL );
Improve error message granularity When saving a library, check and report on libraries that do not exist as well as those that exist but are read-only. Fixes: lp:1769190 * https://bugs.launchpad.net/kicad/+bug/1769190
2018-05-04 16:10:51 +00:00
}
else
{
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
wxString msg = wxString::Format( _( "Library \"%s\" is read only" ), aLibraryPath );
Query user to create library on save Revising 5ca6864a4, this prompts the user to create the missing library directory when attempting to save to a non-existent library.
2018-05-04 16:59:35 +00:00
THROW_IO_ERROR( msg );
Improve error message granularity When saving a library, check and report on libraries that do not exist as well as those that exist but are read-only. Fixes: lp:1769190 * https://bugs.launchpad.net/kicad/+bug/1769190
2018-05-04 16:10:51 +00:00
}
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Rewrite class UTF8 to contain rather than extend std::string storage. This forces the compiler class specific features rather than borrowing from the base class's std::string. In some cases prior to this, wxString( std::string ) was being called rather than UTF8::operator wxString() leading to garbled wxStrings. Added function UTF8::wx_str() which is of great convenience also. Implicit conversions still work as before, and hopefully more reliably.
2017-07-25 19:14:31 +00:00
wxString footprintName = aFootprint->GetFPID().GetLibItemName();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
MODULE_MAP& mods = m_cache->GetModules();
// Quietly overwrite module and delete module file from path for any by same name.
Reverse commit 4011ed4e31c77d9ee885cc9262d0f0f89cad4fc6. This commit was too broad and not cognizant of the purpose of the class UTF8. Add MAYBE_VERIFY_UTF8() macro, which can trap non-UTF8 encoded strings in debug builds. Use that macro conditionally in class UTF8 to trap non-UTF8 encoded strings being put into UTF8 instances.
2017-07-24 19:02:59 +00:00
wxFileName fn( aLibraryPath, aFootprint->GetFPID().GetLibItemName(),
Make footprint ID into a generic library ID. Rename FPID to LIB_ID as is now used as a generic library identifier and is no longer specific to footprints. Remove all mention of footprint from the new LIB_ID doxygen comments and code. Rename files fpid.h and fpid.cpp to lib_id.h and lib_id.cpp. Rename fp_lib_table.keywords file to lib_table.keywords and adjust CMake build dependencies accordingly. Update all source files effected by the code and file name changes. Update .gitignore for file name changes.
2016-11-20 23:35:08 +00:00
KiCadFootprintFileExtension );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Replace missing #ifndef's. We only process symlinks on POSIX kernels (Linux and OSX). Fixes: lp:1548798 * https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-24 07:52:33 +00:00
#ifndef __WINDOWS__
Support symlinks for .pretty and .lib files. Fixes: lp:1548798 * https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-23 22:49:07 +00:00
// Write through symlinks, don't replace them
if( fn.Exists( wxFILE_EXISTS_SYMLINK ) )
{
char buffer[ PATH_MAX + 1 ];
ssize_t pathLen = readlink( TO_UTF8( fn.GetFullPath() ), buffer, PATH_MAX );
if( pathLen > 0 )
{
buffer[ pathLen ] = '\0';
fn.Assign( fn.GetPath() + wxT( "/" ) + wxString::FromUTF8( buffer ) );
fn.Normalize();
}
}
Replace missing #ifndef's. We only process symlinks on POSIX kernels (Linux and OSX). Fixes: lp:1548798 * https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-24 07:52:33 +00:00
#endif
Support symlinks for .pretty and .lib files. Fixes: lp:1548798 * https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-23 22:49:07 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !fn.IsOk() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "Footprint file name \"%s\" is not valid." ),
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
fn.GetFullPath() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
if( fn.FileExists() && !fn.IsFileWritable() )
{
Fix minor I10n issues.
2018-11-18 13:40:36 +00:00
THROW_IO_ERROR( wxString::Format( _( "No write permissions to delete file \"%s\"" ),
Performance enhancements in fp loading, string cmp, etc. Knocks about 1/3 off the first footprint load, and more than 1/2 off subsequent loads.
2018-07-30 13:18:37 +00:00
fn.GetFullPath() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxString fullPath = fn.GetFullPath();
wxString fullName = fn.GetFullName();
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
MODULE_CITER it = mods.find( footprintName );
if( it != mods.end() )
{
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxLogTrace( traceKicadPcbPlugin, wxT( "Removing footprint file '%s'." ), fullPath );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
mods.erase( footprintName );
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxRemoveFile( fullPath );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
// I need my own copy for the cache
MODULE* module = new MODULE( *aFootprint );
// and it's time stamp must be 0, it should have no parent, orientation should
// be zero, and it should be on the front layer.
module->SetTimeStamp( 0 );
module->SetParent( 0 );
module->SetOrientation( 0 );
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
if( module->GetLayer() != F_Cu )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
module->Flip( module->GetPosition() );
More performance enhancements. Be more intelligent about sorting lib tree items. (Footprint entries, for instance, come out of an already-sorted list.) Don't recreate menus twice when laoding Footprint Editor. More pervasive use of WX_FILENAME to avoid expensive calls to wxFileName::SplitPath() and string concatenation. For POSIX kernels do all the work on the file-system side so we don't have to keep converting back and forth between encodings.
2018-08-05 11:56:02 +00:00
wxLogTrace( traceKicadPcbPlugin, wxT( "Creating s-expr footprint file '%s'." ), fullPath );
GetFullPath() includes filename; we just want GetPath() Fixes: lp:1785891 * https://bugs.launchpad.net/kicad/+bug/1785891
2018-08-07 21:03:13 +00:00
mods.insert( footprintName, new FP_CACHE_ITEM( module, WX_FILENAME( fn.GetPath(), fullName ) ) );
pcbnew: Save only edited footprint when saving Don't re-save all files in a library when editing a single footprint. This creates issues with formatting in version control systems where unmodified files are re-written without being explicitly changed by the user. Fixes: lp:1752991 * https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 21:39:26 +00:00
m_cache->Save( module );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Fix board file formatting bug. The roundrect_rratio token was missing a leading space which made the file formatting different from all other formatting when using rounded rectangle pads. Fixes lp:1768355 https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 14:20:50 +00:00
void PCB_IO::FootprintDelete( const wxString& aLibraryPath, const wxString& aFootprintName,
const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle; // toggles on, then off, the C locale.
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
*) Implement "Copy On Write" (COW) support in GITHUB_PLUGIN. See class header comment for GITHUB_PLUGIN which should flow into Doxygen output. *) Rewrote: PCB_BASE_FRAME::Save_Module_In_Library(): now uses fp-lib-table and PROPERTIES. PCB_EDIT_FRAME::ArchiveModulesOnBoard(): now can archive to any writable library type. PCB_BASE_FRAME::SelectLibrary(): is now generic for selecting a library, not just the active library.
2013-11-27 06:04:04 +00:00
init( aProperties );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
validateCache( aLibraryPath );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !m_cache->IsWritable() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "Library \"%s\" is read only" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
m_cache->Remove( aFootprintName );
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Performance fixes for the place footprint list all dialog. Smartens the cache freshness checking, and adds checksums of constituent-directory last-mod-dates to the footprint info list. Also inserts the dataPtrs into the list at the same time as the text to keep wxWidgets from measuring the width of the text twice (yes, really). And converts the list to default- column widths in case the wxWidgets patch is present to greatly speed list creation (by not measuring all that text). On my machine drops the first-load time from 4s to 2.5s and the subsequent-load times from 2.5s to < 1s. With the wxWidgets patch subsequent-loads become near-instantaneous.
2018-02-05 20:55:00 +00:00
Don't cache github libraries above nginx server. It's too expensive to fetch the timestamps when the github server is busy. See Dick Hollenbeck's comments at the top of github_plugin.cpp for more info. Also adds some safety to the other caching algorithms after seeing github_plugin's wild-west usage of the kicad_plugin. Fixes: lp:1753143 * https://bugs.launchpad.net/kicad/+bug/1753143
2018-03-04 01:13:09 +00:00
long long PCB_IO::GetLibraryTimestamp( const wxString& aLibraryPath ) const
Performance fixes for the place footprint list all dialog. Smartens the cache freshness checking, and adds checksums of constituent-directory last-mod-dates to the footprint info list. Also inserts the dataPtrs into the list at the same time as the text to keep wxWidgets from measuring the width of the text twice (yes, really). And converts the list to default- column widths in case the wxWidgets patch is present to greatly speed list creation (by not measuring all that text). On my machine drops the first-load time from 4s to 2.5s and the subsequent-load times from 2.5s to < 1s. With the wxWidgets patch subsequent-loads become near-instantaneous.
2018-02-05 20:55:00 +00:00
{
Performance enhancements for footprint info list. Cache the footprint info on disk (in the project). Move timestamp-generation (and checking) to the filesystem so the above will be bullet-proof. Rewrite some wxWidgets classes for performance (see common.h).
2018-08-03 16:53:38 +00:00
return FP_CACHE::GetTimestamp( aLibraryPath );
Performance fixes for the place footprint list all dialog. Smartens the cache freshness checking, and adds checksums of constituent-directory last-mod-dates to the footprint info list. Also inserts the dataPtrs into the list at the same time as the text to keep wxWidgets from measuring the width of the text twice (yes, really). And converts the list to default- column widths in case the wxWidgets patch is present to greatly speed list creation (by not measuring all that text). On my machine drops the first-load time from 4s to 2.5s and the subsequent-load times from 2.5s to < 1s. With the wxWidgets patch subsequent-loads become near-instantaneous.
2018-02-05 20:55:00 +00:00
}
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
void PCB_IO::FootprintLibCreate( const wxString& aLibraryPath, const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
if( wxDir::Exists( aLibraryPath ) )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "cannot overwrite library path \"%s\"" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
init( aProperties );
delete m_cache;
m_cache = new FP_CACHE( this, aLibraryPath );
m_cache->Save();
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Make PLUGIN::Footprint*() API functions take 'const' PROPERTIES*. Add const PROPERTIES* to FootprintDelete(). Add {Get,Set}Properties() to FP_LIB_TABLE::ROW. Touch up fp table dialog.
2013-09-25 19:17:06 +00:00
bool PCB_IO::FootprintLibDelete( const wxString& aLibraryPath, const PROPERTIES* aProperties )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
wxFileName fn;
fn.SetPath( aLibraryPath );
// Return if there is no library path to delete.
if( !fn.DirExists() )
Eliminate many assumptions in Pcbnew's library manager, pertaining to locality of libraries and their type, by using the more abstract PLUGIN::Footprint*() functions. This is an intermediate phase only, other changes will be necessary as library table support comes in. Encapsulate usage of library path searching, since that will go away as library table support comes in. Add FOOTPRINT_EDIT_FRAME::{get,set}LibPath() and FOOTPRINT_EDIT_FRAME::{get,set}LibNickName() functions to provide this encapsulation.
2012-11-19 16:19:38 +00:00
return false;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
if( !fn.IsDirWritable() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "user does not have permission to delete directory \"%s\"" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
wxDir dir( aLibraryPath );
if( dir.HasSubDirs() )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "library directory \"%s\" has unexpected sub-directories" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
// All the footprint files must be deleted before the directory can be deleted.
if( dir.HasFiles() )
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
unsigned i;
wxFileName tmp;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
wxArrayString files;
wxDir::GetAllFiles( aLibraryPath, &files );
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( i = 0; i < files.GetCount(); i++ )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
tmp = files[i];
Eliminate many assumptions in Pcbnew's library manager, pertaining to locality of libraries and their type, by using the more abstract PLUGIN::Footprint*() functions. This is an intermediate phase only, other changes will be necessary as library table support comes in. Encapsulate usage of library path searching, since that will go away as library table support comes in. Add FOOTPRINT_EDIT_FRAME::{get,set}LibPath() and FOOTPRINT_EDIT_FRAME::{get,set}LibNickName() functions to provide this encapsulation.
2012-11-19 16:19:38 +00:00
if( tmp.GetExt() != KiCadFootprintFileExtension )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "unexpected file \"%s\" was found in library path \"%s\"" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
files[i].GetData(), aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
for( i = 0; i < files.GetCount(); i++ )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
wxRemoveFile( files[i] );
}
}
Organize trace debugging code for ease of maintenance.
2018-04-13 13:58:25 +00:00
wxLogTrace( traceKicadPcbPlugin, wxT( "Removing footprint library \"%s\"" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
// Some of the more elaborate wxRemoveFile() crap puts up its own wxLog dialog
// we don't want that. we want bare metal portability with no UI here.
if( !wxRmdir( aLibraryPath ) )
{
Fix quotes in UI messages This replaces all single and angle bracket quotes in UI messages with double quotes, for consistency. Sorry to all translators.
2017-12-15 11:37:46 +00:00
THROW_IO_ERROR( wxString::Format( _( "footprint library \"%s\" cannot be deleted" ),
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
aLibraryPath.GetData() ) );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
// For some reason removing a directory in Windows is not immediately updated. This delay
// prevents an error when attempting to immediately recreate the same directory when over
// writing an existing library.
#ifdef __WINDOWS__
wxMilliSleep( 250L );
#endif
Pcbnew footprint library plug in fixes and minor code cleaning. * When loading footprint do not retest every footprint in cache. Only test the footprint being loaded. Fixes long load times on libraries with a lot of parts. * Fix footprint name bug where file extension was added to the end of the footprint name. * Fix bug in path equivalence test due to Posix path separators in footprint library table. Convert paths to native separator before comparison. * Fix a bug in FOOTPRINT_VIEWER_FRAME::OnActivate() which cause the footprint list to always get reloaded when using footprint library tables. * Remove some unnecessary debugging messages. * Add a few Doxygen comments to FP_CACHE in kicad_plugin.cpp.
2013-09-24 18:45:57 +00:00
if( m_cache && !m_cache->IsPath( aLibraryPath ) )
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
{
delete m_cache;
m_cache = NULL;
}
Eliminate many assumptions in Pcbnew's library manager, pertaining to locality of libraries and their type, by using the more abstract PLUGIN::Footprint*() functions. This is an intermediate phase only, other changes will be necessary as library table support comes in. Encapsulate usage of library path searching, since that will go away as library table support comes in. Add FOOTPRINT_EDIT_FRAME::{get,set}LibPath() and FOOTPRINT_EDIT_FRAME::{get,set}LibNickName() functions to provide this encapsulation.
2012-11-19 16:19:38 +00:00
return true;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
}
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
bool PCB_IO::IsFootprintLibWritable( const wxString& aLibraryPath )
{
Fix kicad_plugin.cpp coding style fully broken by commit 4887 (patch from Orson, AKA maciej suminski).
2014-05-26 06:21:25 +00:00
LOCALE_IO toggle;
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
init( NULL );
Go back to checking individual file timestamps. Too many external applications fail to touch the parent directory. Also removes FP_CACHE_ITEM lastMod times and dirty flags as we've always loaded libraries atomically anyway. Claws back some of the performance lost by being more efficient with cache management for sequential calls to Enumerate and then Load. Fixes: lp:1750936 * https://bugs.launchpad.net/kicad/+bug/1750936
2018-02-23 12:21:06 +00:00
validateCache( aLibraryPath );
Pcbnew s-experssion footprint library implementation. * Add footprint methods to PCB_IO. * Add FP_CACHE and FP_CACHE_ITEM for handling new footprint library design. * Add code to save legacy libraries in new format. * Change behavior of BOARD_ITEM::GetLayerName() to return the default layer name when the item does not have a BOARD as a parent. * Minor changes to the module output formatter when writing to module library files (no BOARD as parent). * Add new (and some that I forgot along the way) CMake flags to EDA_BASE_FRAME::CopyVersionInfoToClipboard(). * Add -Wno-narrowing to GCC flags to stop GCC 4.7 from complaining about a conversion from int to unsigned in the Boost polygon library. * Add INPUT_STREAM_READER to richio.cpp to allow using any object derived from wxInputStream as a LINE_READER (needs to be validated).
2012-10-07 15:37:25 +00:00
return m_cache->IsWritable();
}