2020-10-24 01:38:50 +00:00
|
|
|
/*
|
|
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
|
|
*
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
* Copyright (C) 1992-2021 KiCad Developers, see AUTHORS.txt for contributors.
|
2020-10-24 01:38:50 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, you may find one here:
|
|
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <locale_io.h>
|
|
|
|
#include <wx/intl.h>
|
2021-09-23 19:14:03 +00:00
|
|
|
#include <clocale>
|
2020-10-24 01:38:50 +00:00
|
|
|
|
Fix various typos
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
2022-07-03 04:20:05 +00:00
|
|
|
// When reading/writing files, we need to switch to setlocale( LC_NUMERIC, "C" ).
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
// Works fine to read/write files with floating point numbers.
|
|
|
|
// We can call setlocale( LC_NUMERIC, "C" ) or wxLocale( "C", "C", "C", false )
|
|
|
|
// wxWidgets discourage a direct call to setlocale
|
|
|
|
// However, for us, calling wxLocale( "C", "C", "C", false ) has a unwanted effect:
|
|
|
|
// The I18N translations are no longer active, because the English dictionary is selected.
|
Fix various typos
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
2022-07-03 04:20:05 +00:00
|
|
|
// To read files, this is not a major issues, but the result can differ
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
// from using setlocale(xx, "C").
|
Fix various typos
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
2022-07-03 04:20:05 +00:00
|
|
|
// Previously, we used only setlocale( LC_NUMERIC, "C" )
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
//
|
|
|
|
// Known issues are
|
|
|
|
// on MSW
|
|
|
|
// using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
|
|
|
|
// and this message ("Decimal separator mismatch") must be disabled.
|
|
|
|
// But calling wxLocale( "C", "C", "C", false ) works fine
|
|
|
|
// On unix:
|
|
|
|
// calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
|
|
|
|
// these env vars return a empty string from wxGetEnv() in many cases, and if such a
|
|
|
|
// var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
|
|
|
|
//
|
|
|
|
// So use wxLocale on Windows and setlocale on unix
|
|
|
|
|
|
|
|
|
|
|
|
// set USE_WXLOCALE 0 to use setlocale, 1 to use wxLocale:
|
|
|
|
#if defined( _WIN32 )
|
|
|
|
#define USE_WXLOCALE 1
|
|
|
|
#else
|
|
|
|
#define USE_WXLOCALE 0
|
|
|
|
#endif
|
|
|
|
|
|
|
|
// On Windows, when using setlocale, a wx alert is generated
|
|
|
|
// in some cases (reading a bitmap for instance)
|
|
|
|
// So we disable alerts during the time a file is read or written
|
|
|
|
#if !USE_WXLOCALE
|
|
|
|
#if defined( _WIN32 ) && defined( DEBUG )
|
|
|
|
// a wxAssertHandler_t function to filter wxWidgets alert messages when reading/writing a file
|
|
|
|
// when switching the locale to LC_NUMERIC, "C"
|
|
|
|
// It is used in class LOCALE_IO to hide a useless (in kicad) wxWidgets alert message
|
|
|
|
void KiAssertFilter( const wxString &file, int line,
|
|
|
|
const wxString &func, const wxString &cond,
|
|
|
|
const wxString &msg)
|
|
|
|
{
|
|
|
|
if( !msg.Contains( "Decimal separator mismatch" ) )
|
|
|
|
wxTheApp->OnAssertFailure( file.c_str(), line, func.c_str(), cond.c_str(), msg.c_str() );
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif
|
2020-10-24 01:38:50 +00:00
|
|
|
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
std::atomic<unsigned int> LOCALE_IO::m_c_count( 0 );
|
2020-10-24 01:38:50 +00:00
|
|
|
|
|
|
|
LOCALE_IO::LOCALE_IO() : m_wxLocale( nullptr )
|
|
|
|
{
|
|
|
|
// use thread safe, atomic operation
|
|
|
|
if( m_c_count++ == 0 )
|
|
|
|
{
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
#if USE_WXLOCALE
|
|
|
|
#define C_LANG "C"
|
|
|
|
m_wxLocale = new wxLocale( C_LANG, C_LANG, C_LANG, false );
|
|
|
|
#else
|
|
|
|
// Store the user locale name, to restore this locale later, in dtor
|
|
|
|
m_user_locale = setlocale( LC_NUMERIC, nullptr );
|
|
|
|
#if defined( _WIN32 ) && defined( DEBUG )
|
|
|
|
// Disable wxWidgets alerts
|
|
|
|
wxSetAssertHandler( KiAssertFilter );
|
|
|
|
#endif
|
|
|
|
// Switch the locale to C locale, to read/write files with fp numbers
|
|
|
|
setlocale( LC_NUMERIC, "C" );
|
|
|
|
#endif
|
2020-10-24 01:38:50 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
LOCALE_IO::~LOCALE_IO()
|
|
|
|
{
|
|
|
|
// use thread safe, atomic operation
|
|
|
|
if( --m_c_count == 0 )
|
|
|
|
{
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
// revert to the user locale
|
|
|
|
#if USE_WXLOCALE
|
|
|
|
delete m_wxLocale; // Deleting m_wxLocale restored previous locale
|
2020-10-24 01:38:50 +00:00
|
|
|
m_wxLocale = nullptr;
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
#else
|
|
|
|
setlocale( LC_NUMERIC, m_user_locale.c_str() );
|
|
|
|
#if defined( _WIN32 ) && defined( DEBUG )
|
|
|
|
// Enable wxWidgets alerts
|
|
|
|
wxSetDefaultAssertHandler();
|
|
|
|
#endif
|
|
|
|
#endif
|
2020-10-24 01:38:50 +00:00
|
|
|
}
|
LOCALE_IO rework to fix issues on linux when using env vars with non ASCII7 chars.
We need to use a "C" locate to read/write files, and therefore switch the locale.
Removing use of setlocale( LC_NUMERIC, "C" ) and use only
wxLocale( "C", "C", "C", false ) was too fast: on linux it breaks the env vars.
on MSW
using setlocale( LC_NUMERIC, "C" ) generates an alert message in debug mode,
and this message ("Decimal separator mismatch") must be disabled.
But calling wxLocale( "C", "C", "C", false ) works fine
On unix:
calling wxLocale( "C", "C", "C", false ) breaks env vars containing non ASCII7 chars.
these env vars return a empty string from wxGetEnv() in many cases, and if such a
var must be read after calling wxLocale( "C", "C", "C", false ), it looks like empty
So use wxLocale on Windows and setlocale on unix
2021-09-23 12:30:40 +00:00
|
|
|
}
|