2011-10-07 14:41:30 +00:00
|
|
|
/*
|
|
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
|
|
*
|
2015-07-29 12:18:53 +00:00
|
|
|
* Copyright (C) 2015 Jean-Pierre Charras, jp.charras at wanadoo.fr
|
2020-10-07 13:15:31 +00:00
|
|
|
* Copyright (C) 2011 Wayne Stambaugh <stambaughw@gmail.com>
|
|
|
|
* Copyright (C) 1992-2020 KiCad Developers, see AUTHORS.txt for contributors.
|
2011-10-07 14:41:30 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, you may find one here:
|
|
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @file erc.cpp
|
|
|
|
* @brief Electrical Rules Check implementation.
|
|
|
|
*/
|
2007-05-06 16:03:28 +00:00
|
|
|
|
2020-08-30 19:25:31 +00:00
|
|
|
#include "connection_graph.h"
|
|
|
|
#include <erc.h>
|
2012-01-23 04:33:36 +00:00
|
|
|
#include <kicad_string.h>
|
|
|
|
#include <lib_pin.h>
|
2020-08-30 19:25:31 +00:00
|
|
|
#include <sch_edit_frame.h>
|
2012-01-23 04:33:36 +00:00
|
|
|
#include <sch_marker.h>
|
2018-01-19 15:12:36 +00:00
|
|
|
#include <sch_reference_list.h>
|
2020-08-30 19:25:31 +00:00
|
|
|
#include <sch_sheet.h>
|
2020-05-13 02:00:37 +00:00
|
|
|
#include <schematic.h>
|
2020-05-28 13:36:54 +00:00
|
|
|
#include <ws_draw_item.h>
|
|
|
|
#include <ws_proxy_view_item.h>
|
2020-08-30 19:25:31 +00:00
|
|
|
#include <wx/ffile.h>
|
2015-07-29 12:18:53 +00:00
|
|
|
|
2007-05-06 16:03:28 +00:00
|
|
|
|
2009-07-07 17:50:02 +00:00
|
|
|
/* ERC tests :
|
|
|
|
* 1 - conflicts between connected pins ( example: 2 connected outputs )
|
2009-11-03 13:26:31 +00:00
|
|
|
* 2 - minimal connections requirements ( 1 input *must* be connected to an
|
|
|
|
* output, or a passive pin )
|
2007-09-20 21:06:49 +00:00
|
|
|
*/
|
2007-05-06 16:03:28 +00:00
|
|
|
|
|
|
|
|
2009-07-07 17:50:02 +00:00
|
|
|
/*
|
2020-01-18 20:51:28 +00:00
|
|
|
* Minimal ERC requirements:
|
|
|
|
* All pins *must* be connected (except ELECTRICAL_PINTYPE::PT_NC).
|
2009-11-03 13:26:31 +00:00
|
|
|
* When a pin is not connected in schematic, the user must place a "non
|
|
|
|
* connected" symbol to this pin.
|
2009-07-07 17:50:02 +00:00
|
|
|
* This ensures a forgotten connection will be detected.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Messages for conflicts :
|
2020-10-07 13:15:31 +00:00
|
|
|
* ELECTRICAL_PINTYPE::PT_INPUT, ELECTRICAL_PINTYPE::PT_OUTPUT, ELECTRICAL_PINTYPE:PT_:BIDI,
|
|
|
|
* ELECTRICAL_PINTYPE::PT_TRISTATE, ELECTRICAL_PINTYPE::PT_PASSIVE,
|
|
|
|
* ELECTRICAL_PINTYPE::PT_UNSPECIFIED, ELECTRICAL_PINTYPE::PT_POWER_IN,
|
|
|
|
* ELECTRICAL_PINTYPE::PT_POWER_OUT, ELECTRICAL_PINTYPE::PT_OPENCOLLECTOR,
|
|
|
|
* ELECTRICAL_PINTYPE::PT_OPENEMITTER, ELECTRICAL_PINTYPE::PT_NC
|
|
|
|
*
|
2009-07-07 17:50:02 +00:00
|
|
|
* These messages are used to show the ERC matrix in ERC dialog
|
2007-09-20 21:06:49 +00:00
|
|
|
*/
|
2007-05-06 16:03:28 +00:00
|
|
|
|
2009-07-07 17:50:02 +00:00
|
|
|
// Messages for matrix rows:
|
2014-01-18 09:07:05 +00:00
|
|
|
const wxString CommentERC_H[] =
|
2007-05-06 16:03:28 +00:00
|
|
|
{
|
2018-04-06 13:46:16 +00:00
|
|
|
_( "Input Pin" ),
|
|
|
|
_( "Output Pin" ),
|
|
|
|
_( "Bidirectional Pin" ),
|
|
|
|
_( "Tri-State Pin" ),
|
|
|
|
_( "Passive Pin" ),
|
|
|
|
_( "Unspecified Pin" ),
|
|
|
|
_( "Power Input Pin" ),
|
|
|
|
_( "Power Output Pin" ),
|
|
|
|
_( "Open Collector" ),
|
|
|
|
_( "Open Emitter" ),
|
|
|
|
_( "No Connection" )
|
2007-05-06 16:03:28 +00:00
|
|
|
};
|
2009-07-07 17:50:02 +00:00
|
|
|
|
|
|
|
// Messages for matrix columns
|
2014-01-18 09:07:05 +00:00
|
|
|
const wxString CommentERC_V[] =
|
2007-05-06 16:03:28 +00:00
|
|
|
{
|
2011-10-07 14:41:30 +00:00
|
|
|
_( "Input Pin" ),
|
|
|
|
_( "Output Pin" ),
|
|
|
|
_( "Bidirectional Pin" ),
|
|
|
|
_( "Tri-State Pin" ),
|
|
|
|
_( "Passive Pin" ),
|
|
|
|
_( "Unspecified Pin" ),
|
|
|
|
_( "Power Input Pin" ),
|
|
|
|
_( "Power Output Pin" ),
|
|
|
|
_( "Open Collector" ),
|
|
|
|
_( "Open Emitter" ),
|
2014-01-18 09:07:05 +00:00
|
|
|
_( "No Connection" )
|
2007-05-06 16:03:28 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
int ERC_TESTER::TestDuplicateSheetNames( bool aCreateMarker )
|
2009-07-09 17:02:15 +00:00
|
|
|
{
|
2011-10-07 14:41:30 +00:00
|
|
|
SCH_SCREEN* screen;
|
2010-10-26 20:25:48 +00:00
|
|
|
int err_count = 0;
|
2020-05-13 02:00:37 +00:00
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
SCH_SCREENS screenList( m_schematic->Root() );
|
2009-11-03 13:26:31 +00:00
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
for( screen = screenList.GetFirst(); screen != nullptr; screen = screenList.GetNext() )
|
2009-07-09 17:02:15 +00:00
|
|
|
{
|
2019-06-25 23:39:58 +00:00
|
|
|
std::vector<SCH_SHEET*> list;
|
|
|
|
|
2020-03-16 11:05:01 +00:00
|
|
|
for( SCH_ITEM* item : screen->Items().OfType( SCH_SHEET_T ) )
|
2019-06-25 23:39:58 +00:00
|
|
|
list.push_back( static_cast<SCH_SHEET*>( item ) );
|
|
|
|
|
|
|
|
for( size_t i = 0; i < list.size(); i++ )
|
2009-07-09 17:02:15 +00:00
|
|
|
{
|
2020-05-28 13:36:54 +00:00
|
|
|
SCH_SHEET* sheet = list[i];
|
2011-10-07 14:41:30 +00:00
|
|
|
|
2019-06-25 23:39:58 +00:00
|
|
|
for( size_t j = i + 1; j < list.size(); j++ )
|
2009-07-09 17:02:15 +00:00
|
|
|
{
|
2020-03-16 11:05:01 +00:00
|
|
|
SCH_SHEET* test_item = list[j];
|
2009-07-09 17:02:15 +00:00
|
|
|
|
|
|
|
// We have found a second sheet: compare names
|
2015-12-20 12:40:17 +00:00
|
|
|
// we are using case insensitive comparison to avoid mistakes between
|
|
|
|
// similar names like Mysheet and mysheet
|
2020-05-28 13:36:54 +00:00
|
|
|
if( sheet->GetName().CmpNoCase( test_item->GetName() ) == 0 )
|
2009-07-09 17:02:15 +00:00
|
|
|
{
|
2010-06-28 13:11:14 +00:00
|
|
|
if( aCreateMarker )
|
|
|
|
{
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_DUPLICATE_SHEET_NAME );
|
2020-05-28 13:36:54 +00:00
|
|
|
ercItem->SetItems( sheet, test_item );
|
2020-04-24 13:36:10 +00:00
|
|
|
|
2020-05-28 13:36:54 +00:00
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, sheet->GetPosition() );
|
2012-02-26 18:39:39 +00:00
|
|
|
screen->Append( marker );
|
2010-06-28 13:11:14 +00:00
|
|
|
}
|
2010-12-08 20:12:46 +00:00
|
|
|
|
2009-07-09 17:02:15 +00:00
|
|
|
err_count++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return err_count;
|
|
|
|
}
|
|
|
|
|
2009-11-03 13:26:31 +00:00
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
void ERC_TESTER::TestTextVars( KIGFX::WS_PROXY_VIEW_ITEM* aWorksheet )
|
2020-03-29 01:12:29 +00:00
|
|
|
{
|
2020-05-28 13:36:54 +00:00
|
|
|
WS_DRAW_ITEM_LIST wsItems;
|
|
|
|
|
2020-07-31 22:56:42 +00:00
|
|
|
auto unresolved = [this]( wxString str )
|
|
|
|
{
|
|
|
|
str = ExpandEnvVarSubstitutions( str, &m_schematic->Prj() );
|
|
|
|
return str.Matches( wxT( "*${*}*" ) );
|
|
|
|
};
|
|
|
|
|
2020-05-28 13:36:54 +00:00
|
|
|
if( aWorksheet )
|
|
|
|
{
|
|
|
|
wsItems.SetMilsToIUfactor( IU_PER_MILS );
|
2020-09-04 20:37:23 +00:00
|
|
|
wsItems.SetSheetNumber( 1 );
|
|
|
|
wsItems.SetSheetCount( 1 );
|
|
|
|
wsItems.SetFileName( "dummyFilename" );
|
|
|
|
wsItems.SetSheetName( "dummySheet" );
|
|
|
|
wsItems.SetSheetLayer( "dummyLayer" );
|
|
|
|
wsItems.SetProject( &m_schematic->Prj() );
|
2020-05-28 13:36:54 +00:00
|
|
|
wsItems.BuildWorkSheetGraphicList( aWorksheet->GetPageInfo(), aWorksheet->GetTitleBlock() );
|
|
|
|
}
|
|
|
|
|
2020-08-23 21:41:52 +00:00
|
|
|
SCH_SHEET_PATH savedCurrentSheet = m_schematic->CurrentSheet();
|
|
|
|
SCH_SHEET_LIST sheets = m_schematic->GetSheets();
|
2020-03-29 01:12:29 +00:00
|
|
|
|
2020-08-23 21:41:52 +00:00
|
|
|
for( SCH_SHEET_PATH& sheet : sheets )
|
2020-03-29 01:12:29 +00:00
|
|
|
{
|
2020-08-23 21:41:52 +00:00
|
|
|
m_schematic->SetCurrentSheet( sheet );
|
|
|
|
SCH_SCREEN* screen = sheet.LastScreen();
|
|
|
|
|
2020-03-29 01:12:29 +00:00
|
|
|
for( SCH_ITEM* item : screen->Items().OfType( SCH_LOCATE_ANY_T ) )
|
|
|
|
{
|
|
|
|
if( item->Type() == SCH_COMPONENT_T )
|
|
|
|
{
|
|
|
|
SCH_COMPONENT* component = static_cast<SCH_COMPONENT*>( item );
|
|
|
|
|
|
|
|
for( SCH_FIELD& field : component->GetFields() )
|
|
|
|
{
|
2020-07-31 22:56:42 +00:00
|
|
|
if( unresolved( field.GetShownText() ) )
|
2020-03-29 01:12:29 +00:00
|
|
|
{
|
2020-04-24 13:36:10 +00:00
|
|
|
wxPoint pos = field.GetPosition() - component->GetPosition();
|
|
|
|
pos = component->GetTransform().TransformCoordinate( pos );
|
|
|
|
pos += component->GetPosition();
|
|
|
|
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetItems( &field );
|
2020-03-29 01:12:29 +00:00
|
|
|
|
2020-04-24 13:36:10 +00:00
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, pos );
|
2020-03-29 01:12:29 +00:00
|
|
|
screen->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else if( item->Type() == SCH_SHEET_T )
|
|
|
|
{
|
2020-08-24 00:51:23 +00:00
|
|
|
SCH_SHEET* subSheet = static_cast<SCH_SHEET*>( item );
|
2020-03-29 01:12:29 +00:00
|
|
|
|
2020-08-24 00:51:23 +00:00
|
|
|
for( SCH_FIELD& field : subSheet->GetFields() )
|
2020-03-29 01:12:29 +00:00
|
|
|
{
|
2020-07-31 22:56:42 +00:00
|
|
|
if( unresolved( field.GetShownText() ) )
|
2020-03-29 01:12:29 +00:00
|
|
|
{
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetItems( &field );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, field.GetPosition() );
|
2020-03-29 01:12:29 +00:00
|
|
|
screen->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for( SCH_SHEET_PIN* pin : static_cast<SCH_SHEET*>( item )->GetPins() )
|
|
|
|
{
|
|
|
|
if( pin->GetShownText().Matches( wxT( "*${*}*" ) ) )
|
|
|
|
{
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetItems( pin );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, pin->GetPosition() );
|
2020-03-29 01:12:29 +00:00
|
|
|
screen->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else if( SCH_TEXT* text = dynamic_cast<SCH_TEXT*>( item ) )
|
|
|
|
{
|
|
|
|
if( text->GetShownText().Matches( wxT( "*${*}*" ) ) )
|
|
|
|
{
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetItems( text );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, text->GetPosition() );
|
2020-03-29 01:12:29 +00:00
|
|
|
screen->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-05-28 13:36:54 +00:00
|
|
|
|
|
|
|
for( WS_DRAW_ITEM_BASE* item = wsItems.GetFirst(); item; item = wsItems.GetNext() )
|
|
|
|
{
|
|
|
|
if( WS_DRAW_ITEM_TEXT* text = dynamic_cast<WS_DRAW_ITEM_TEXT*>( item ) )
|
|
|
|
{
|
|
|
|
if( text->GetShownText().Matches( wxT( "*${*}*" ) ) )
|
|
|
|
{
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
|
2020-05-28 13:36:54 +00:00
|
|
|
ercItem->SetErrorMessage( _( "Unresolved text variable in worksheet." ) );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, text->GetPosition() );
|
|
|
|
screen->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-03-29 01:12:29 +00:00
|
|
|
}
|
2020-08-23 21:41:52 +00:00
|
|
|
|
|
|
|
m_schematic->SetCurrentSheet( savedCurrentSheet );
|
2020-03-29 01:12:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
int ERC_TESTER::TestConflictingBusAliases()
|
2019-03-11 21:32:05 +00:00
|
|
|
{
|
2019-08-07 18:23:59 +00:00
|
|
|
wxString msg;
|
|
|
|
int err_count = 0;
|
2020-05-13 02:00:37 +00:00
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
SCH_SCREENS screens( m_schematic->Root() );
|
2019-08-07 18:23:59 +00:00
|
|
|
std::vector< std::shared_ptr<BUS_ALIAS> > aliases;
|
2019-03-11 21:32:05 +00:00
|
|
|
|
2020-03-29 01:12:29 +00:00
|
|
|
for( SCH_SCREEN* screen = screens.GetFirst(); screen != NULL; screen = screens.GetNext() )
|
2019-03-11 21:32:05 +00:00
|
|
|
{
|
2019-08-07 18:23:59 +00:00
|
|
|
std::unordered_set< std::shared_ptr<BUS_ALIAS> > screen_aliases = screen->GetBusAliases();
|
2019-03-11 21:32:05 +00:00
|
|
|
|
2019-08-07 18:23:59 +00:00
|
|
|
for( const std::shared_ptr<BUS_ALIAS>& alias : screen_aliases )
|
2019-03-11 21:32:05 +00:00
|
|
|
{
|
2019-08-07 18:23:59 +00:00
|
|
|
for( const std::shared_ptr<BUS_ALIAS>& test : aliases )
|
2019-03-11 21:32:05 +00:00
|
|
|
{
|
2019-08-07 18:23:59 +00:00
|
|
|
if( alias->GetName() == test->GetName() && alias->Members() != test->Members() )
|
2019-03-11 21:32:05 +00:00
|
|
|
{
|
2020-03-16 11:05:01 +00:00
|
|
|
msg.Printf( _( "Bus alias %s has conflicting definitions on %s and %s" ),
|
|
|
|
alias->GetName(),
|
|
|
|
alias->GetParent()->GetFileName(),
|
|
|
|
test->GetParent()->GetFileName() );
|
|
|
|
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_BUS_ALIAS_CONFLICT );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetErrorMessage( msg );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, wxPoint() );
|
2020-03-16 11:05:01 +00:00
|
|
|
test->GetParent()->Append( marker );
|
2019-03-11 21:32:05 +00:00
|
|
|
|
2019-08-07 18:23:59 +00:00
|
|
|
++err_count;
|
|
|
|
}
|
2019-03-11 21:32:05 +00:00
|
|
|
}
|
|
|
|
}
|
2019-08-07 18:23:59 +00:00
|
|
|
|
|
|
|
aliases.insert( aliases.end(), screen_aliases.begin(), screen_aliases.end() );
|
2019-03-11 21:32:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return err_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-07-03 21:08:17 +00:00
|
|
|
int ERC_TESTER::TestMultiunitFootprints()
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
2020-07-03 21:08:17 +00:00
|
|
|
SCH_SHEET_LIST sheets = m_schematic->GetSheets();
|
|
|
|
|
2018-01-19 15:12:36 +00:00
|
|
|
int errors = 0;
|
|
|
|
std::map<wxString, LIB_ID> footprints;
|
|
|
|
SCH_MULTI_UNIT_REFERENCE_MAP refMap;
|
2020-07-03 21:08:17 +00:00
|
|
|
sheets.GetMultiUnitComponents( refMap, true );
|
2018-01-19 15:12:36 +00:00
|
|
|
|
2020-08-29 13:41:47 +00:00
|
|
|
for( std::pair<const wxString, SCH_REFERENCE_LIST>& component : refMap )
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
2020-08-29 13:41:47 +00:00
|
|
|
SCH_REFERENCE_LIST& refList = component.second;
|
2018-01-19 15:12:36 +00:00
|
|
|
|
|
|
|
if( refList.GetCount() == 0 )
|
|
|
|
{
|
|
|
|
wxFAIL; // it should not happen
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Reference footprint
|
2020-04-24 13:36:10 +00:00
|
|
|
SCH_COMPONENT* unit = nullptr;
|
|
|
|
wxString unitName;
|
|
|
|
wxString unitFP;
|
2018-01-19 15:12:36 +00:00
|
|
|
|
2020-08-29 13:41:47 +00:00
|
|
|
for( unsigned i = 0; i < refList.GetCount(); ++i )
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
|
|
|
SCH_SHEET_PATH sheetPath = refList.GetItem( i ).GetSheetPath();
|
2020-08-29 13:41:47 +00:00
|
|
|
unitFP = refList.GetItem( i ).GetFootprint();
|
2018-01-19 15:12:36 +00:00
|
|
|
|
2020-04-24 13:36:10 +00:00
|
|
|
if( !unitFP.IsEmpty() )
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
2020-04-24 13:36:10 +00:00
|
|
|
unit = refList.GetItem( i ).GetComp();
|
2020-03-16 11:05:01 +00:00
|
|
|
unitName = unit->GetRef( &sheetPath, true );
|
2018-01-19 15:12:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-29 13:41:47 +00:00
|
|
|
for( unsigned i = 0; i < refList.GetCount(); ++i )
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
2020-03-16 11:05:01 +00:00
|
|
|
SCH_REFERENCE& secondRef = refList.GetItem( i );
|
|
|
|
SCH_COMPONENT* secondUnit = secondRef.GetComp();
|
2020-04-24 13:36:10 +00:00
|
|
|
wxString secondName = secondUnit->GetRef( &secondRef.GetSheetPath(), true );
|
2020-08-29 13:41:47 +00:00
|
|
|
const wxString secondFp = secondRef.GetFootprint();
|
2020-04-24 13:36:10 +00:00
|
|
|
wxString msg;
|
2020-03-16 11:05:01 +00:00
|
|
|
|
2020-09-20 01:20:41 +00:00
|
|
|
if( unit && !secondFp.IsEmpty() && unitFP != secondFp )
|
2018-01-19 15:12:36 +00:00
|
|
|
{
|
2020-04-24 13:36:10 +00:00
|
|
|
msg.Printf( _( "Different footprints assigned to %s and %s" ),
|
|
|
|
unitName, secondName );
|
|
|
|
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_DIFFERENT_UNIT_FP );
|
2020-04-24 13:36:10 +00:00
|
|
|
ercItem->SetErrorMessage( msg );
|
|
|
|
ercItem->SetItems( unit, secondUnit );
|
2020-03-16 11:05:01 +00:00
|
|
|
|
2020-04-24 13:36:10 +00:00
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, secondUnit->GetPosition() );
|
2020-03-16 11:05:01 +00:00
|
|
|
secondRef.GetSheetPath().LastScreen()->Append( marker );
|
2018-01-19 15:12:36 +00:00
|
|
|
|
|
|
|
++errors;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return errors;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-07-07 00:10:08 +00:00
|
|
|
int ERC_TESTER::TestNoConnectPins()
|
|
|
|
{
|
|
|
|
int err_count = 0;
|
|
|
|
|
|
|
|
for( const SCH_SHEET_PATH& sheet : m_schematic->GetSheets() )
|
|
|
|
{
|
|
|
|
std::map<wxPoint, std::vector<SCH_PIN*>> pinMap;
|
|
|
|
|
|
|
|
for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_COMPONENT_T ) )
|
|
|
|
{
|
|
|
|
SCH_COMPONENT* comp = static_cast<SCH_COMPONENT*>( item );
|
|
|
|
|
2020-08-21 15:54:24 +00:00
|
|
|
for( SCH_PIN* pin : comp->GetPins( &sheet ) )
|
2020-07-07 21:08:07 +00:00
|
|
|
{
|
|
|
|
if( pin->GetLibPin()->GetType() == ELECTRICAL_PINTYPE::PT_NC )
|
|
|
|
pinMap[pin->GetPosition()].emplace_back( pin );
|
|
|
|
}
|
2020-07-07 00:10:08 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for( auto& pair : pinMap )
|
|
|
|
{
|
|
|
|
if( pair.second.size() > 1 )
|
|
|
|
{
|
|
|
|
err_count++;
|
|
|
|
|
2020-08-11 13:33:16 +00:00
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_NOCONNECT_CONNECTED );
|
2020-07-07 00:10:08 +00:00
|
|
|
|
|
|
|
ercItem->SetItems( pair.second[0], pair.second[1],
|
|
|
|
pair.second.size() > 2 ? pair.second[2] : nullptr,
|
|
|
|
pair.second.size() > 3 ? pair.second[3] : nullptr );
|
|
|
|
ercItem->SetErrorMessage( _( "Pins with \"no connection\" type are connected" ) );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, pair.first );
|
|
|
|
sheet.LastScreen()->Append( marker );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return err_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-08-30 19:25:31 +00:00
|
|
|
int ERC_TESTER::TestPinToPin()
|
|
|
|
{
|
|
|
|
ERC_SETTINGS& settings = m_schematic->ErcSettings();
|
|
|
|
const NET_MAP& nets = m_schematic->ConnectionGraph()->GetNetMap();
|
|
|
|
|
|
|
|
int errors = 0;
|
|
|
|
|
|
|
|
for( const std::pair<NET_NAME_CODE, std::vector<CONNECTION_SUBGRAPH*>> net : nets )
|
|
|
|
{
|
|
|
|
std::vector<SCH_PIN*> pins;
|
|
|
|
std::unordered_map<EDA_ITEM*, SCH_SCREEN*> pinToScreenMap;
|
|
|
|
|
|
|
|
for( CONNECTION_SUBGRAPH* subgraph: net.second )
|
|
|
|
{
|
|
|
|
for( EDA_ITEM* item : subgraph->m_items )
|
|
|
|
{
|
|
|
|
if( item->Type() == SCH_PIN_T )
|
|
|
|
{
|
|
|
|
pins.emplace_back( static_cast<SCH_PIN*>( item ) );
|
|
|
|
pinToScreenMap[item] = subgraph->m_sheet.LastScreen();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Single-pin nets are handled elsewhere
|
|
|
|
if( pins.size() < 2 )
|
|
|
|
continue;
|
|
|
|
|
|
|
|
std::set<std::pair<SCH_PIN*, SCH_PIN*>> tested;
|
|
|
|
|
|
|
|
for( SCH_PIN* refPin : pins )
|
|
|
|
{
|
|
|
|
ELECTRICAL_PINTYPE refType = refPin->GetType();
|
|
|
|
|
|
|
|
for( SCH_PIN* testPin : pins )
|
|
|
|
{
|
|
|
|
if( testPin == refPin )
|
|
|
|
continue;
|
|
|
|
|
|
|
|
std::pair<SCH_PIN*, SCH_PIN*> pair1 = std::make_pair( refPin, testPin );
|
|
|
|
std::pair<SCH_PIN*, SCH_PIN*> pair2 = std::make_pair( testPin, refPin );
|
|
|
|
|
|
|
|
if( tested.count( pair1 ) || tested.count( pair2 ) )
|
|
|
|
continue;
|
|
|
|
|
|
|
|
tested.insert( pair1 );
|
|
|
|
tested.insert( pair2 );
|
|
|
|
|
|
|
|
ELECTRICAL_PINTYPE testType = testPin->GetType();
|
|
|
|
|
|
|
|
PIN_ERROR erc = settings.GetPinMapValue( refType, testType );
|
|
|
|
|
|
|
|
if( erc != PIN_ERROR::OK )
|
|
|
|
{
|
|
|
|
std::shared_ptr<ERC_ITEM> ercItem =
|
|
|
|
ERC_ITEM::Create( erc == PIN_ERROR::WARNING ? ERCE_PIN_TO_PIN_WARNING :
|
|
|
|
ERCE_PIN_TO_PIN_ERROR );
|
|
|
|
ercItem->SetItems( refPin, testPin );
|
|
|
|
|
|
|
|
ercItem->SetErrorMessage(
|
|
|
|
wxString::Format( _( "Pins of type %s and %s are connected" ),
|
|
|
|
ElectricalPinTypeGetText( refType ),
|
|
|
|
ElectricalPinTypeGetText( testType ) ) );
|
|
|
|
|
|
|
|
SCH_MARKER* marker =
|
|
|
|
new SCH_MARKER( ercItem, refPin->GetTransformedPosition() );
|
|
|
|
pinToScreenMap[refPin]->Append( marker );
|
|
|
|
errors++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return errors;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
int ERC_TESTER::TestMultUnitPinConflicts()
|
|
|
|
{
|
|
|
|
const NET_MAP& nets = m_schematic->ConnectionGraph()->GetNetMap();
|
|
|
|
|
|
|
|
int errors = 0;
|
|
|
|
|
|
|
|
std::unordered_map<wxString, std::pair<wxString, SCH_PIN*>> pinToNetMap;
|
|
|
|
|
|
|
|
for( const std::pair<NET_NAME_CODE, std::vector<CONNECTION_SUBGRAPH*>> net : nets )
|
|
|
|
{
|
|
|
|
const wxString& netName = net.first.first;
|
|
|
|
std::vector<SCH_PIN*> pins;
|
|
|
|
|
|
|
|
for( CONNECTION_SUBGRAPH* subgraph : net.second )
|
|
|
|
{
|
|
|
|
for( EDA_ITEM* item : subgraph->m_items )
|
|
|
|
{
|
|
|
|
if( item->Type() == SCH_PIN_T )
|
|
|
|
{
|
|
|
|
SCH_PIN* pin = static_cast<SCH_PIN*>( item );
|
|
|
|
|
|
|
|
if( !pin->GetLibPin()->GetParent()->IsMulti() )
|
|
|
|
continue;
|
|
|
|
|
|
|
|
wxString name = ( pin->GetParentComponent()->GetRef( &subgraph->m_sheet ) +
|
2020-09-03 21:30:13 +00:00
|
|
|
":" + pin->GetNumber() );
|
2020-08-30 19:25:31 +00:00
|
|
|
|
|
|
|
if( !pinToNetMap.count( name ) )
|
|
|
|
{
|
|
|
|
pinToNetMap[name] = std::make_pair( netName, pin );
|
|
|
|
}
|
|
|
|
else if( pinToNetMap[name].first != netName )
|
|
|
|
{
|
|
|
|
std::shared_ptr<ERC_ITEM> ercItem =
|
|
|
|
ERC_ITEM::Create( ERCE_DIFFERENT_UNIT_NET );
|
|
|
|
|
|
|
|
ercItem->SetErrorMessage( wxString::Format(
|
|
|
|
_( "Pin %s is connected to both %s and %s" ),
|
|
|
|
pin->GetNumber(), netName, pinToNetMap[name].first ) );
|
|
|
|
|
|
|
|
ercItem->SetItems( pin, pinToNetMap[name].second );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem,
|
|
|
|
pin->GetTransformedPosition() );
|
|
|
|
subgraph->m_sheet.LastScreen()->Append( marker );
|
2020-10-07 13:15:31 +00:00
|
|
|
errors += 1;
|
2020-08-30 19:25:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return errors;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
int ERC_TESTER::TestSimilarLabels()
|
2015-12-20 12:40:17 +00:00
|
|
|
{
|
2020-08-30 19:42:46 +00:00
|
|
|
const NET_MAP& nets = m_schematic->ConnectionGraph()->GetNetMap();
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
int errors = 0;
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
std::unordered_map<wxString, SCH_TEXT*> labelMap;
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
for( const std::pair<NET_NAME_CODE, std::vector<CONNECTION_SUBGRAPH*>> net : nets )
|
2015-12-20 12:40:17 +00:00
|
|
|
{
|
2020-08-30 19:42:46 +00:00
|
|
|
std::vector<SCH_PIN*> pins;
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
for( CONNECTION_SUBGRAPH* subgraph : net.second )
|
2015-12-20 12:40:17 +00:00
|
|
|
{
|
2020-08-30 19:42:46 +00:00
|
|
|
for( EDA_ITEM* item : subgraph->m_items )
|
2015-12-20 12:40:17 +00:00
|
|
|
{
|
2020-08-30 19:42:46 +00:00
|
|
|
switch( item->Type() )
|
|
|
|
{
|
|
|
|
case SCH_LABEL_T:
|
|
|
|
case SCH_HIER_LABEL_T:
|
|
|
|
case SCH_GLOBAL_LABEL_T:
|
|
|
|
{
|
|
|
|
SCH_TEXT* text = static_cast<SCH_TEXT*>( item );
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
wxString normalized = text->GetShownText().Lower();
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
if( !labelMap.count( normalized ) )
|
|
|
|
{
|
|
|
|
labelMap[normalized] = text;
|
|
|
|
}
|
|
|
|
else if( labelMap.at( normalized )->GetShownText() != text->GetShownText() )
|
|
|
|
{
|
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_SIMILAR_LABELS );
|
|
|
|
ercItem->SetItems( text, labelMap.at( normalized ) );
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, text->GetPosition() );
|
|
|
|
subgraph->m_sheet.LastScreen()->Append( marker );
|
2020-10-07 13:15:31 +00:00
|
|
|
errors += 1;
|
2020-08-30 19:42:46 +00:00
|
|
|
}
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
break;
|
|
|
|
}
|
2015-12-20 12:40:17 +00:00
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
default:
|
|
|
|
break;
|
2015-12-20 12:40:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-30 19:42:46 +00:00
|
|
|
return errors;
|
2015-12-20 12:40:17 +00:00
|
|
|
}
|
2020-10-07 13:15:31 +00:00
|
|
|
|
|
|
|
|
|
|
|
int ERC_TESTER::TestLibSymbolIssues()
|
|
|
|
{
|
|
|
|
wxCHECK( m_schematic, 0 );
|
|
|
|
|
|
|
|
wxString msg;
|
|
|
|
int err_count = 0;
|
|
|
|
|
|
|
|
SCH_SCREENS screens( m_schematic->Root() );
|
|
|
|
|
|
|
|
for( SCH_SCREEN* screen = screens.GetFirst(); screen != NULL; screen = screens.GetNext() )
|
|
|
|
{
|
|
|
|
for( SCH_ITEM* item : screen->Items().OfType( SCH_COMPONENT_T ) )
|
|
|
|
{
|
|
|
|
SCH_COMPONENT* symbol = dynamic_cast<SCH_COMPONENT*>( item );
|
|
|
|
|
|
|
|
wxCHECK2( symbol, continue );
|
|
|
|
|
|
|
|
LIB_PART* libSymbolInSchematic = screen->GetLibSymbols()[
|
|
|
|
symbol->GetLibId().GetUniStringLibId() ];
|
|
|
|
|
|
|
|
wxCHECK2( libSymbolInSchematic, continue );
|
|
|
|
|
|
|
|
LIB_PART* libSymbol = SchGetLibPart( symbol->GetLibId(),
|
|
|
|
m_schematic->Prj().SchSymbolLibTable() );
|
|
|
|
|
|
|
|
if( libSymbol == nullptr )
|
|
|
|
{
|
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_ISSUES );
|
|
|
|
ercItem->SetItems( symbol );
|
|
|
|
msg.Printf( "Library symbol link \"%s\" cannot be found in symbol library table",
|
|
|
|
symbol->GetLibId().GetUniStringLibId() );
|
|
|
|
ercItem->SetErrorMessage( msg );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, symbol->GetPosition() );
|
|
|
|
screen->Append( marker );
|
|
|
|
err_count += 1;
|
|
|
|
}
|
|
|
|
else if( *libSymbol != *libSymbolInSchematic )
|
|
|
|
{
|
|
|
|
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_ISSUES );
|
|
|
|
ercItem->SetItems( symbol );
|
|
|
|
msg.Printf( "Library symbol \"%s\" has been modified",
|
|
|
|
symbol->GetLibId().GetUniStringLibId() );
|
|
|
|
ercItem->SetErrorMessage( msg );
|
|
|
|
|
|
|
|
SCH_MARKER* marker = new SCH_MARKER( ercItem, symbol->GetPosition() );
|
|
|
|
screen->Append( marker );
|
|
|
|
err_count += 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return err_count;
|
|
|
|
}
|