From 0521b63503c2b70864e22e28a9e9a6408c4fcd33 Mon Sep 17 00:00:00 2001 From: Maciej Suminski Date: Mon, 5 Mar 2018 16:27:07 +0100 Subject: [PATCH] Remove negation from PCB_BASE_FRAME::PlaceModule() parameter Negated parameters make code confusing. Now the parameter description is accurate. --- include/pcb_base_frame.h | 4 ++-- pcbnew/dialogs/dialog_exchange_footprints.cpp | 2 +- pcbnew/pcb_footprint_edit_utils.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/pcb_base_frame.h b/include/pcb_base_frame.h index b17e97974b..822cf79163 100644 --- a/include/pcb_base_frame.h +++ b/include/pcb_base_frame.h @@ -333,9 +333,9 @@ public: * @param aModule A MODULE object point of the module to be placed. * @param aDC A wxDC object point of the device context to draw \a aModule on * or NULL if no display screen need updated. - * @param aDoNotRecreateRatsnest A bool true redraws the module rats nest. + * @param aRecreateRatsnest A bool true redraws the module rats nest. */ - void PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreateRatsnest = false ); + void PlaceModule( MODULE* aModule, wxDC* aDC, bool aRecreateRatsnest = true ); // module texts void RotateTextModule( TEXTE_MODULE* Text, wxDC* DC ); diff --git a/pcbnew/dialogs/dialog_exchange_footprints.cpp b/pcbnew/dialogs/dialog_exchange_footprints.cpp index 7b4a058b1d..a82bd0f5e6 100644 --- a/pcbnew/dialogs/dialog_exchange_footprints.cpp +++ b/pcbnew/dialogs/dialog_exchange_footprints.cpp @@ -467,7 +467,7 @@ void PCB_EDIT_FRAME::Exchange_Module( MODULE* aOldModule, /* place module without ratsnest refresh: this will be made later * when all modules are on board */ - PlaceModule( aNewModule, NULL, true ); + PlaceModule( aNewModule, NULL, false ); // Copy full placement and pad net names (when possible) // but not local settings like clearances (use library values) diff --git a/pcbnew/pcb_footprint_edit_utils.cpp b/pcbnew/pcb_footprint_edit_utils.cpp index b52abae79c..d54c806310 100644 --- a/pcbnew/pcb_footprint_edit_utils.cpp +++ b/pcbnew/pcb_footprint_edit_utils.cpp @@ -349,7 +349,7 @@ void PCB_EDIT_FRAME::Change_Side_Module( MODULE* Module, wxDC* DC ) } -void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreateRatsnest ) +void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aRecreateRatsnest ) { wxPoint newpos; @@ -413,7 +413,7 @@ void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreat m_Pcb->GetConnectivity()->Update( aModule ); - if( GetBoard()->IsElementVisible( LAYER_RATSNEST ) && !aDoNotRecreateRatsnest ) + if( GetBoard()->IsElementVisible( LAYER_RATSNEST ) && aRecreateRatsnest ) Compile_Ratsnest( aDC, true ); if( aDC )