From 0683313ecbc8dfec626d58352d64a80e75b1ec8a Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Tue, 10 Oct 2023 15:24:58 +0100
Subject: [PATCH] Fix ghosted image while moving meander.

Also cleans up some undo description strings.  (They go in the menu
so they should be title-caps.)
---
 pcbnew/generators/pcb_generator_meanders.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/pcbnew/generators/pcb_generator_meanders.cpp b/pcbnew/generators/pcb_generator_meanders.cpp
index d698f29b09..f87d6e5c02 100644
--- a/pcbnew/generators/pcb_generator_meanders.cpp
+++ b/pcbnew/generators/pcb_generator_meanders.cpp
@@ -622,7 +622,7 @@ public:
             {
                 if( li->Parent() )
                 {
-                    aFrame->GetCanvas()->GetView()->Hide( li->Parent(), true );
+                    li->Parent()->SetForcedTransparency( 1.0 );
                     m_removedItems.insert( li->Parent() );
                 }
             }
@@ -698,8 +698,7 @@ public:
 
             for( BOARD_ITEM* item : m_removedItems )
             {
-                item->ClearSelected();
-                aFrame->GetCanvas()->GetView()->Hide( item, false );
+                item->SetForcedTransparency( 0.0 );
                 aCommit->Remove( item );
             }
 
@@ -707,25 +706,28 @@ public:
 
             for( BOARD_ITEM* item : routerRemovedItems )
             {
-                item->ClearSelected();
                 aCommit->Remove( item );
             }
 
             for( BOARD_ITEM* item : routerAddedItems )
             {
+                item->SetSelected();
                 AddItem( item );
                 aCommit->Add( item );
             }
         }
 
-        aCommit->Push( aCommitMsg, aCommitFlags );
+        if( aCommitMsg.IsEmpty() )
+            aCommit->Push( _( "Edit Meander" ), aCommitFlags );
+        else
+            aCommit->Push( aCommitMsg, aCommitFlags );
     }
 
     void EditRevert( GENERATOR_TOOL* aTool, BOARD* aBoard, PCB_BASE_EDIT_FRAME* aFrame,
                      BOARD_COMMIT* aCommit ) override
     {
         for( BOARD_ITEM* item : m_removedItems )
-            aFrame->GetCanvas()->GetView()->Hide( item, false );
+            item->SetForcedTransparency( 0.0 );
 
         m_removedItems.clear();
 
@@ -870,8 +872,6 @@ public:
     {
         m_origin += aMoveVector;
         m_end += aMoveVector;
-
-        PCB_GROUP::Move( aMoveVector );
     }
 
     const BOX2I GetBoundingBox() const override { return GetRectShape().BBox(); }
@@ -1056,7 +1056,7 @@ public:
 
             FromMeanderSettings( settings );
 
-            commit.Push( _( "Edit meander properties" ) );
+            commit.Push( _( "Edit Meander Properties" ) );
         }
 
         aEditFrame->GetToolManager()->PostAction<PCB_GENERATOR*>( PCB_ACTIONS::regenerateItem,