From 08a00633b190c1c99c4004264909e519a870406d Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sun, 17 Dec 2023 21:46:10 +0000 Subject: [PATCH] Make sure child items get edit flags cleared in commit. In the footprint editor, in particular, we often just add the parent footprint to the commit rather than the actual modified item(s). Fixes https://gitlab.com/kicad/code/kicad/-/issues/16389 --- pcbnew/board_commit.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pcbnew/board_commit.cpp b/pcbnew/board_commit.cpp index 6c92322f5c..361a6bd92e 100644 --- a/pcbnew/board_commit.cpp +++ b/pcbnew/board_commit.cpp @@ -451,6 +451,11 @@ void BOARD_COMMIT::Push( const wxString& aMessage, int aCommitFlags ) } boardItem->ClearEditFlags(); + boardItem->RunOnDescendants( + [&]( BOARD_ITEM* item ) + { + item->ClearEditFlags(); + } ); } if( bulkAddedItems.size() > 0 )