From 08c54e8acf27fbf35419c83684b0c137b841c42c Mon Sep 17 00:00:00 2001 From: Maciej Suminski Date: Mon, 24 Jun 2013 10:21:34 +0200 Subject: [PATCH] Passing COLOR4D parameter using constant reference. --- common/gal/cairo/cairo_gal.cpp | 6 +++--- common/gal/opengl/opengl_gal.cpp | 6 +++--- include/gal/cairo/cairo_gal.h | 6 +++--- include/gal/graphics_abstraction_layer.h | 10 +++++----- include/gal/opengl/opengl_gal.h | 6 +++--- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/common/gal/cairo/cairo_gal.cpp b/common/gal/cairo/cairo_gal.cpp index a9b898355d..9938df5d3e 100644 --- a/common/gal/cairo/cairo_gal.cpp +++ b/common/gal/cairo/cairo_gal.cpp @@ -413,7 +413,7 @@ void CAIRO_GAL::DrawCurve( const VECTOR2D& aStartPoint, const VECTOR2D& aControl } -void CAIRO_GAL::SetBackgroundColor( COLOR4D aColor ) +void CAIRO_GAL::SetBackgroundColor( const COLOR4D& aColor ) { backgroundColor = aColor; } @@ -449,7 +449,7 @@ void CAIRO_GAL::SetIsStroke( bool aIsStrokeEnabled ) } -void CAIRO_GAL::SetStrokeColor( COLOR4D aColor ) +void CAIRO_GAL::SetStrokeColor( const COLOR4D& aColor ) { storePath(); @@ -468,7 +468,7 @@ void CAIRO_GAL::SetStrokeColor( COLOR4D aColor ) } -void CAIRO_GAL::SetFillColor( COLOR4D aColor ) +void CAIRO_GAL::SetFillColor( const COLOR4D& aColor ) { storePath(); fillColor = aColor; diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp index 1bf42aa497..63068170c9 100644 --- a/common/gal/opengl/opengl_gal.cpp +++ b/common/gal/opengl/opengl_gal.cpp @@ -1440,7 +1440,7 @@ void OPENGL_GAL::DrawCurve( const VECTOR2D& aStartPoint, const VECTOR2D& aContro } -void OPENGL_GAL::SetStrokeColor( COLOR4D aColor ) +void OPENGL_GAL::SetStrokeColor( const COLOR4D& aColor ) { isSetAttributes = true; strokeColor = aColor; @@ -1450,14 +1450,14 @@ void OPENGL_GAL::SetStrokeColor( COLOR4D aColor ) } -void OPENGL_GAL::SetFillColor( COLOR4D aColor ) +void OPENGL_GAL::SetFillColor( const COLOR4D& aColor ) { isSetAttributes = true; fillColor = aColor; } -void OPENGL_GAL::SetBackgroundColor( COLOR4D aColor ) +void OPENGL_GAL::SetBackgroundColor( const COLOR4D& aColor ) { isSetAttributes = true; backgroundColor = aColor; diff --git a/include/gal/cairo/cairo_gal.h b/include/gal/cairo/cairo_gal.h index f042e962eb..582db3b654 100644 --- a/include/gal/cairo/cairo_gal.h +++ b/include/gal/cairo/cairo_gal.h @@ -148,16 +148,16 @@ public: virtual void SetIsStroke( bool aIsStrokeEnabled ); /// @copydoc GAL::SetFillColor() - virtual void SetFillColor( COLOR4D aColor ); + virtual void SetFillColor( const COLOR4D& aColor ); /// @copydoc GAL::SetStrokeColor() - virtual void SetStrokeColor( COLOR4D aColor ); + virtual void SetStrokeColor( const COLOR4D& aColor ); /// @copydoc GAL::GetStrokeColor() COLOR4D GetStrokeColor(); /// @copydoc GAL::SetBackgroundColor() - virtual void SetBackgroundColor( COLOR4D aColor ); + virtual void SetBackgroundColor( const COLOR4D& aColor ); /// @copydoc GAL::SetLineCap() virtual void SetLineCap( LineCap aLineCap ); diff --git a/include/gal/graphics_abstraction_layer.h b/include/gal/graphics_abstraction_layer.h index 79bc8e2a8e..747525dd88 100644 --- a/include/gal/graphics_abstraction_layer.h +++ b/include/gal/graphics_abstraction_layer.h @@ -219,7 +219,7 @@ public: * * @param aColor is the color for filling. */ - inline virtual void SetFillColor( COLOR4D aColor ) + inline virtual void SetFillColor( const COLOR4D& aColor ) { fillColor = aColor; } @@ -229,7 +229,7 @@ public: * * @param aColor is the color for stroking the outline. */ - inline virtual void SetStrokeColor( COLOR4D aColor ) + inline virtual void SetStrokeColor( const COLOR4D& aColor ) { strokeColor = aColor; } @@ -249,7 +249,7 @@ public: * * @param aColor is the color for background filling. */ - virtual void SetBackgroundColor( COLOR4D aColor ) = 0; + virtual void SetBackgroundColor( const COLOR4D& aColor ) = 0; /** * @brief Set the style of the line caps. @@ -569,7 +569,7 @@ public: * * @param aGridColor is the grid color, it should have a low alpha value for the best effect. */ - inline void SetGridColor( COLOR4D aGridColor ) + inline void SetGridColor( const COLOR4D& aGridColor ) { gridColor = aGridColor; } @@ -637,7 +637,7 @@ public: * * @param aCursorColor is the color of the cursor. */ - inline void SetCursorColor( COLOR4D aCursorColor ) + inline void SetCursorColor( const COLOR4D& aCursorColor ) { cursorColor = aCursorColor; } diff --git a/include/gal/opengl/opengl_gal.h b/include/gal/opengl/opengl_gal.h index ca137752d9..0fc4b0a3cf 100644 --- a/include/gal/opengl/opengl_gal.h +++ b/include/gal/opengl/opengl_gal.h @@ -164,16 +164,16 @@ public: } /// @copydoc GAL::SetFillColor() - virtual void SetFillColor( COLOR4D aColor ); + virtual void SetFillColor( const COLOR4D& aColor ); /// @copydoc GAL::SetStrokeColor() - virtual void SetStrokeColor( COLOR4D aColor ); + virtual void SetStrokeColor( const COLOR4D& aColor ); /// @copydoc GAL::GetStrokeColor() COLOR4D GetStrokeColor(); /// @copydoc GAL::SetBackgroundColor() - virtual void SetBackgroundColor( COLOR4D aColor ); + virtual void SetBackgroundColor( const COLOR4D& aColor ); /// @copydoc GAL::SetLineCap() virtual void SetLineCap( LineCap aLineCap )