From 0a4812be075bb72767dafafd63e08fc24d5a4ea1 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Sun, 6 Jan 2019 08:53:16 -0800 Subject: [PATCH] eagle: Set default pin type Eagle 7.4 DTD defines pin direction as optional with a default of IO (bidirectional). Fixes: lp:1808585 * https://bugs.launchpad.net/kicad/+bug/1808585 --- eeschema/sch_eagle_plugin.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eeschema/sch_eagle_plugin.cpp b/eeschema/sch_eagle_plugin.cpp index c0a3f6e854..3e4d0b49d3 100644 --- a/eeschema/sch_eagle_plugin.cpp +++ b/eeschema/sch_eagle_plugin.cpp @@ -1386,6 +1386,8 @@ bool SCH_EAGLE_PLUGIN::loadSymbol( wxXmlNode* aSymbolNode, std::unique_ptr pin( loadPin( aPart, currentNode, &ePin, aGateNumber ) ); pincount++; + pin->SetType( PIN_BIDI ); + if( ePin.direction ) { const std::map pinDirectionsMap = @@ -1397,8 +1399,6 @@ bool SCH_EAGLE_PLUGIN::loadSymbol( wxXmlNode* aSymbolNode, std::unique_ptrSetType( PIN_UNSPECIFIED ); - for( const auto& pinDir : pinDirectionsMap ) { if( ePin.direction->Lower() == pinDir.first )