From 0b03d8a5ffebb9da980f06f51ed71bd57cf879b8 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Sun, 20 Sep 2020 11:32:47 +0200 Subject: [PATCH] Fix a few Coverity warnings. --- 3d-viewer/3d_canvas/board_adapter.cpp | 12 ++++++++++++ qa/drc_proto/drc_proto_test.cpp | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/3d-viewer/3d_canvas/board_adapter.cpp b/3d-viewer/3d_canvas/board_adapter.cpp index a034d73899..9099e3b269 100644 --- a/3d-viewer/3d_canvas/board_adapter.cpp +++ b/3d-viewer/3d_canvas/board_adapter.cpp @@ -125,6 +125,18 @@ BOARD_ADAPTER::BOARD_ADAPTER() : m_F_Cu_PlatedPads_poly = nullptr; m_B_Cu_PlatedPads_poly = nullptr; + + // Avoid raytracing options not initialized: + m_raytrace_nrsamples_shadows = 0; + m_raytrace_nrsamples_reflections = 0; + m_raytrace_nrsamples_refractions = 0; + + m_raytrace_spread_shadows = 0.0; + m_raytrace_spread_reflections = 0.0; + m_raytrace_spread_refractions = 0.0; + + m_raytrace_recursivelevel_reflections = 0; + m_raytrace_recursivelevel_refractions = 0; } diff --git a/qa/drc_proto/drc_proto_test.cpp b/qa/drc_proto/drc_proto_test.cpp index 36d52aea75..81b92d64f8 100644 --- a/qa/drc_proto/drc_proto_test.cpp +++ b/qa/drc_proto/drc_proto_test.cpp @@ -137,9 +137,11 @@ public: { switch( aSeverity ) { - case RPT_SEVERITY_ERROR: + case RPT_SEVERITY_ERROR: m_log->SetColor( CONSOLE_LOG::RED ); m_log->Print("ERROR | "); + break; + default: m_log->SetColor( CONSOLE_LOG::DEFAULT ); m_log->Print(" | ");