From 1024584cacd4fff52ca14b28aa19b1ef4b3890c0 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Mon, 12 Oct 2020 18:56:19 +0100 Subject: [PATCH] Don't show netclass placeholders in track & via props dialog. We have a separate checkbox for that. Fixes https://gitlab.com/kicad/code/kicad/issues/5951 --- pcbnew/dialogs/dialog_track_via_properties.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pcbnew/dialogs/dialog_track_via_properties.cpp b/pcbnew/dialogs/dialog_track_via_properties.cpp index 5e6a01a5e5..e01b53f88f 100644 --- a/pcbnew/dialogs/dialog_track_via_properties.cpp +++ b/pcbnew/dialogs/dialog_track_via_properties.cpp @@ -231,11 +231,12 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen int viaSelection = wxNOT_FOUND; - for( unsigned ii = 0; ii < aParent->GetDesignSettings().m_ViasDimensionsList.size(); ii++ ) + // 0 is the netclass place-holder + for( unsigned ii = 1; ii < aParent->GetDesignSettings().m_ViasDimensionsList.size(); ii++ ) { VIA_DIMENSION* viaDimension = &aParent->GetDesignSettings().m_ViasDimensionsList[ii]; wxString msg = StringFromValue( m_units, viaDimension->m_Diameter, false ) - + " / " + StringFromValue( m_units, viaDimension->m_Drill, false ); + + " / " + StringFromValue( m_units, viaDimension->m_Drill, false ); m_DesignRuleViasCtrl->Append( msg, viaDimension ); if( viaSelection == wxNOT_FOUND @@ -282,7 +283,8 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen int widthSelection = wxNOT_FOUND; - for( unsigned ii = 0; ii < aParent->GetDesignSettings().m_TrackWidthList.size(); ii++ ) + // 0 is the netclass place-holder + for( unsigned ii = 1; ii < aParent->GetDesignSettings().m_TrackWidthList.size(); ii++ ) { int width = aParent->GetDesignSettings().m_TrackWidthList[ii]; wxString msg = StringFromValue( m_units, width, false );