From 12357cfba64edfb2c3a36ebded5c14234645e60b Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Fri, 26 Jan 2024 10:19:58 +0100 Subject: [PATCH] symbol checker: do not forget to display error messages about pins not on grid. Fixes #16759 https://gitlab.com/kicad/code/kicad/-/issues/16759 --- eeschema/symbol_checker.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/eeschema/symbol_checker.cpp b/eeschema/symbol_checker.cpp index b7038803c7..a4d28be657 100644 --- a/eeschema/symbol_checker.cpp +++ b/eeschema/symbol_checker.cpp @@ -292,6 +292,8 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector& aMessages, || ( (pin->GetPosition().y % clamped_grid_size) != 0 ) ) { // pin is off grid + msg.Empty(); + if( aSymbol->HasConversion() && pin->GetConvert() ) { if( aSymbol->GetUnitCount() <= 1 ) @@ -312,7 +314,7 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector& aMessages, aUnitsProvider->MessageTextFromValue( pin->GetPosition().x ), aUnitsProvider->MessageTextFromValue( -pin->GetPosition().y ), 'A' + pin->GetUnit() - 1 ); - } + } } else { @@ -335,6 +337,9 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector& aMessages, 'A' + pin->GetUnit() - 1 ); } } + + msg += wxT( "

" ); + aMessages.push_back( msg ); } }