From 16a70dd2677fa8a3ac8d403518e5985e4f7854df Mon Sep 17 00:00:00 2001 From: Dick Hollenbeck Date: Fri, 3 Jan 2014 17:19:54 -0600 Subject: [PATCH] comment out broken tool_modview.cpp's useless footprint select button. somebody needs to fix this. --- pcbnew/modview_frame.cpp | 7 +++---- pcbnew/tool_modview.cpp | 13 +++++++++++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/pcbnew/modview_frame.cpp b/pcbnew/modview_frame.cpp index 08b93c170f..83428fdaf2 100644 --- a/pcbnew/modview_frame.cpp +++ b/pcbnew/modview_frame.cpp @@ -112,11 +112,10 @@ static wxAcceleratorEntry accels[] = wxAcceleratorEntry( wxACCEL_NORMAL, WXK_SPACE, ID_SET_RELATIVE_OFFSET ) }; -#define ACCEL_TABLE_CNT ( sizeof( accels ) / sizeof( wxAcceleratorEntry ) ) -#define EXTRA_BORDER_SIZE 2 +#define EXTRA_BORDER_SIZE 2 -#define FOOTPRINT_VIEWER_FRAME_NAME wxT( "ModViewFrame" ) +#define FOOTPRINT_VIEWER_FRAME_NAME wxT( "ModViewFrame" ) FOOTPRINT_VIEWER_FRAME::FOOTPRINT_VIEWER_FRAME( PCB_BASE_FRAME* aParent, FP_LIB_TABLE* aTable, @@ -125,7 +124,7 @@ FOOTPRINT_VIEWER_FRAME::FOOTPRINT_VIEWER_FRAME( PCB_BASE_FRAME* aParent, PCB_BASE_FRAME( aParent, MODULE_VIEWER_FRAME_TYPE, _( "Footprint Library Browser" ), wxDefaultPosition, wxDefaultSize, aStyle, GetFootprintViewerFrameName() ) { - wxAcceleratorTable table( ACCEL_TABLE_CNT, accels ); + wxAcceleratorTable table( DIM( accels ), accels ); m_footprintLibTable = aTable; m_FrameName = GetFootprintViewerFrameName(); diff --git a/pcbnew/tool_modview.cpp b/pcbnew/tool_modview.cpp index 8d40fa2601..5376497e21 100644 --- a/pcbnew/tool_modview.cpp +++ b/pcbnew/tool_modview.cpp @@ -97,9 +97,18 @@ void FOOTPRINT_VIEWER_FRAME::ReCreateHToolbar() { // The library browser is called from a "load component" command m_mainToolBar->AddSeparator(); - m_mainToolBar->AddTool( ID_MODVIEW_FOOTPRINT_EXPORT_TO_BOARD, - wxEmptyString, KiBitmap( export_footprint_names_xpm ), + + /* + this ID_MODVIEW_FOOTPRINT_EXPORT_TO_BOARD control + is broken it does not lead to a fetched footprint on linux, either 3.0 nor 2.8 wx: + and I really don't like the drop down menu here: + + whoever broke it, please fix it: + + m_mainToolBar->AddTool( ID_MODVIEW_FOOTPRINT_EXPORT_TO_BOARD, wxEmptyString, + KiBitmap( export_footprint_names_xpm ), _( "Insert footprint in board" ) ); + */ } // after adding the buttons to the toolbar, must call Realize() to