From 20c1492b6ac36d6e97a2dc357d8e96c3c3294d6d Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Mon, 20 Jul 2020 11:26:48 +0100 Subject: [PATCH] Initialize pointers to nullptr in copy constructor Fixes https://gitlab.com/kicad/code/kicad/issues/4940 --- pcbnew/class_zone.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pcbnew/class_zone.cpp b/pcbnew/class_zone.cpp index 536df06778..39edecf703 100644 --- a/pcbnew/class_zone.cpp +++ b/pcbnew/class_zone.cpp @@ -72,7 +72,9 @@ ZONE_CONTAINER::ZONE_CONTAINER( BOARD_ITEM_CONTAINER* aParent, bool aInModule ) ZONE_CONTAINER::ZONE_CONTAINER( const ZONE_CONTAINER& aZone ) - : BOARD_CONNECTED_ITEM( aZone.GetParent(), PCB_ZONE_AREA_T ) + : BOARD_CONNECTED_ITEM( aZone.GetParent(), PCB_ZONE_AREA_T ), + m_Poly( nullptr ), + m_CornerSelection( nullptr ) { initDataFromSrcInCopyCtor( aZone ); } @@ -143,6 +145,7 @@ void ZONE_CONTAINER::initDataFromSrcInCopyCtor( const ZONE_CONTAINER& aZone ) m_HatchFillTypeSmoothingValue = aZone.m_HatchFillTypeSmoothingValue; // For corner moving, corner index to drag, or nullptr if no selection + delete m_CornerSelection; m_CornerSelection = nullptr; for( PCB_LAYER_ID layer : aZone.GetLayerSet().Seq() )