From 24435df6b0e2cea03f371ae3bd4b51c6755109da Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Thu, 7 Jan 2021 20:40:50 -0500 Subject: [PATCH] Don't update 3D view on cursor movement Our rendering pipeline is not set up for this kind of speed, and this is a blocking operation at the moment. Note that we will get an update at the end of the move because OnModify does it. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6819 --- pcbnew/tools/edit_tool.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pcbnew/tools/edit_tool.cpp b/pcbnew/tools/edit_tool.cpp index 7f5083e6eb..c540c09626 100644 --- a/pcbnew/tools/edit_tool.cpp +++ b/pcbnew/tools/edit_tool.cpp @@ -403,8 +403,6 @@ int EDIT_TOOL::doMoveSelection( TOOL_EVENT aEvent, bool aPickReference ) { if( m_dragging && evt->Category() == TC_MOUSE ) { - bool requestRedraw3Dview = false; - VECTOR2I mousePos( controls->GetMousePosition() ); m_cursor = grid.BestSnapAnchor( mousePos, item_layers, sel_items ); @@ -437,14 +435,8 @@ int EDIT_TOOL::doMoveSelection( TOOL_EVENT aEvent, bool aPickReference ) // group and not its descendants. if( !item->GetParent() || !item->GetParent()->IsSelected() ) static_cast( item )->Move( movement ); - - if( item->Type() == PCB_FOOTPRINT_T ) - requestRedraw3Dview = true; } - if( requestRedraw3Dview ) - editFrame->Update3DView( true ); - m_toolMgr->PostEvent( EVENTS::SelectedItemsMoved ); } else if( !m_dragging && !evt->IsAction( &ACTIONS::refreshPreview ) )