From 2467b7e6c5a77d7308f33e2446f6c0c87a6933c3 Mon Sep 17 00:00:00 2001 From: Johannes Maibaum Date: Tue, 23 Mar 2021 12:19:38 +0100 Subject: [PATCH] Do not explicitly strip binaries on Linux Fedora, Flatpak, Debian, and possibly other distributions as well, have packaging helpers who will strip out debug symbols into separate debug packages. Currently, the explicitly added "-s" EXE_LINKER_FLAG renders these automatically created debug packages completely useless, so this change removes it. --- CMakeLists.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f2e3aab386..ab3f58d6c6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -397,14 +397,6 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) # Allow linking for Boost for the UUID against bcrypt set( EXTRA_LIBS "bcrypt" ) - - elseif( NOT APPLE ) - # Thou shalt not link vaporware and tell us it's a valid DSO (apple ld doesn't support it) - # temporarily disabled due to breaking ASAN-enabled builds - Tom - # set( CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined" ) - # set( CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined" ) - - set( CMAKE_EXE_LINKER_FLAGS_RELEASE "-s" ) endif() if( APPLE )