From 2e311f59a8338910f5b30657bbb3081dbc43374b Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sun, 12 Nov 2023 14:30:47 +0000 Subject: [PATCH] Regression test for variable resolution in complex hierarchies. --- .../eeschema/erc/test_erc_hierarchical_schematics.cpp | 9 +++++++-- qa/tests/eeschema/erc/test_erc_label_not_connected.cpp | 9 +++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/qa/tests/eeschema/erc/test_erc_hierarchical_schematics.cpp b/qa/tests/eeschema/erc/test_erc_hierarchical_schematics.cpp index b33803bb93..85366427c9 100644 --- a/qa/tests/eeschema/erc/test_erc_hierarchical_schematics.cpp +++ b/qa/tests/eeschema/erc/test_erc_hierarchical_schematics.cpp @@ -44,8 +44,12 @@ BOOST_FIXTURE_TEST_CASE( ERCHierarchicalSchematics, ERC_REGRESSION_TEST_FIXTURE // Check not-connected ERC errors - std::vector> tests = { { "issue10926_1", 3 }, - { "issue12814", 0 } }; + std::vector> tests = + { + { "issue10926_1", 3 }, + { "issue12814", 0 }, + { "ERC_dynamic_power_symbol_test", 5 } + }; for( const std::pair& test : tests ) { @@ -66,6 +70,7 @@ BOOST_FIXTURE_TEST_CASE( ERCHierarchicalSchematics, ERC_REGRESSION_TEST_FIXTURE tester.TestNoConnectPins(); tester.TestPinToPin(); tester.TestSimilarLabels(); + tester.TestTextVars( nullptr ); errors.SetSeverities( RPT_SEVERITY_ERROR | RPT_SEVERITY_WARNING ); diff --git a/qa/tests/eeschema/erc/test_erc_label_not_connected.cpp b/qa/tests/eeschema/erc/test_erc_label_not_connected.cpp index b74d0bb8e0..6c47adae6b 100644 --- a/qa/tests/eeschema/erc/test_erc_label_not_connected.cpp +++ b/qa/tests/eeschema/erc/test_erc_label_not_connected.cpp @@ -48,10 +48,10 @@ BOOST_FIXTURE_TEST_CASE( ERCLabelNotConnected, ERC_REGRESSION_TEST_FIXTURE ) std::vector> tests = { - { "erc_pin_not_connected_basic", 2 }, - { "issue7203", 3 }, - { "issue11926", 2 }, - { "issue10430", 8 } + { "erc_pin_not_connected_basic", 2 }, + { "issue7203", 3 }, + { "issue11926", 2 }, + { "issue10430", 8 } }; for( const std::pair& test : tests ) @@ -73,6 +73,7 @@ BOOST_FIXTURE_TEST_CASE( ERCLabelNotConnected, ERC_REGRESSION_TEST_FIXTURE ) tester.TestNoConnectPins(); tester.TestPinToPin(); tester.TestSimilarLabels(); + tester.TestTextVars( nullptr ); errors.SetSeverities( RPT_SEVERITY_ERROR | RPT_SEVERITY_WARNING );