From 338914c7cf5d8b923f22e8b541a2bf6ebfd0ae65 Mon Sep 17 00:00:00 2001 From: Alex Shvartzkop Date: Tue, 16 Jan 2024 12:12:56 +0300 Subject: [PATCH] Restore Fix Discontinuities default tolerance; enable it by default. There's no artifacts anymore due to CalcArcCenter fixes. --- pcbnew/import_gfx/dialog_import_graphics.cpp | 2 +- pcbnew/pcbnew_settings.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pcbnew/import_gfx/dialog_import_graphics.cpp b/pcbnew/import_gfx/dialog_import_graphics.cpp index 6bb62dfea9..289916f2a8 100644 --- a/pcbnew/import_gfx/dialog_import_graphics.cpp +++ b/pcbnew/import_gfx/dialog_import_graphics.cpp @@ -45,7 +45,7 @@ bool DIALOG_IMPORT_GRAPHICS::s_useDlgLayerSelection = true; bool DIALOG_IMPORT_GRAPHICS::s_placementInteractive = true; bool DIALOG_IMPORT_GRAPHICS::s_shouldGroupItems = true; bool DIALOG_IMPORT_GRAPHICS::s_fixDiscontinuities = true; -int DIALOG_IMPORT_GRAPHICS::s_toleranceValue = pcbIUScale.mmToIU( 0.01 ); +int DIALOG_IMPORT_GRAPHICS::s_toleranceValue = pcbIUScale.mmToIU( 1.0 ); double DIALOG_IMPORT_GRAPHICS::s_importScale = 1.0; // Do not change the imported items size diff --git a/pcbnew/pcbnew_settings.cpp b/pcbnew/pcbnew_settings.cpp index 9f7ab172fc..0a24533281 100644 --- a/pcbnew/pcbnew_settings.cpp +++ b/pcbnew/pcbnew_settings.cpp @@ -447,10 +447,10 @@ PCBNEW_SETTINGS::PCBNEW_SETTINGS() &m_ImportGraphics.group_items, true ) ); m_params.emplace_back( new PARAM( "import_graphics.fix_discontinuities", - &m_ImportGraphics.fix_discontinuities, false ) ); + &m_ImportGraphics.fix_discontinuities, true ) ); m_params.emplace_back( new PARAM( "import_graphics.tolerance", - &m_ImportGraphics.tolerance, 0.01, 0.0, 10.0 ) ); + &m_ImportGraphics.tolerance, 1.0, 0.0, 10.0 ) ); m_params.emplace_back( new PARAM( "import_graphics.line_width_units", &m_ImportGraphics.dxf_line_width_units, 0 ) );