From 35da498a329610f6f81ff57af6c27727d1fc5b3f Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Sat, 8 Jun 2019 12:01:24 -0700 Subject: [PATCH] bitmap2component: Fix logic for alpha mask For POTRACE, black is the foreground and white is the background. We should keep the convention by requiring the pixin to be less than the black threshhold as well as the alpha to be at least the alpha threshhold. Fixes: lp:1821563 * https://bugs.launchpad.net/kicad/+bug/1821563 (cherry picked from commit f1704fd61a60058acfac0ef411c853f756b65ccc) --- bitmap2component/bitmap2cmp_gui.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitmap2component/bitmap2cmp_gui.cpp b/bitmap2component/bitmap2cmp_gui.cpp index 1759b6b8df..49c14cf92b 100644 --- a/bitmap2component/bitmap2cmp_gui.cpp +++ b/bitmap2component/bitmap2cmp_gui.cpp @@ -461,7 +461,7 @@ void BM2CMP_FRAME::Binarize( double aThreshold ) auto alpha = m_Greyscale_Image.HasAlpha() ? m_Greyscale_Image.GetAlpha( x, y ) : wxALPHA_OPAQUE; - if( pixin < threshold || alpha < alpha_thresh ) + if( pixin < threshold && alpha > alpha_thresh ) pixout = 0; else pixout = 255;