From 3894314ab214686a15b394f75148cc95110b9f94 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Tue, 11 Apr 2023 10:54:50 +0200 Subject: [PATCH] DIALOG_SHIM: fix missing aEvent.Skip() in DIALOG_SHIM::onChildSetFocus(). This method was added in commit a914f6e9. Missing Skip() created issues on Windows (text edit cursor not shown in dialogs) Fixes https://gitlab.com/kicad/code/kicad/issues/14692 (cherry picked from commit e208685f85ee996c7cc589ed7119a32fceac7bf2) --- common/dialog_shim.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/dialog_shim.cpp b/common/dialog_shim.cpp index b0d50ab704..1e9889a9d0 100644 --- a/common/dialog_shim.cpp +++ b/common/dialog_shim.cpp @@ -579,6 +579,8 @@ void DIALOG_SHIM::onChildSetFocus( wxFocusEvent& aEvent ) m_beforeEditValues[ textCtrl ] = textCtrl->GetValue(); else if( wxStyledTextCtrl* scintilla = dynamic_cast( aEvent.GetEventObject() ) ) m_beforeEditValues[ scintilla ] = scintilla->GetText(); + + aEvent.Skip(); }