From 439cc6a967f2298cdf5906df46395072ed806495 Mon Sep 17 00:00:00 2001 From: Maciej Suminski Date: Wed, 2 May 2018 15:34:04 +0200 Subject: [PATCH] Remove redundant window scroll event handlers in WX_VIEW_CONTROLS The only required scroll event handler is wxEVT_SCROLLWIN_THUMBTRACK, which is responsible for dragging the scrolling sliders. One of the remaining ones is also called when mousewheel is scrolled (MSW only) and due to that overrides the new view setting with view settings computed from the sliders position. Fixes: lp:1767604 * https://bugs.launchpad.net/kicad/+bug/1767604 --- common/view/wx_view_controls.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/common/view/wx_view_controls.cpp b/common/view/wx_view_controls.cpp index 0ad8d2bf9c..4306865b85 100644 --- a/common/view/wx_view_controls.cpp +++ b/common/view/wx_view_controls.cpp @@ -67,14 +67,6 @@ WX_VIEW_CONTROLS::WX_VIEW_CONTROLS( VIEW* aView, wxScrolledCanvas* aParentPanel wxMouseEventHandler( WX_VIEW_CONTROLS::onLeave ), NULL, this ); m_parentPanel->Connect( wxEVT_SCROLLWIN_THUMBTRACK, wxScrollWinEventHandler( WX_VIEW_CONTROLS::onScroll ), NULL, this ); - m_parentPanel->Connect( wxEVT_SCROLLWIN_LINEUP, - wxScrollWinEventHandler( WX_VIEW_CONTROLS::onScroll ), NULL, this ); - m_parentPanel->Connect( wxEVT_SCROLLWIN_LINEDOWN, - wxScrollWinEventHandler( WX_VIEW_CONTROLS::onScroll ), NULL, this ); - m_parentPanel->Connect( wxEVT_SCROLLWIN_PAGEUP, - wxScrollWinEventHandler( WX_VIEW_CONTROLS::onScroll ), NULL, this ); - m_parentPanel->Connect( wxEVT_SCROLLWIN_PAGEDOWN, - wxScrollWinEventHandler( WX_VIEW_CONTROLS::onScroll ), NULL, this ); m_panTimer.SetOwner( this ); this->Connect( wxEVT_TIMER,