From 43c7cfec3a3f78626eb0836823ab22a916f484fd Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Tue, 22 Aug 2023 17:21:15 +0200 Subject: [PATCH] Revert "Record hole knockouts in zone filler earlier" This reverts commit 3030c80de7cc2c28ed9e76ef2ae1ac8c6e4660b3. The commit #3030c80d was a workaround related to a Clipper2 issue. Updating Clipper2 is a better fix --- pcbnew/zone_filler.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pcbnew/zone_filler.cpp b/pcbnew/zone_filler.cpp index b53097c0fd..eff237f555 100644 --- a/pcbnew/zone_filler.cpp +++ b/pcbnew/zone_filler.cpp @@ -1425,10 +1425,6 @@ bool ZONE_FILLER::fillCopperZone( const ZONE* aZone, PCB_LAYER_ID aLayer, PCB_LA */ buildCopperItemClearances( aZone, aLayer, noConnectionPads, clearanceHoles ); - - for( PAD* pad : thermalConnectionPads ) - addHoleKnockout( pad, 0, clearanceHoles ); - DUMP_POLYS_TO_COPPER_LAYER( clearanceHoles, In3_Cu, wxT( "clearance-holes" ) ); if( m_progressReporter && m_progressReporter->IsCancelled() ) @@ -1579,6 +1575,9 @@ bool ZONE_FILLER::fillCopperZone( const ZONE* aZone, PCB_LAYER_ID aLayer, PCB_LA * islands */ + for( PAD* pad : thermalConnectionPads ) + addHoleKnockout( pad, 0, clearanceHoles ); + aFillPolys.BooleanIntersection( aMaxExtents, SHAPE_POLY_SET::PM_FAST ); DUMP_POLYS_TO_COPPER_LAYER( aFillPolys, In16_Cu, wxT( "after-trim-to-outline" ) ); aFillPolys.BooleanSubtract( clearanceHoles, SHAPE_POLY_SET::PM_FAST );